Fix query spec

Author: coalest

app/queries/distribution_summary_by_county_query.rb

@@ -26,7 +26,7 @@ class DistributionSummaryByCountyQuery
                COALESCE(c.name, 'Unspecified') county_name,
                COALESCE(c.region, 'ZZZ') county_region
         FROM distribution_totals dt
-        JOIN partner_profiles pp ON pp.id = dt.partner_id
+        LEFT JOIN partner_profiles pp ON pp.id = dt.partner_id
         LEFT JOIN partner_served_areas psa ON psa.partner_profile_id = pp.partner_id
         LEFT JOIN counties c ON c.id = psa.county_id
         UNION

spec/factories/partners.rb

@@ -24,16 +24,16 @@
     send_reminders { true }
     organization_id { Organization.try(:first).try(:id) || create(:organization).id }
 
+    transient do
+      without_profile { false }
+    end
+
     trait :approved do
       status { :approved }
     end
 
     trait :uninvited do
       status { :uninvited }
-
-      transient do
-        without_profile { false }
-      end
     end
 
     trait :awaiting_review do

spec/queries/distribution_summary_by_county_query_spec.rb

@@ -1,29 +1,41 @@
 RSpec.describe DistributionSummaryByCountyQuery do
-  let(:year) { Time.current.year }
-  let(:issued_at_last_year) { Time.current.change(year: year - 1).to_datetime }
-  let(:distributions) { [] }
-  let(:organization_id) { organization.id }
-  let(:start_date) { nil }
-  let(:end_date) { nil }
-  let(:params) { {organization_id:, start_date:, end_date:} }
+  let(:organization) { create(:organization, name: "Some Unique Name") }
+  let(:item_1) { create(:item, value_in_cents: 1050, organization: organization) }
+  let(:partner_1) do
+    create(:partner, organization:, without_profile: true) do |p|
+      p.profile = create(:partner_profile, partner: p, organization:) do |pp|
+        pp.served_areas = create_list(:partners_served_area, 4, partner_profile: pp, client_share: 25) do |sa|
+          sa.county = create(:county)
+        end
+      end
+    end
+  end
+  let(:partner_2) do
+    create(:partner, organization:, without_profile: true) do |p|
+      p.profile = create(:partner_profile, partner: p, organization:) do |pp|
+        pp.served_areas = create_list(:partners_served_area, 5, partner_profile: pp, client_share: 20) do |sa, i|
+          # create one overlapping service area
+          sa.county = i.zero? ? partner_1.profile.served_areas[0].county : create(:county)
+        end
+      end
+    end
+  end
 
-  include_examples "distribution_by_county"
+  let(:now) { Time.current.to_datetime }
 
-  before do
-    create(:storage_location, organization: organization)
-  end
+  let(:params) { {organization_id: organization.id, start_date: nil, end_date: nil} }
 
-  describe "get_breakdown" do
+  describe "call" do
     it "will have 100% unspecified shows if no served_areas" do
-      create(:distribution, :with_items, item: item_1, organization: user.organization)
+      create(:distribution, :with_items, item: item_1, organization: organization)
       breakdown = DistributionSummaryByCountyQuery.new(**params).call
       expect(breakdown.size).to eq(1)
       expect(breakdown[0]["quantity"]).to eq(100)
       expect(breakdown[0]["amount"]).to be_within(0.01).of(105000.0)
     end
 
     it "divides the item numbers and values according to the partner profile" do
-      create(:distribution, :with_items, item: item_1, organization: user.organization, partner: partner_1)
+      create(:distribution, :with_items, item: item_1, organization: organization, partner: partner_1)
       breakdown = DistributionSummaryByCountyQuery.new(**params).call
       expect(breakdown.size).to eq(5)
       expect(breakdown[4]["quantity"]).to eq(0)
@@ -35,8 +47,8 @@
     end
 
     it "handles multiple partners with overlapping service areas properly" do
-      create(:distribution, :with_items, item: item_1, organization: user.organization, partner: partner_1, issued_at: issued_at_present)
-      create(:distribution, :with_items, item: item_1, organization: user.organization, partner: partner_2, issued_at: issued_at_present)
+      create(:distribution, :with_items, item: item_1, organization: organization, partner: partner_1, issued_at: now)
+      create(:distribution, :with_items, item: item_1, organization: organization, partner: partner_2, issued_at: now)
       breakdown = DistributionSummaryByCountyQuery.new(**params).call
       num_with_45 = 0
       num_with_20 = 0