5240 Fix flash cookie overflow when uploading CSV with many invalid NDBN members (#5283)

* Add memflash to prevent flash message cookie overflow

* Update flash partial to support Memflash by using key-based access

* Test error rendering on invalid CSV upload

Author: hagiya0121

Gemfile

@@ -61,6 +61,8 @@ gem "filterrific"
 gem "jbuilder"
 # Pagination of models for use in views.
 gem "kaminari"
+# Prevents cookie overflow errors when storing large flash messages.
+gem 'memflash'
 # Web-based authorization framework.
 gem "omniauth"
 # Required to avoid authentication issues with Rails.

Gemfile.lock

@@ -385,10 +385,11 @@ GEM
       net-smtp
     marcel (1.0.4)
     matrix (0.4.2)
+    memflash (2.6.0)
+      actionpack (>= 7.0)
     memory_profiler (1.1.0)
     method_source (1.1.0)
     mini_mime (1.1.5)
-    mini_portile2 (2.8.9)
     minitest (5.25.5)
     monetize (1.12.0)
       money (~> 6.12)
@@ -419,9 +420,6 @@ GEM
       net-protocol
     newrelic_rpm (9.16.0)
     nio4r (2.7.4)
-    nokogiri (1.18.8)
-      mini_portile2 (~> 2.8.2)
-      racc (~> 1.4)
     nokogiri (1.18.8-arm64-darwin)
       racc (~> 1.4)
     nokogiri (1.18.8-x86_64-darwin)
@@ -745,7 +743,6 @@ GEM
 
 PLATFORMS
   arm64-darwin
-  ruby
   x86_64-darwin
   x86_64-linux
   x86_64-linux-gnu
@@ -796,6 +793,7 @@ DEPENDENCIES
   lograge
   magic_test
   matrix
+  memflash
   memory_profiler
   money-rails
   newrelic_rpm
@@ -843,4 +841,4 @@ DEPENDENCIES
   webmock (~> 3.25)
 
 BUNDLED WITH
-   2.6.9
+   2.7.0

app/views/shared/_flash.html.erb

@@ -1,8 +1,8 @@
 <%= turbo_frame_tag "flash" do %>
-  <% flash.each do |key, message| %>
+  <% flash.keys.each do |key| %>
     <div
       class="<%= flash_class(key) %> alert-dismissible"
       role="alert"
-      style="white-space: pre-line;"><%= message %></div>
+      style="white-space: pre-line;"><%= flash[key] %></div>
   <% end %>
 <% end %>

spec/fixtures/ndbn-many-errors-import.csv

@@ -0,0 +1,17 @@
+NDBN Member Number,Member Name
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,

spec/system/admin/ndbn_members_system_spec.rb

@@ -10,4 +10,18 @@
 
     expect(page).to have_content("NDBN Members have been updated!")
   end
+
+  context "when uploading a CSV with many errors" do
+    it "renders all error messages without cookie overflow" do
+      user = create(:super_admin)
+      sign_in(user)
+      visit admin_ndbn_members_path
+
+      import_path = "#{Rails.root}/spec/fixtures/ndbn-many-errors-import.csv"
+      attach_file("member_file", import_path)
+      click_button "Upload"
+
+      expect(page).to have_content("NDBN member can't be blank")
+    end
+  end
 end