squashme! more codespaces cleanup

Author: scooter-dangle

.devcontainer/Dockerfile

@@ -1,11 +1,11 @@
-# Installs Ruby 3.2.2. When human-essentials moves to a newer version of ruby,
+# Installs Ruby 3.4. When human-essentials moves to a newer version of ruby,
 # it will be more efficient to change the image.
 # See https://github.com/devcontainers/images/blob/main/src/ruby/history/
 #
 # See devcontainers/features#1431 for why we include the `-bookworm`
 # suffix. Once that issue is resolved, we can remove the suffix, which
 # will let us follow the debian upgrade to trixie.
-FROM mcr.microsoft.com/devcontainers/ruby:dev-3.2-bookworm
+FROM mcr.microsoft.com/devcontainers/ruby:dev-3.4-bookworm
 RUN export DEBIAN_FRONTEND=noninteractive
 RUN apt-get update && apt-get -y install vim curl gpg postgresql postgresql-contrib
 RUN cd /tmp

.devcontainer/devcontainer.json

@@ -7,10 +7,6 @@
   },
   "forwardPorts": [5432, 6080],
   "portsAttributes": {
-    "3000": {
-      "label": "Application",
-      "onAutoForward": "silent"
-    },
     "5432": {
       "label": "Database",
       "onAutoForward": "silent"
@@ -26,6 +22,8 @@
     "vscode": {
       "extensions": ["Shopify.ruby-extensions-pack"],
       "settings": {
+        // This doesn't seem to work. Not sure if we actually
+        // install+configure rvm.
         "rubyLsp.rubyVersionManager": {
           "identifier": "rvm"
         }

.devcontainer/post-create.sh

@@ -1,33 +1,26 @@
-RUBY_VERSION="$(cat .ruby-version | tr -d '\n')"
-
 # copy the file only if it doesn't already exist
 echo "*** Creating initial .env and vscode settings, if needed"
 cp -n .devcontainer/.env.codespaces .env
 mkdir -p .vscode && cp -n .devcontainer/launch.json.codespaces .vscode/launch.json
 
-# If the project's required ruby version changes from 3.2.2, this command
-# will download and compile the correct version, but it will take a long time.
-# TODO: Why do we install this RVM shim when we use rbenv later on???
-# if [ "$RUBY_VERSION" != "3.2.2" ]; then
-#   echo "*** Installing Ruby $RUBY_VERSION (this may take a while)"
-#   rvm install $RUBY_VERSION
-#   rvm use $RUBY_VERSION
-#   echo "Ruby $RUBY_VERSION installed"
-# fi
-
 echo "*** Setting up node"
-nvm install node
+nvm install node &
 
 echo "*** Setting up ruby environment"
-rbenv init bash
-rbenv init fish
-rbenv init zsh
+rbenv init bash &
+rbenv init fish &
+rbenv init zsh &
 
 # echo "*** Forcing platform version of nokogiri"
 # gem install nokogiri -v 1.18.1 --platform=ruby -- --use-system-libraries
 
+# If the project's required ruby version (specified in .ruby-version)
+# changes from 3.4.3, this command will download and compile the correct
+# version, but it will take a long time.
 echo "*** Installing rbenv-able Ruby ***"
-rbenv install --skip-existing
+rbenv install --skip-existing &
+
+wait
 
 echo "*** Running project bin/setup"
 bin/setup