Merge pull request #1618 from rubyforgood/replace_delete_button_with_deactivate_button

Replace delete button with deactivate button

Author: edwinthinks

app/controllers/partners_controller.rb

@@ -98,6 +98,32 @@ def recertify_partner
     end
   end
 
+  def deactivate
+    @partner = current_organization.partners.find(params[:id])
+    response = DiaperPartnerClient.put(partner_id: @partner.id, status: "deactivated")
+
+    if response.is_a?(Net::HTTPSuccess) && @partner.update(status: "deactivated")
+      redirect_to partners_path, notice: "#{@partner.name} successfully deactivated!"
+    else
+      redirect_to partners_path, error: "#{@partner.name} failed to deactivate!"
+    end
+  end
+
+  def reactivate
+    @partner = current_organization.partners.find(params[:id])
+
+    if @partner.status != "deactivated"
+      redirect_to(partners_path, error: "#{@partner.name} is not deactivated!") && return
+    end
+
+    response = DiaperPartnerClient.put(partner_id: @partner.id, status: "verified")
+    if response.is_a?(Net::HTTPSuccess) && @partner.update(status: "approved")
+      redirect_to partners_path, notice: "#{@partner.name} successfully reactivated!"
+    else
+      redirect_to partners_path, error: "#{@partner.name} failed to reactivate!"
+    end
+  end
+
   private
 
   def autovivifying_hash

app/helpers/application_helper.rb

@@ -62,6 +62,14 @@ def confirm_delete_msg(resource)
     "Are you sure you want to delete #{resource}?"
   end
 
+  def confirm_deactivate_msg(resource)
+    "Are you sure you want to deactivate #{resource}?"
+  end
+
+  def confirm_reactivate_msg(resource)
+    "Are you sure you want to reactivate #{resource}?"
+  end
+
   def confirm_restore_msg(resource)
     "Are you sure you want to restore #{resource}?"
   end

app/helpers/ui_helper.rb

@@ -34,6 +34,18 @@ def delete_button_to(link, options = {})
     _link_to link, { icon: "trash", type: "danger", text: "Delete", size: "xs" }.merge(options), properties
   end
 
+  def deactivate_button_to(link, options = {})
+    data = options[:no_confirm] ? {} : { data: { confirm: options[:confirm] || "Are you sure?" } }
+    properties = { method: :put, rel: "nofollow" }.merge(data)
+    _link_to link, { icon: "ban", type: "danger", text: "Deactivate", size: "xs" }.merge(options), properties
+  end
+
+  def reactivate_button_to(link, options = {})
+    data = options[:no_confirm] ? {} : { data: { confirm: options[:confirm] || "Are you sure?" } }
+    properties = { method: :put, rel: "nofollow" }.merge(data)
+    _link_to link, { icon: "repeat", type: "success", text: "Reactivate", size: "xs" }.merge(options), properties
+  end
+
   def restore_button_to(link, options = {})
     data = options[:no_confirm] ? {} : { data: { confirm: options[:confirm] || "Are you sure?" } }
     properties = { rel: "nofollow", method: :patch }.merge(data)

app/models/partner.rb

@@ -40,6 +40,10 @@ class Partner < ApplicationRecord
     where(status: status.to_sym)
   }
 
+  def deactivated?
+    status == 'deactivated'
+  end
+
   # better to extract this outside of the model
   def self.import_csv(csv, organization_id)
     csv.each do |row|

app/views/partners/_partner_row.html.erb

@@ -22,7 +22,7 @@
   </td>
   <td>
     <% case status %>
-     <% when "uninvited" %>
+    <% when "uninvited" %>
       <%= invite_button_to(invite_partner_path(partner_row), confirm: "Send an invitation to #{partner_row.name} to begin using the partner application?") %>
     <% when "invited" %>
       <%= view_button_to approve_partner_partner_path(partner_row), { text: "Review Application", icon: "check", type: "warning" } %>
@@ -32,6 +32,8 @@
       <%= button_to recertify_partner_partner_path(partner_row), data: { confirm: "Recertify partner #{partner_row.name}?"}, class: "btn btn-xs bg-red" do %>
         <i class="fa fa-refresh"></i> Request Recertification
       <% end %>
+    <% when "deactivated" %>
+      <%= reactivate_button_to reactivate_partner_path(partner_row), {confirm: confirm_reactivate_msg(partner_row.name)} %>
     <% else %>
       &nbsp;
     <% end %>

app/views/partners/show.html.erb

@@ -62,7 +62,11 @@
           <div class="card-footer">
             <%= view_button_to approve_partner_partner_path(@partner) %>
             <%= edit_button_to edit_partner_path(@partner) %>
-            <%= delete_button_to partner_path(@partner), {confirm: confirm_delete_msg(@partner.name)} %>
+            <% if @partner.deactivated? %>
+              <%= reactivate_button_to reactivate_partner_path(@partner), {confirm: confirm_reactivate_msg(@partner.name)} %>
+            <% else %>
+              <%= deactivate_button_to deactivate_partner_path(@partner), {confirm: confirm_deactivate_msg(@partner.name)} %>
+            <% end %>
             <%= modal_button_to("#addUserModal", {text: "Add/Remind Partner", size: "xs"}) if can_administrate? %>
             <%= print_button_to approve_application_partner_path(@partner), {text: "Activate Partner Now", icon: "thumbs-o-up", type: "success", size: "xs"} if can_administrate? %>
           </div>

config/routes.rb

@@ -127,6 +127,8 @@ def set_up_flipper
         post :invite
         post :re_invite
         post :recertify_partner
+        put :deactivate
+        put :reactivate
       end
     end
 

spec/models/partner_spec.rb

@@ -77,9 +77,35 @@
   #       expect(WebMock).to have_requested(:post, callback_url)
   #         .with(headers: headers, body: body).once
   #     end
+  #
   #   end
   # end
 
+  describe '#deactivated?' do
+    subject { partner.deactivated? }
+    let(:partner) { build(:partner) }
+
+    context "when the status is 'deactivated'" do
+      before do
+        partner.status = 'deactivated'
+      end
+
+      it 'should return true' do
+        expect(subject).to eq(true)
+      end
+    end
+
+    context "when the status is not 'deactivated'" do
+      before do
+        partner.status = 'invited'
+      end
+
+      it 'should return false' do
+        expect(subject).to eq(false)
+      end
+    end
+  end
+
   describe "import_csv" do
     let(:organization) { create(:organization) }
 

spec/requests/partners_requests_spec.rb

@@ -165,6 +165,42 @@
     end
   end
 
+  describe "PUT #deactivate" do
+    let(:partner) { create(:partner, organization: @organization, status: "approved") }
+
+    context "when the partner successfully deactivates" do
+      before do
+        response = double
+
+        allow(response).to receive(:is_a?).with(Net::HTTPSuccess).and_return(true)
+        allow(DiaperPartnerClient).to receive(:put).and_return(response)
+      end
+      it "changes the partner status to deactivated and redirects with flash" do
+        put deactivate_partner_path(default_params.merge(id: partner.id))
+
+        expect(partner.reload.status).to eq("deactivated")
+        expect(response).to redirect_to(partners_path)
+        expect(flash[:notice]).to eq("#{partner.name} successfully deactivated!")
+      end
+    end
+
+    context "when the partner is not successfully deactivated" do
+      before do
+        response = double
+
+        allow(response).to receive(:is_a?).with(Net::HTTPSuccess).and_return(false)
+        allow(DiaperPartnerClient).to receive(:put).and_return(response)
+      end
+      it "fails to change the partner status to deactivated and redirects with flash error message" do
+        put deactivate_partner_path(default_params.merge(id: partner.id))
+
+        expect(partner.reload.status).to eq("approved")
+        expect(response).to redirect_to(partners_path)
+        expect(flash[:error]).to eq("#{partner.name} failed to deactivate!")
+      end
+    end
+  end
+
   describe "GET #approve_application" do
     let(:partner) { create(:partner, organization: @organization) }
 
@@ -205,6 +241,38 @@
     end
   end
 
+  describe "PUT #reactivate" do
+    context "when the partner successfully reactivates" do
+      let(:partner) { create(:partner, organization: @organization, status: "deactivated") }
+
+      before do
+        response = double
+        allow(response).to receive(:is_a?).with(Net::HTTPSuccess).and_return(true)
+        allow(DiaperPartnerClient).to receive(:put).and_return(response)
+      end
+
+      it "changes the partner status to approved, partner status on partner app to verified, and redirects with flash" do
+        put reactivate_partner_path(default_params.merge(id: partner.id))
+
+        expect(partner.reload.status).to eq("approved")
+        expect(response).to redirect_to(partners_path)
+        expect(flash[:notice]).to eq("#{partner.name} successfully reactivated!")
+      end
+    end
+
+    context "when trying to reactivate a partner who is not deactivated " do
+      let(:partner) { create(:partner, organization: @organization, status: "approved") }
+      before do
+        allow(DiaperPartnerClient).to receive(:put)
+      end
+      it "fails to change the partner status to reactivated and redirects with flash error message" do
+        put reactivate_partner_path(default_params.merge(id: partner.id))
+
+        expect(DiaperPartnerClient).not_to have_received(:put)
+      end
+    end
+  end
+
   describe "POST #recertify_partner" do
     let(:partner) { create(:partner, organization: @organization) }