Merge pull request #5394 from jonny5/jk-flaky-date-tests

Flaky date range specs

Author: awwaiid

spec/support/date_range_picker_shared_example.rb

@@ -141,7 +141,7 @@ def date_range_picker_select_range(range_name)
 
       valid_date_range = "#{Time.zone.local(2019, 7, 22).to_fs(:date_picker)} - #{Time.zone.local(2019, 7, 28).to_fs(:date_picker)}"
       fill_in "filters_date_range", with: valid_date_range
-      find(:id, 'filters_date_range').native.send_keys(:enter)
+      click_button "Filter"
       expect(page).to have_css("table tbody tr", count: 1)
     end
   end

spec/system/adjustment_system_spec.rb

@@ -39,7 +39,9 @@
       before do
         visit subject
         click_on "New Adjustment"
-        select storage_location.name, from: "From storage location"
+        await_select2("#adjustment_line_items_attributes_0_item_id") do
+          select storage_location.name, from: "From storage location"
+        end
         fill_in "Comment", with: "something"
         select Item.last.name, from: "adjustment_line_items_attributes_0_item_id"
       end
@@ -67,7 +69,9 @@
         storage_location = create(:storage_location, :with_items, name: "PICK THIS ONE", item_quantity: 10, organization: organization)
         visit adjustments_path
         click_on "New Adjustment"
-        select storage_location.name, from: "From storage location"
+        await_select2("#adjustment_line_items_attributes_0_item_id") do
+          select storage_location.name, from: "From storage location"
+        end
         fill_in "Comment", with: "something"
         select Item.last.name, from: "adjustment_line_items_attributes_0_item_id"
         fill_in "adjustment_line_items_attributes_0_quantity", with: sub_quantity.to_s
@@ -84,7 +88,9 @@
         storage_location = create(:storage_location, :with_items, name: "PICK THIS ONE", item_quantity: 10, organization: organization)
         visit adjustments_path
         click_on "New Adjustment"
-        select storage_location.name, from: "From storage location"
+        await_select2("#adjustment_line_items_attributes_0_item_id") do
+          select storage_location.name, from: "From storage location"
+        end
         fill_in "Comment", with: "something"
         select Item.last.name, from: "adjustment_line_items_attributes_0_item_id"
         fill_in "adjustment_line_items_attributes_0_quantity", with: sub_quantity.to_s

spec/system/item_system_spec.rb

@@ -205,4 +205,3 @@
     end
   end
 end
-