4217 eliminate checking factory items (#5234)

* Removed non required fields from Organization factory

* Updated tests that relied on non required fields from factory to set these fields themselves

* Fixed various specs counting the ActiveStorage::AnalyzeJob job created when the organization was created with a logo image

* Removed unused transient

* Removed non-necessary fields from storage_location and updated tests that relied on those fields or factory values

* Updated item_request to specify its values shouldn't be tested against and updated tests that relied on those factory values

* Updated line_item to specify its values shouldn't be tested against and updated tests that relied on those factory values

* Updated product_drive to specify its values shouldn't be tested against and updated tests that relied on those factory values

* Removed non-necessary fields from purchase and updated tests that relied on those fields or factory values

* Removed non-necessary fields from product_drive_participant, added trait to explicitly nil contact_name and email, and updated tests that relied on those fields or factory values

* Removed non-necessary fields from global_barcode_item and barcode_item, and updated tests that relied on those fields or factory values

* Removed non-necessary field from partner_profile, set no_social_media_presence to false to avoid various validations failing, and updated tests that relied on those fields or factory values

* Removed non-necessary field from donation

* Updated tests that relied on removed fields of donation and storage_location

* Updated tests that relied on removed fields of donation, line_item, and product_drive_participant

* Removed non-necessary fields from counties and updated tests that relied on those fields or factory values

* Removed non-necessary fields from various factories that did not break any tests

* Changes made by linter

* Added default, catch-all stup to Geocoder lookup so specific addresses don't need to be used

* Removed apostrophes from default names to not break tests that compare raw strings to encoded HTML

* Removed factory comment added by other branch

* Removed outdated comment

Author: Benjamin-Couey

spec/controllers/distributions_controller_spec.rb

@@ -243,13 +243,13 @@
           end
           it "should schedule the reminder email" do
             subject
-            expect(enqueued_jobs[2]["arguments"][1]).to eq("reminder_email")
+            expect(enqueued_jobs[1]["arguments"][1]).to eq("reminder_email")
           end
 
           it "should not schedule a reminder for a date in the past" do
             params[:distribution][:issued_at] = Date.yesterday
             subject
-            expect(enqueued_jobs.size).to eq(2)
+            expect(enqueued_jobs.size).to eq(1)
           end
         end
 
@@ -258,7 +258,7 @@
 
           it "should not schedule an email reminder for a partner that disabled reminders" do
             subject
-            expect(enqueued_jobs.size).to eq(1)
+            expect(enqueued_jobs.size).to eq(0)
           end
         end
       end
@@ -419,13 +419,13 @@
           end
           it "should schedule the reminder email" do
             subject
-            expect(enqueued_jobs[1]["arguments"][1]).to eq("reminder_email")
+            expect(enqueued_jobs.first["arguments"][1]).to eq("reminder_email")
           end
 
           it "should not schedule a reminder for a date in the past" do
             params[:distribution][:issued_at] = Date.yesterday
             subject
-            expect(enqueued_jobs.size).to eq(1)
+            expect(enqueued_jobs.size).to eq(0)
           end
         end
 
@@ -434,7 +434,7 @@
 
           it "should not schedule an email reminder for a partner that disabled reminders" do
             subject
-            expect(enqueued_jobs.size).to eq(1)
+            expect(enqueued_jobs.size).to eq(0)
           end
         end
       end

spec/factories/adjustments.rb

@@ -15,7 +15,6 @@
   factory :adjustment do
     organization { Organization.try(:first) || create(:organization) }
     storage_location
-    comment { "A comment" }
     user { organization.users.try(:first) || create(:user, organization_id: organization.id) }
 
     trait :with_items do

spec/factories/audits.rb

@@ -18,7 +18,6 @@
     user { nil }
     storage_location { nil }
     adjustment { nil }
-    status { :in_progress }
 
     after(:build) do |instance, evaluator|
       instance.storage_location = evaluator.storage_location || create(:storage_location, organization: instance.organization)

spec/factories/barcode_items.rb

@@ -15,15 +15,14 @@
 FactoryBot.define do
   factory :global_barcode_item, class: "BarcodeItem" do
     sequence(:value) { (SecureRandom.random_number * (10**12)).to_i } # 037000863427
-    quantity { 50 }
+    quantity { 999 } # Don't test this number
     barcodeable { BaseItem.all.sample || create(:base_item) }
-    barcodeable_type { "BaseItem" }
   end
 
   factory :barcode_item, class: "BarcodeItem" do
     organization { Organization.try(:first) || create(:organization) }
     sequence(:value) { (SecureRandom.random_number * (10**12)).to_i } # 037000863427
-    quantity { 50 }
+    quantity { 999 } # Don't test this number
     barcodeable { nil }
 
     after(:build) do |instance, evaluator|

spec/factories/base_items.rb

@@ -16,8 +16,8 @@
 
 FactoryBot.define do
   factory :base_item do
-    sequence(:name) { |size| "#{size}T Diapers" }
+    sequence(:name) { |size| "#{size}Dont test this" }
     size { nil }
-    sequence(:partner_key) { |n| "#{n}t_diapers" }
+    sequence(:partner_key) { |n| "#{n}dont_test_this" }
   end
 end

spec/factories/broadcast_announcements.rb

@@ -15,6 +15,6 @@
   factory :broadcast_announcement do
     user
     organization
-    message { "test" }
+    message { "Dont test this" }
   end
 end

spec/factories/counties.rb

@@ -11,8 +11,6 @@
 #
 FactoryBot.define do
   factory :county do
-    sequence(:name) { |n| "County #{n}" }
     region { Faker::Address.state }
-    category { "US_County" }
   end
 end

spec/factories/donation_sites.rb

@@ -19,7 +19,7 @@
   factory :donation_site do
     organization { Organization.try(:first) || create(:organization) }
     name { Faker::Company.name.tr(",", ";") }
-    address { "1500 Remount Road, Front Royal, VA 22630" }
+    address { "Dont test this" }
     active { true }
     contact_name { Faker::Name.name }
     email { Faker::Internet.email }

spec/factories/donations.rb

@@ -20,7 +20,6 @@
 FactoryBot.define do
   factory :donation do
     source { Donation::SOURCES[:misc] }
-    comment { "It's a fine day for diapers." }
     storage_location
     organization { Organization.try(:first) || create(:organization) }
     issued_at { Time.current }

spec/factories/inventory_items.rb

@@ -12,7 +12,6 @@
 
 FactoryBot.define do
   factory :inventory_item do
-    quantity { 300 }
     item
     storage_location
   end