4739 Prevent deletion of product drives with donations (#5303)

* feat: prevent deletion of ProductDrives with donations

* test: add request spec to prevent deletion of product drives with donations

* change: use model error message for product drive deletion failure

Author: hagiya0121

app/controllers/product_drives_controller.rb

@@ -88,10 +88,18 @@ def update
   end
 
   def destroy
-    current_organization.product_drives.find(params[:id]).destroy
+    product_drive = current_organization.product_drives.find(params[:id])
+    success = product_drive.destroy
+
     respond_to do |format|
-      format.html { redirect_to product_drives_url, notice: 'Product drive was successfully destroyed.' }
-      format.json { head :no_content }
+      if success
+        format.html { redirect_to product_drives_url, notice: 'Product drive was successfully destroyed.' }
+        format.json { head :no_content }
+      else
+        error_message = product_drive.errors.full_messages.to_sentence
+        format.html { redirect_to product_drive_path(product_drive), error: error_message }
+        format.json { render json: {error: error_message}, status: :unprocessable_entity }
+      end
     end
   end
 

app/models/product_drive.rb

@@ -31,7 +31,7 @@ class ProductDrive < ApplicationRecord
           search_dates[:end_date])
   }
 
-  has_many :donations, dependent: :nullify
+  has_many :donations, dependent: :restrict_with_error
   has_many :product_drive_participants, -> { distinct }, through: :donations
   validates :name, presence:
     { message: "A name must be chosen." }

spec/requests/product_drives_requests_spec.rb

@@ -294,12 +294,22 @@
     end
 
     describe "DELETE #destroy" do
-      it "redirects to the index" do
-        product_drive = create(:product_drive, organization: organization)
+      let(:product_drive) { create(:product_drive, organization: organization) }
 
+      it "redirects to the index" do
         delete product_drive_path(id: product_drive.id)
         expect(response).to redirect_to(product_drives_path)
       end
+
+      context "when the product drive has associated donations" do
+        it "does not delete and redirects with an error" do
+          create(:donation, product_drive: product_drive)
+
+          delete product_drive_path(id: product_drive.id)
+          expect(response).to redirect_to(product_drive_path(product_drive))
+          expect(flash[:error]).to eq("Cannot delete record because dependent donations exist")
+        end
+      end
     end
   end
 end