Fix failing tests because of array indices

Author: Sukhpreet-s

spec/models/partner_spec.rb

@@ -299,8 +299,8 @@
     let(:agency_type) { Partner::AGENCY_TYPES["OTHER"] }
     let(:other_agency_type) { "Another Agency Name" }
     let(:notes) { "Some notes" }
-    let(:providing_diapers) { "N" }
-    let(:providing_period_supplies) { "N" }
+    let(:providing_diapers) { {value: "N", index: 13} }
+    let(:providing_period_supplies) { {value: "N", index: 14} }
 
     before do
       partner.profile.update({
@@ -343,18 +343,18 @@
         contact_email,
         notes,
         correctly_ordered_counties,
-        providing_diapers,
-        providing_period_supplies
+        providing_diapers[:value],
+        providing_period_supplies[:value]
       ])
     end
 
     context "when partner has a distribution in the last 12 months" do
-      let(:providing_diapers) { "Y" }
-      let(:providing_period_supplies) { "Y" }
       let(:distribution) { create(:distribution, partner: partner) }
 
       shared_examples "providing_diapers check" do |scope|
         before do
+          providing_diapers[:value] = "Y"
+
           case scope
           when :disposable
             item = create(:item, base_item: create(:base_item, category: "Diapers - Childrens"))
@@ -366,7 +366,7 @@
         end
 
         it "should have Y as providing_diapers" do
-          expect(partner.csv_export_attributes[12]).to eq(providing_diapers)
+          expect(partner.csv_export_attributes[providing_diapers[:index]]).to eq(providing_diapers[:value])
         end
       end
 
@@ -380,12 +380,14 @@
 
       context "with a period supplies item" do
         before do
+          providing_period_supplies[:value] = "Y"
+
           item = create(:item, base_item: create(:base_item, category: "Menstrual Supplies/Items"))
           create(:line_item, item: item, itemizable: distribution)
         end
 
         it "should have Y as providing_period_supplies" do
-          expect(partner.csv_export_attributes[13]).to eq(providing_period_supplies)
+          expect(partner.csv_export_attributes[providing_period_supplies[:index]]).to eq(providing_period_supplies[:value])
         end
       end
     end
@@ -403,11 +405,11 @@
       end
 
       it "should have N as providing_diapers" do
-        expect(partner.csv_export_attributes[12]).to eq(providing_diapers)
+        expect(partner.csv_export_attributes[providing_diapers[:index]]).to eq(providing_diapers[:value])
       end
 
       it "should have N as providing_period_supplies" do
-        expect(partner.csv_export_attributes[13]).to eq(providing_period_supplies)
+        expect(partner.csv_export_attributes[providing_period_supplies[:index]]).to eq(providing_period_supplies[:value])
       end
     end
   end