Skip to content

Commit 4713348

Browse files
authored
Sort secondarily off of id for identical name stability (#5339)
Which fixes flaky tests if nothing else
1 parent 7e85135 commit 4713348

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

app/controllers/partners/children_controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ def sort_direction
101101

102102
helper_method :sort_column # used in SortableHelper
103103
def sort_column
104-
Child.column_names.include?(params[:sort]) ? params[:sort] : "last_name"
104+
Child.column_names.include?(params[:sort]) ? params[:sort] : "last_name, id"
105105
end
106106

107107
helper_method :fetch_valid_item_name

app/controllers/partners/families_controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def sort_direction
100100
end
101101

102102
def sort_column
103-
Family.column_names.include?(params[:sort]) ? params[:sort] : "guardian_last_name"
103+
Family.column_names.include?(params[:sort]) ? params[:sort] : "guardian_last_name, id"
104104
end
105105

106106
def archive_children

0 commit comments

Comments
 (0)