Added agency_types_for_selection function to provide sorted agency types for dropdown

Author: Benjamin-Couey

app/models/partners/profile.rb

@@ -174,6 +174,11 @@ def county_list_by_region
       counties.order(%w(lower(region) lower(name))).pluck(:name).join("; ")
     end
 
+    def self.agency_types_for_selection
+      # alphabetize based on the translated version, as that is the text users will actually read
+      agency_types.keys.map(&:to_sym).sort_by { |sym| I18n.t(sym, scope: :partners_profile) }.partition { |v| v != :other }.flatten
+    end
+
     private
 
     def check_social_media

app/views/partners/profiles/edit/_agency_information.html.erb

@@ -11,7 +11,7 @@
             <%= profile_form.input :agency_type,
             # Symbolize keys, because simple_form will only do a I18n lookup for
             # symbols
-              collection: Partners::Profile.agency_types.keys.map(&:to_sym),
+              collection: Partners::Profile.agency_types_for_selection,
               label: "Agency Type",
               class: "form-control",
               wrapper: :input_group %>

app/views/partners/profiles/step/_agency_information_form.html.erb

@@ -7,7 +7,7 @@
     <%= pf.input :agency_type,
     # Symbolize keys, because simple_form will only do a I18n lookup for
     # symbols
-      collection: Partners::Profile.agency_types.keys.map(&:to_sym),
+      collection: Partners::Profile.agency_types_for_selection,
       label: "Agency Type",
       class: "form-control",
       wrapper: :input_group %>