Remove methods and test set up to calculate per person per month

Author: jadekstewart3

app/services/reports/period_supply_report_service.rb

@@ -15,7 +15,6 @@ def report
       @report ||= {name: "Period Supplies",
                    entries: {
                      "Period supplies distributed" => number_with_delimiter(total_distributed_period_supplies),
-                     "Period supplies per adult per month" => (monthly_supplies + distributed_period_supplies_from_kits_per_month)&.round,
                      "Period supplies" => types_of_supplies,
                      "% period supplies donated" => "#{percent_donated.round}%",
                      "% period supplies bought" => "#{percent_bought.round}%",
@@ -37,27 +36,10 @@ def distributed_period_supplies_from_kits
       kit_items_calculation("distributions", "Distribution")
     end
 
-    def distributed_period_supplies_from_kits_per_month
-      distributed_period_supplies_from_kits / 12 || 0
-    end
-
     def total_distributed_period_supplies
       distributed_loose_period_supplies + distributed_period_supplies_from_kits
     end
 
-    # @return [Integer]
-    def monthly_supplies
-      # NOTE: This is asking "per adult per month" but there doesn't seem to be much difference
-      # in calculating per month or per any other time frame, since all it's really asking
-      # is the value of the `distribution_quantity` field for the items we're giving out.
-      organization
-        .distributions
-        .for_year(year)
-        .joins(line_items: :item)
-        .merge(Item.period_supplies)
-        .average("COALESCE(items.distribution_quantity, 50)") || 0
-    end
-
     def types_of_supplies
       organization.items.period_supplies.map(&:name).uniq.sort.join(", ")
     end

spec/services/reports/period_supply_report_service_spec.rb

@@ -13,7 +13,6 @@
           "% period supplies bought" => "0%",
           "% period supplies donated" => "0%",
           "Period supplies distributed" => "0",
-          "Period supplies per adult per month" => 0,
           "Money spent purchasing period supplies" => "$0.00"
         }))
         expect(report.report[:entries]["Period supplies"].split(", "))
@@ -77,11 +76,6 @@
 
         create(:line_item, :purchase, quantity: 30, item: purchased_period_supply_kit.item, itemizable: kit_purchase)
 
-        # create(:purchase, issued_at: within_time, organization: organization, line_items: [
-        #   create(:line_item, :purchase, item: period_supplies_kit_item, quantity: 5),
-        #   create(:line_item, :purchase, item: purchased_period_supply_kit_item, quantity: 5)
-        # ])
-
         # Distributions
         distributions = create_list(:distribution, 2, issued_at: within_time, organization: organization)
         outside_distributions = create_list(:distribution, 2, issued_at: outside_time, organization: organization)
@@ -143,7 +137,6 @@
             "% period supplies bought" => "67%",
             "% period supplies donated" => "33%",
             "Period supplies distributed" => "2,300",
-            "Period supplies per adult per month" => 45,
             "Money spent purchasing period supplies" => "$40.00"
           }))
           expect(report.report[:entries]["Period supplies"].split(", "))