Fix for #5361

Modified storage_location model to include validate name for uniqueness within the scope of orginization id, case sensitive false

modified storage_locations factory to use a sequence for the name as long as no name is given.

added a test for the validation in storage location spec

Modified storage_location system spec to test for same name and case insensitive name

Co-authored-by: Brody Fischer <[email protected]>

Author: Tyler-Fanuele

app/models/storage_location.rb

@@ -44,6 +44,7 @@ class StorageLocation < ApplicationRecord
                           dependent: :destroy
 
   validates :name, :address, presence: true
+  validates :name, uniqueness: { scope: :organization_id, case_sensitive: false}
   validates :warehouse_type, inclusion: { in: WAREHOUSE_TYPES },
                              allow_blank: true
   validates :square_footage, numericality: { greater_than_or_equal_to: 0 }, allow_nil: true

spec/factories/storage_locations.rb

@@ -20,7 +20,7 @@
 
 FactoryBot.define do
   factory :storage_location do
-    name { "Dont test this name" }
+    sequence(:name) { |n| "Dont test this name #{n}" }
     address { "Dont test this address" }
     organization { Organization.try(:first) || create(:organization) }
 

spec/models/storage_location_spec.rb

@@ -20,6 +20,7 @@
 
   context "Validations >" do
     it { is_expected.to validate_presence_of(:name) }
+    it { is_expected.to validate_uniqueness_of(:name).scoped_to(:organization_id).case_insensitive }
     it { is_expected.to validate_presence_of(:address) }
     it "ensures that square_footage cannot be negative" do
       expect(build(:storage_location, square_footage: -1)).not_to be_valid

spec/system/storage_location_system_spec.rb

@@ -20,6 +20,28 @@
       expect(page.find(".alert")).to have_content "added"
     end
 
+    it "User creates a new storage location with the same name" do
+      visit subject
+      storage_location1 = create(:storage_location, name: "non-Unique Name")
+
+      fill_in "Name", with: storage_location1.name
+      fill_in "Address", with: storage_location1.address
+      click_on "Save"
+
+      expect(page).to have_content "Name has already been taken"
+    end
+
+    it "User creates a new storage location with the same name with different casing" do
+      visit subject
+      storage_location1 = create(:storage_location, name: "non-Unique Name")
+
+      fill_in "Name", with: storage_location1.name.upcase
+      fill_in "Address", with: storage_location1.address
+      click_on "Save"
+
+      expect(page).to have_content "Name has already been taken"
+    end
+
     it 'User creates a new storage location with optional fields' do
       visit subject
       storage_location_traits = attributes_for(:storage_location)