5428 move purchases logic to vendors controller, fix spec to test the view through the response.body

Author: janeewheatley

app/controllers/vendors_controller.rb

@@ -47,6 +47,7 @@ def edit
 
   def show
     @vendor = current_organization.vendors.includes(:purchases).find(params[:id])
+    @purchases = @vendor.purchases.order(issued_at: :desc)
   end
 
   def update

app/views/vendors/show.html.erb

@@ -74,7 +74,7 @@
               </tr>
               </thead>
               <tbody>
-              <% @vendor.purchases.order(issued_at: :desc).each do |purchase| %>
+              <% @purchases.each do |purchase| %>
                 <tr>
                   <td><%= purchase.issued_at.strftime("%m/%d/%Y") %></td>
                   <td><%= purchase.line_items.total %></td>

spec/requests/vendors_requests_spec.rb

@@ -134,8 +134,15 @@
 
         get vendor_path(vendor)
 
-        expect(vendor.reload.purchases.order(issued_at: :desc).to_a).to eq([new_purchase, middle_purchase, old_purchase])
-        expect(response).to be_successful
+        old_date = old_purchase.issued_at.strftime("%m/%d/%Y")
+        middle_date = middle_purchase.issued_at.strftime("%m/%d/%Y")
+        new_date = new_purchase.issued_at.strftime("%m/%d/%Y")
+
+        dates = [new_date, middle_date, old_date]
+        dates.each { |date| expect(response.body).to include(date) }
+
+        expect(response.body.index(new_date)).to be < response.body.index(middle_date)
+        expect(response.body.index(middle_date)).to be < response.body.index(old_date)
       end
     end