Validate issued_at field to prevent future dates further than 1 year (#4749)

Author: tatheerf02

app/models/concerns/issued_at.rb

@@ -10,6 +10,7 @@ module IssuedAt
     scope :by_issued_at, ->(issued_at) { where(issued_at: issued_at.beginning_of_month..issued_at.end_of_month) }
     scope :for_year, ->(year) { where("extract(year from issued_at) = ?", year) }
     validate :issued_at_cannot_be_before_2000
+    validate :issued_at_cannot_be_further_than_1_year
   end
 
   private
@@ -23,4 +24,10 @@ def issued_at_cannot_be_before_2000
       errors.add(:issued_at, "Cannot be before 2000")
     end
   end
+
+  def issued_at_cannot_be_further_than_1_year
+    if issued_at.present? && issued_at > DateTime.now.next_year
+      errors.add(:issued_at, "cannot be more than 1 year in the future")
+    end
+  end
 end

spec/models/distribution_spec.rb

@@ -65,6 +65,11 @@
       expect(d).not_to be_valid
     end
 
+    it "ensures that the issued at is no later than 1 year" do
+      d = build(:distribution, issued_at: DateTime.now.next_year(2).to_s)
+      expect(d).not_to be_valid
+    end
+
     context "when delivery method is shipped" do
       context "shipping cost is negative" do
         let(:distribution) { build(:distribution, delivery_method: "shipped", shipping_cost: -13) }

spec/models/donation_spec.rb

@@ -54,6 +54,10 @@
       d = build(:donation, issued_at: '1999-12-31')
       expect(d).not_to be_valid
     end
+    it "ensures that the issued at is no later than 1 year" do
+      d = build(:donation, issued_at: DateTime.now.next_year(2).to_s)
+      expect(d).not_to be_valid
+    end
   end
 
   context "Callbacks >" do

spec/models/purchase_spec.rb

@@ -80,6 +80,10 @@
       p = build(:purchase, issued_at: "1999-12-31")
       expect(p).not_to be_valid
     end
+    it "ensures that the issued at is no later than 1 year" do
+      p = build(:purchase, issued_at: DateTime.now.next_year(2).to_s)
+      expect(p).not_to be_valid
+    end
   end
 
   context "Callbacks >" do

spec/services/calendar_service_spec.rb

@@ -15,7 +15,7 @@
           partner: partner1, storage_location: storage_location)
         create(:distribution, issued_at: time_zone.local(2019, 1, 1),
           partner: partner2, storage_location: storage_location)
-        create(:distribution, issued_at: time_zone.local(2023, 3, 17),
+        create(:distribution, issued_at: time_zone.local(2022, 3, 17),
           partner: partner2, storage_location: storage_location)
         result = described_class.calendar(organization.id)
         expected = <<~ICAL
@@ -58,8 +58,8 @@
            e
           END:VEVENT
           BEGIN:VEVENT
-          DTSTART;TZID=America/New_York:20230316T210000
-          DTEND;TZID=America/New_York:20230316T211500
+          DTSTART;TZID=America/New_York:20220316T210000
+          DTEND;TZID=America/New_York:20220316T211500
           LOCATION:1500 Remount Road\\, Front Royal\\, VA 22630
           SUMMARY:Pickup from Partner 2
           URL;VALUE=URI:https://humanessentials.app/diaper_bank/distributions/schedul