Added tests to verify that double clicking on buttons does not cause repeated requests

Author: Benjamin-Couey

spec/system/distribution_system_spec.rb

@@ -887,4 +887,43 @@
 
     expect(page).to have_content("This distribution has been marked as being completed!")
   end
+
+  it "Double clicking distribution complete does not result in the distribution attemping to be completed twice" do
+    visit new_distribution_path
+    item = View::Inventory.new(organization.id).items_for_location(storage_location.id).first.db_item
+    TestInventory.create_inventory(organization,
+      {
+        storage_location.id => { item.id => 20 }
+      })
+
+    select "Test Partner", from: "Partner"
+    select "Test Storage Location", from: "From storage location"
+    choose "Delivery"
+    select item.name, from: "distribution_line_items_attributes_0_item_id"
+    fill_in "distribution_line_items_attributes_0_quantity", with: 15
+
+    click_button "Save"
+
+    within "#distributionConfirmationModal" do
+      click_button "Yes, it's correct"
+    end
+
+    # Make sure the button is there before trying to double click it
+    expect(page.find('a.btn.btn-success.btn-md[href*="/picked_up"]')).to have_content("Distribution Complete")
+
+    # Double click on the Distribution complete button
+    ferrum_double_click('a.btn.btn-success.btn-md[href*="/picked_up"]')
+    
+    # Capybara will be quick to determine that a screen doesn't have content.
+    # Make some positive assertions that only appears on the new screen to make
+    # sure it's loaded before asserting something isn't there.
+    expect(page).not_to have_content("Distribution Complete")
+    expect(page).to have_content("Complete")
+    
+    # If it tries to mark the distribution as completed twice, the second time
+    # will fail (the distribution is already complete) and show this error
+    expect(page).not_to have_content("Sorry, we encountered an error when trying to mark this distribution as being completed")
+  end
 end
+
+

spec/system/partner_system_spec.rb

@@ -30,6 +30,29 @@
 
           expect(partner_awaiting_approval.reload.approved?).to eq(true)
         end
+
+        it 'Double clicking approval button does not result in the partner attemping to be approved twice' do
+          visit partners_path
+
+          assert page.has_content? partner_awaiting_approval.name
+          click_on "Review Applicant's Profile"
+
+          # Make sure the button is there before trying to double click it
+          expect(page.find('a.btn.btn-success.btn-md[href*="/approve_application"]')).to have_content("Approve Partner")
+
+          # Double click on the Distribution complete button    
+          ferrum_double_click('a.btn.btn-success.btn-md[href*="/approve_application"]')
+
+          # Capybara will be quick to determine that a screen doesn't have content.
+          # Make some positive assertions that only appears on the new screen to make
+          # sure it's loaded before asserting something isn't there.
+          expect(page).to have_content("Partner Agencies for")
+
+          # If it tries to mark the partner as approved twice, the second time
+          # will fail (the partner is already approved) and show this error
+          expect(page).not_to have_content('Failed to approve partner because: ["partner is not waiting for approval"]')
+          # TODO: Verify multiple emails aren't sent?
+        end
       end
 
       context 'when the approval does not succeed' do