#4990 - Items Quantity and Location tab and Item Inventory tab, highlight the bank-wide items that are below their minimum (#5123)

* Added condition to highlight items with below minimum quantity

* Updated documentation

* Added spec

* Updated screenshots

* Added requests spec and removed feature spec

Author: neenu-chacko

app/helpers/items_helper.rb

@@ -19,4 +19,8 @@ def selected_item_request_units(item)
     item_request_unit_names = item.persisted? ? item.request_units.pluck(:name) : []
     current_organization.request_units.select { |unit| item_request_unit_names.include?(unit.name) }.pluck(:id)
   end
+
+  def quantity_below_minimum?(row_item)
+    row_item[:quantity] < row_item[:item_on_hand_minimum_quantity]
+  end
 end

app/views/items/_item_row_inventory.html.erb

@@ -2,7 +2,7 @@
 <tr data-widget="expandable-table" aria-expanded="false">
   <td><i class="fa" /></td>
   <td><%= link_to(row_item[:item_name], item_url(row_item[:item_id])) %></td>
-  <td class="numeric"><%= row_item[:quantity] %></td>
+  <td class="numeric <%= "text-danger font-weight-bold" if quantity_below_minimum?(row_item) %>" data-column="total"><%= row_item[:quantity] %></td>
   <td class="numeric"><%= row_item[:item_on_hand_minimum_quantity] %></td>
   <td class="numeric"><%= row_item[:item_on_hand_recommended_quantity] %></td>
 </tr>

app/views/items/_item_row_quantity_and_storages.html.erb

@@ -7,5 +7,5 @@
 <% end %>
 <td class="numeric"><%= row_item[:item_on_hand_minimum_quantity] %></td>
 <td class="numeric"><%= row_item[:item_on_hand_recommended_quantity] %></td>
-<td class="numeric"><%= row_item[:quantity] %></td>
+<td class="numeric <%= "text-danger font-weight-bold" if quantity_below_minimum?(row_item) %>" data-column="total"><%= row_item[:quantity] %></td>
 </tr>

docs/user_guide/bank/images/inventory/item_inventory_shortage.png

@@ -152,12 +152,20 @@ This tab shows all the Item inventory across all the storage locations, along wi
 
 ![Navigation to Items, Quantity, and Location](images/inventory/inventory_item_location_navigation.png)
 
+If the total quantity of an item is below the minimum quantity expected, it will be highlighted as shown below:
+
+![Highlighting inventory shortage](images/inventory/item_quantity_location_inventory_shortage.png)
+
 ### Item Inventory tab
 
 This tab shows the bank-wide inventory for each Item.   Clicking the + beside the Item name will show the breakdown of that inventory by storage area.
 
 ![Navigation to Item Inventory tab](images/inventory/inventory_items_inventory_navigation.png)
 
+If the total quantity of an item is below the minimum quantity expected, it will be highlighted as shown below:
+
+![Highlighting inventory shortage](images/inventory/item_inventory_shortage.png)
+
 ### Kits tab
 This shows the same information as the main [Kits](inventory_kits.md) list. 
 ![Navigation to the Kits tab ](images/inventory/inventory_items_kits_navigation.png)

docs/user_guide/bank/images/inventory/item_quantity_location_inventory_shortage.png

@@ -17,6 +17,26 @@
         let(:response_format) { 'html' }
 
         it { is_expected.to be_successful }
+
+        it "highlights total quantity if it is below minimum quantity" do
+          item_pullups = create(:item, name: "the most wonderful magical pullups that truly potty train", category: "Magic Toddlers", on_hand_minimum_quantity: 100)
+          item_tampons = create(:item, name: "blackbeard's rugged tampons", category: "Menstrual Products", on_hand_minimum_quantity: 100)
+          storage_name = "the poop catcher warehouse"
+          num_pullups_in_donation = 666
+          num_pullups_second_donation = 15
+          storage = create(:storage_location, :with_items, item: item_pullups, item_quantity: num_pullups_in_donation, name: storage_name)
+          aux_storage = create(:storage_location, :with_items, item: item_pullups, item_quantity: num_pullups_second_donation, name: "a secret secondary location")
+          num_tampons_in_donation = 42
+          num_tampons_second_donation = 17
+          create(:donation, :with_items, storage_location: storage, item_quantity: num_tampons_in_donation, item: item_tampons)
+          create(:donation, :with_items, storage_location: aux_storage, item_quantity: num_tampons_second_donation, item: item_tampons)
+
+          get items_path(format: response_format)
+          # Inside Item Inventory Tab
+          expect(response.body).to match(/<div[^>]*id="custom-tabs-three-inventory"[^>]*>.*<td class="numeric text-danger font-weight-bold" data-column="total">59<\/td>.*<\/div>/m)
+          # Inside Items, Quantity and Location Tab
+          expect(response.body).to match(/<div[^>]*id="custom-tabs-three-profile"[^>]*>.*<td class="numeric text-danger font-weight-bold" data-column="total">59<\/td>.*<\/div>/m)
+        end
       end
 
       context "csv" do