Transfer model uses new ExportTransfertsCSVService instead of Exportable module

Author: jp524

app/controllers/transfers_controller.rb

@@ -15,7 +15,7 @@ def index
     @to_storage_locations = StorageLocation.with_transfers_to(current_organization)
     respond_to do |format|
       format.html
-      format.csv { send_data Transfer.generate_csv(@transfers), filename: "Transfers-#{Time.zone.today}.csv" }
+      format.csv { send_data Exports::ExportTransfersCSVService.new(transfers: @transfers, organization: current_organization).generate_csv, filename: "Transfers-#{Time.zone.today}.csv" }
     end
   end
 

app/models/transfer.rb

@@ -19,7 +19,6 @@ class Transfer < ApplicationRecord
 
   include Itemizable
   include Filterable
-  include Exportable
   # to make it play nice with Itemizable - alias of `from`
   belongs_to :storage_location, class_name: "StorageLocation", inverse_of: :transfers_from, foreign_key: :from_id
   scope :from_location, ->(location_id) { where(from_id: location_id) }
@@ -31,19 +30,6 @@ class Transfer < ApplicationRecord
   validate :from_storage_quantities
   validate :line_items_quantity_is_positive
 
-  def self.csv_export_headers
-    ["From", "To", "Comment", "Total Moved"]
-  end
-
-  def csv_export_attributes
-    [
-      from.name,
-      to.name,
-      comment || "none",
-      line_items.total
-    ]
-  end
-
   private
 
   def storage_locations_belong_to_organization

app/services/exports/export_transfers_csv_service.rb

@@ -0,0 +1,58 @@
+module Exports
+  class ExportTransfersCSVService
+    def initialize(transfers:, organization:)
+      @transfers = transfers
+      @organization = organization
+    end
+
+    def generate_csv
+      csv_data = generate_csv_data
+
+      CSV.generate(headers: true) do |csv|
+        csv_data.each { |row| csv << row }
+      end
+    end
+
+    def generate_csv_data
+      csv_data = []
+
+      csv_data << headers
+      @transfers.each do |transfer|
+        csv_data << build_row_data(transfer)
+      end
+
+      csv_data
+    end
+
+    private
+
+    def headers
+      base_headers
+    end
+
+    def base_table
+      {
+        "From" => ->(transfer) {
+          transfer.from.name
+        },
+        "To" => ->(transfer) {
+          transfer.to.name
+        },
+        "Comment" => ->(transfer) {
+          transfer.comment || "none"
+        },
+        "Total Moved" => ->(transfer) {
+          transfer.line_items.total
+        }
+      }
+    end
+
+    def base_headers
+      base_table.keys
+    end
+
+    def build_row_data(transfer)
+      base_table.values.map { |closure| closure.call(transfer) }
+    end
+  end
+end