Skip to content

Commit a62eac9

Browse files
authored
Merge pull request #5014 from someykoku/4984-request-cancellation-fix
Resolves #4984 Request cancellation - improve wording and fix button styling
2 parents 08b2175 + 33074e3 commit a62eac9

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

app/views/requests/cancelation/new.html.erb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
<div class="container-fluid">
33
<div class="row mb-2">
44
<div class="col-sm-6">
5-
<% content_for :title, "Do you want to cancel request #{@request.id}?" %>
5+
<% content_for :title, "Do you want to cancel request #{@request.partner.name}?" %>
66
<span class='text-red-600 text-4xl'>
7-
Do you want to cancel request #<%= @request.id %>?
7+
Do you want to cancel the request made for <%= @request.partner.name %> by <%= @request.requester.email %> on <%= @request.created_at.to_fs(:distribution_date) %>, with comment: <%= @request.comments %>?
88
</span>
99
</div>
1010
<div class="col-sm-6">
@@ -35,7 +35,7 @@
3535
</div>
3636

3737
<div class='flex flex-row justify-end'>
38-
<%= f.submit 'Yes. Cancel Request', class: 'bg-red-500 hover:bg-red-700 text-white font-bold py-2 px-4 rounded mt-2' %>
38+
<%= f.submit 'Yes. Cancel Request', class: 'btn btn-primary' %>
3939
</div>
4040
<% end %>
4141
</div>

spec/system/request_system_spec.rb

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,15 @@
262262
expect(request.reload.discarded_at).not_to eq(nil)
263263
expect(request.reload.discard_reason).to eq(reason)
264264
end
265+
266+
it 'should show the partners name, requesters email, request date, comments' do
267+
click_on 'Cancel'
268+
269+
expect(page).to have_content request.partner.name
270+
expect(page).to have_content request.partner.email
271+
expect(page).to have_content("January 1 2020")
272+
expect(page).to have_content request.comments
273+
end
265274
end
266275
end
267276
end

0 commit comments

Comments
 (0)