Fix scanning new barcode item issue (#4592) (#4731)

Author: coalest

app/views/barcode_items/create.js.erb

@@ -12,10 +12,7 @@ $('#trigger-field-id').val('');
 // Notify the user
 toastr.success("Barcode Added to Inventory");
 
-// Locate the row where the barcode was entered from
-line_item = $('#' + source_field).closest('.nested-fields');
-// Set the values in the form. This is replicating some logic from barcode_items.js.erb
-$(line_item).find('[data-quantity]').val(quantity);
-$(line_item).find('[value="' + item_id + '"]').attr("selected", true);
-$('#__add_line_item').trigger('click');
-$("input.__barcode_item_lookup").last().focus();
+// Trigger the capture_entry/barcode_item_lookup functions with a return keypress
+// which fills in the item name and quantity, adds new item, and changes focus
+return_keypress = $.Event( "keypress", { which: 13 } )
+$("input.__barcode_item_lookup").last().trigger(return_keypress);

spec/system/donation_system_spec.rb

@@ -490,6 +490,7 @@
             click_on "Save"
           end
 
+          # form updates
           within "#donation_line_items" do
             barcode_field = page.find(:xpath, "//input[@id='_barcode-lookup-0']").value
             expect(barcode_field).to eq(new_barcode)
@@ -498,7 +499,12 @@
             item_field = page.find(:xpath, "//select[@id='donation_line_items_attributes_0_item_id']").value
             expect(item_field).to eq(Item.first.id.to_s)
           end
-          # form updates
+
+          # new line item was added and has focus
+          within "#donation_line_items" do
+            expect(page).to have_xpath("//input[@id='_barcode-lookup-1']")
+            expect(page).to have_css('#_barcode-lookup-1', focused: true)
+          end
         end
 
         context "When the barcode is a global barcode" do