Fix/5170 reports update issued_at from created_at (#5172)

* fix: distribution report should use issued_at date

* fix: donation report should use issued_at date

* fix: purchase report should use issued_at date

* chore: replace system test with request test

* fix: rubocop issues

Author: zanetagebka

app/views/reports/_distribution.html.erb

@@ -6,5 +6,5 @@
   <% end %>
 </div>
 <div class="pull-right">
-  <%= distance_of_time_in_words_to_now distribution.created_at %> ago
+  <%= distance_of_time_in_words_to_now distribution.issued_at %> ago
 </div>

app/views/reports/_donation.html.erb

@@ -5,5 +5,5 @@
   <% end %>
 </div>
 <div class="pull-right">
-  <%= distance_of_time_in_words_to_now donation.created_at %> ago
+  <%= distance_of_time_in_words_to_now donation.issued_at %> ago
 </div>

app/views/reports/_purchase.html.erb

@@ -5,5 +5,5 @@
   <% end %>
 </div>
 <div class="pull-right">
-  <%= distance_of_time_in_words_to_now purchase.created_at %> ago
+  <%= distance_of_time_in_words_to_now purchase.issued_at %> ago
 </div>

spec/requests/reports/distributions_summary_requests_spec.rb

@@ -11,6 +11,18 @@
       sign_in(user)
     end
 
+    describe "time display" do
+      let!(:distribution) { create(:distribution, :with_items, issued_at: 2.days.ago) }
+
+      before do
+        get reports_distributions_summary_path
+      end
+
+      it "uses issued_at for the relative time display, not created_at" do
+        expect(response.body).to include("2 days ago")
+      end
+    end
+
     context "the index page" do
       context "without filters" do
         before do

spec/requests/reports/donations_summary_spec.rb

@@ -7,6 +7,18 @@
       sign_in user
     end
 
+    describe "time display" do
+      let!(:donation) { create(:donation, :with_items, issued_at: 1.day.ago) }
+
+      before do
+        get reports_donations_summary_path
+      end
+
+      it "uses issued_at for the relative time display, not created_at" do
+        expect(response.body).to include("1 day ago")
+      end
+    end
+
     describe "GET #index" do
       subject do
         get reports_donations_summary_path(format: response_format)

spec/requests/reports/purchases_summary_requests_spec.rb

@@ -7,6 +7,18 @@
       sign_in(user)
     end
 
+    describe "time display" do
+      let!(:purchase) { create(:purchase, :with_items, issued_at: 3.days.ago) }
+
+      before do
+        get reports_purchases_summary_path
+      end
+
+      it "uses issued_at for the relative time display, not created_at" do
+        expect(response.body).to include("3 days ago")
+      end
+    end
+
     describe "GET #index" do
       it "shows a list of recent purchases" do
         get reports_purchases_summary_path