Merge branch 'main' into 3689-check-double-clicks-on-submit

Author: Benjamin-Couey

.github/workflows/ruby_lint.yml

@@ -27,4 +27,4 @@ jobs:
       - name: lint
         run: bundle exec rubocop
       - name: lint erb files
-        run: bundle exec erblint --lint-all
+        run: bundle exec erb_lint --lint-all

Gemfile

@@ -108,6 +108,7 @@ gem 'bootsnap', require: false
 gem "nokogiri", ">= 1.10.4"
 gem "sprockets", "~> 4.2.2"
 gem "prawn", "~> 2.4.0"
+gem "matrix" # Used by prawn
 gem "ttfunk", "~>1.7.0"
 
 group :production, :staging do
@@ -155,7 +156,7 @@ group :development, :test do
   # More concise test ("should") matchers
   gem "shoulda-matchers", "~> 6.5"
   # Default rules for Rubocop.
-  gem "standard", "~> 1.40"
+  gem "standard", "~> 1.50"
   gem "standard-rails"
   gem "standard-performance"
   # Erb linter.

Gemfile.lock

@@ -76,27 +76,30 @@ GEM
     addressable (2.8.7)
       public_suffix (>= 2.0.2, < 7.0)
     afm (0.2.2)
-    annotaterb (4.14.0)
+    annotaterb (4.16.0)
+      activerecord (>= 6.0.0)
+      activesupport (>= 6.0.0)
     ast (2.4.3)
     autoprefixer-rails (10.4.13.0)
       execjs (~> 2)
     awesome_print (1.9.2)
-    aws-eventstream (1.3.1)
-    aws-partitions (1.1050.0)
-    aws-sdk-core (3.218.1)
+    aws-eventstream (1.4.0)
+    aws-partitions (1.1123.0)
+    aws-sdk-core (3.226.1)
       aws-eventstream (~> 1, >= 1.3.0)
       aws-partitions (~> 1, >= 1.992.0)
       aws-sigv4 (~> 1.9)
       base64
       jmespath (~> 1, >= 1.6.1)
-    aws-sdk-kms (1.98.0)
-      aws-sdk-core (~> 3, >= 3.216.0)
+      logger
+    aws-sdk-kms (1.106.0)
+      aws-sdk-core (~> 3, >= 3.225.0)
       aws-sigv4 (~> 1.5)
-    aws-sdk-s3 (1.181.0)
-      aws-sdk-core (~> 3, >= 3.216.0)
+    aws-sdk-s3 (1.191.0)
+      aws-sdk-core (~> 3, >= 3.225.0)
       aws-sdk-kms (~> 1)
       aws-sigv4 (~> 1.5)
-    aws-sigv4 (1.11.0)
+    aws-sigv4 (1.12.1)
       aws-eventstream (~> 1, >= 1.0.2)
     azure-storage-blob (2.0.3)
       azure-storage-common (~> 2.0)
@@ -120,7 +123,7 @@ GEM
       erubi (~> 1.4)
       parser (>= 2.4)
       smart_properties
-    bigdecimal (3.2.1)
+    bigdecimal (3.2.2)
     bindex (0.8.1)
     binding_of_caller (1.0.1)
       debug_inspector (>= 1.2.0)
@@ -135,7 +138,7 @@ GEM
     bugsnag (6.27.1)
       concurrent-ruby (~> 1.0)
     builder (3.3.0)
-    bullet (8.0.5)
+    bullet (8.0.8)
       activesupport (>= 3.0.0)
       uniform_notifier (~> 1.11)
     capybara (3.40.0)
@@ -235,11 +238,11 @@ GEM
       smart_properties
     erubi (1.13.1)
     execjs (2.10.0)
-    factory_bot (6.5.0)
-      activesupport (>= 5.0.0)
-    factory_bot_rails (6.4.4)
+    factory_bot (6.5.4)
+      activesupport (>= 6.1.0)
+    factory_bot_rails (6.5.0)
       factory_bot (~> 6.5)
-      railties (>= 5.0.0)
+      railties (>= 6.1.0)
     faker (3.5.1)
       i18n (>= 1.8.11, < 2)
     faraday (1.10.4)
@@ -277,11 +280,11 @@ GEM
     ffi (1.17.2-x86_64-darwin)
     ffi (1.17.2-x86_64-linux-gnu)
     filterrific (5.2.7)
-    flipper (1.3.4)
+    flipper (1.3.5)
       concurrent-ruby (< 2)
-    flipper-active_record (1.3.4)
+    flipper-active_record (1.3.5)
       activerecord (>= 4.2, < 9)
-      flipper (~> 1.3.4)
+      flipper (~> 1.3.5)
     flipper-ui (1.3.4)
       erubi (>= 1.0.0, < 2.0.0)
       flipper (~> 1.3.4)
@@ -333,8 +336,8 @@ GEM
       actionview (>= 5.0.0)
       activesupport (>= 5.0.0)
     jmespath (1.6.2)
-    json (2.11.3)
-    jwt (2.10.1)
+    json (2.12.2)
+    jwt (3.1.2)
       base64
     kaminari (1.2.2)
       activesupport (>= 4.1.0)
@@ -350,7 +353,7 @@ GEM
     kaminari-core (1.2.2)
     knapsack_pro (8.3.0)
       rake
-    language_server-protocol (3.17.0.4)
+    language_server-protocol (3.17.0.5)
     launchy (3.0.0)
       addressable (~> 2.8)
       childprocess (~> 5.0)
@@ -509,8 +512,8 @@ GEM
     puma (6.6.0)
       nio4r (~> 2.0)
     racc (1.8.1)
-    rack (3.1.15)
-    rack-mini-profiler (3.3.1)
+    rack (3.1.16)
+    rack-mini-profiler (4.0.0)
       rack (>= 1.2.0)
     rack-protection (4.1.1)
       base64 (>= 0.1.0)
@@ -566,7 +569,7 @@ GEM
     rb-fsevent (0.11.2)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
-    rdoc (6.14.0)
+    rdoc (6.14.1)
       erb
       psych (>= 4.0.0)
     recaptcha (5.19.0)
@@ -602,7 +605,7 @@ GEM
       rspec-mocks (~> 3.13)
       rspec-support (~> 3.13)
     rspec-support (3.13.4)
-    rubocop (1.75.4)
+    rubocop (1.75.8)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -613,7 +616,7 @@ GEM
       rubocop-ast (>= 1.44.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.44.1)
+    rubocop-ast (1.45.1)
       parser (>= 3.3.7.2)
       prism (~> 1.4)
     rubocop-performance (1.25.0)
@@ -681,10 +684,10 @@ GEM
       activesupport (>= 5.2)
       sprockets (>= 3.0.0)
     stackprof (0.2.27)
-    standard (1.49.0)
+    standard (1.50.0)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.0)
-      rubocop (~> 1.75.2)
+      rubocop (~> 1.75.5)
       standard-custom (~> 1.0.0)
       standard-performance (~> 1.8)
     standard-custom (1.0.2)
@@ -707,15 +710,15 @@ GEM
     tilt (2.2.0)
     timeout (0.4.3)
     ttfunk (1.7.0)
-    turbo-rails (2.0.13)
+    turbo-rails (2.0.16)
       actionpack (>= 7.1.0)
       railties (>= 7.1.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (3.1.4)
       unicode-emoji (~> 4.0, >= 4.0.4)
     unicode-emoji (4.0.4)
-    uniform_notifier (1.16.0)
+    uniform_notifier (1.17.0)
     uri (1.0.3)
     useragent (0.16.11)
     version_gem (1.1.8)
@@ -792,6 +795,7 @@ DEPENDENCIES
   listen (~> 3.9.0)
   lograge
   magic_test
+  matrix
   memory_profiler
   money-rails
   newrelic_rpm
@@ -827,7 +831,7 @@ DEPENDENCIES
   solid_cache (~> 1.0)
   sprockets (~> 4.2.2)
   stackprof
-  standard (~> 1.40)
+  standard (~> 1.50)
   standard-performance
   standard-rails
   stimulus-rails

app/controllers/item_categories_controller.rb

@@ -33,6 +33,17 @@ def update
     end
   end
 
+  def destroy
+    @item_category = current_organization.item_categories.find_by(id: params[:id])
+    if @item_category.items.exists?
+      flash[:alert] = "Cannot delete item category because it has associated items."
+    else
+      @item_category.destroy
+      flash[:notice] = "#{@item_category.name} has been deleted."
+    end
+    redirect_to items_path
+  end
+
   private
 
   def item_category_params

app/javascript/utils/donations.js

@@ -108,13 +108,14 @@ $(function() {
   )
 
   const large_donation_boundary = 100000;
-  $(document).on("submit", "form#new_donation", (e, _) =>
+  $(document).on("click", "form#new_donation button[type='submit']", (e, _) =>
     $(".quantity").each(function(_, q) {
       const quantity = parseInt(q.value, 10);
       if (quantity > large_donation_boundary) {
-        confirm(
+        const answer_confirm = confirm(
           `${quantity} items is a large donation! Are you sure you want to submit?`
-        );
+        )
+        answer_confirm === false && e.preventDefault();
       }
     })
   );

app/models/item.rb

@@ -6,7 +6,6 @@
 #  active                       :boolean          default(TRUE)
 #  additional_info              :text
 #  barcode_count                :integer
-#  category                     :string
 #  distribution_quantity        :integer
 #  name                         :string
 #  on_hand_minimum_quantity     :integer          default(0), not null

app/models/item_category.rb

@@ -16,5 +16,16 @@ class ItemCategory < ApplicationRecord
 
   belongs_to :organization
   has_many :items, -> { order(name: :asc) }, inverse_of: :item_category, dependent: :nullify
-  has_many :partner_groups, dependent: :nullify
+  has_and_belongs_to_many :partner_groups, dependent: :nullify
+
+  before_destroy :ensure_no_associated_partner_groups
+
+  private
+
+  def ensure_no_associated_partner_groups
+    if partner_groups.exists?
+      errors.add(:base, "Cannot delete item category with associated partner groups")
+      throw(:abort)
+    end
+  end
 end

app/models/partner.rb

@@ -146,7 +146,7 @@ def families_served_count
   end
 
   def children_served_count
-    children.count
+    children.count { |child| !child.archived? }
   end
 
   def family_zipcodes_count

app/pdfs/distribution_pdf.rb

@@ -88,6 +88,11 @@ def compute_and_render
         font_size 10
       end
 
+      move_down 10
+      text "Distribution ID:", style: :bold
+      font_size 12
+      text @distribution.id.to_s
+
       move_down 10
       text "Comments:", style: :bold
       font_size 12

app/pdfs/picklists_pdf.rb

@@ -76,6 +76,16 @@ def compute_and_render
           font_size 10
         end
 
+        # Add quota information only if quota is set and greater than 0
+        quota = request.partner.quota
+        if quota && quota > 0
+          move_down 5
+          text "Quota:", style: :bold, align: :right
+          font_size 12
+          text quota.to_s, align: :right
+          font_size 10
+        end
+
         move_down 10
         text "Comments:", style: :bold
         font_size 12