Implemented ItemizedRequestBreakdownService using class-level methods

Author: seabeeberry

app/controllers/reports_controller.rb

@@ -41,7 +41,7 @@ def activity_graph
 
   def itemized_requests
     requests = current_organization.requests.during(helpers.selected_range)
-    @itemized_request_data = RequestItemizedBreakdownService.new(organization: current_organization, request_ids: requests.pluck(:id)).fetch
+    @itemized_request_data = RequestItemizedBreakdownService.call(organization: current_organization, request_ids: requests.pluck(:id))
   end
 
   private

app/services/request_itemized_breakdown_service.rb

@@ -1,91 +1,70 @@
 class RequestItemizedBreakdownService
-  #
-  # Initializes the RequestItemizedBreakdownService whose
-  # purpose is to construct an itemized breakdown of requested items
-  #
-  # @param organization [Organization]
-  # @param request_ids [Array<Integer>]
-  # @return [RequestItemizedBreakdownService]
-  def initialize(organization:, request_ids:)
-    @organization = organization
-    @request_ids = request_ids
-  end
+  class << self
+    def call(organization:, request_ids:, format: :hash)
+      data = fetch(organization: organization, request_ids: request_ids)
+      (format == :csv) ? convert_to_csv(data) : data
+    end
 
-  #
-  # Returns a hash containing the itemized breakdown of
-  # requested items.
-  #
-  # @return [Array]
-  def fetch
-    inventory = View::Inventory.new(@organization.id)
-    current_onhand = current_onhand_quantities(inventory)
-    current_min_onhand = current_onhand_minimums(inventory)
-    items_requested = fetch_items_requested
+    def fetch(organization:, request_ids:)
+      inventory = View::Inventory.new(organization.id)
+      current_onhand = current_onhand_quantities(inventory)
+      current_min_onhand = current_onhand_minimums(inventory)
+      items_requested = fetch_items_requested(organization: organization, request_ids: request_ids)
 
-    items_requested.each do |item|
-      name = item[:name]
+      items_requested.each do |item|
+        name = item[:name]
 
-      on_hand = current_onhand[name]
-      minimum = current_min_onhand[name]
-      below_onhand_minimum = on_hand && minimum && on_hand < minimum
+        on_hand = current_onhand[name]
+        minimum = current_min_onhand[name]
+        below_onhand_minimum = on_hand && minimum && on_hand < minimum
 
-      item.merge!(
-        on_hand: on_hand,
-        onhand_minimum: minimum,
-        below_onhand_minimum: below_onhand_minimum
-      )
-    end
-
-    items_requested.sort_by { |item| [item[:name], item[:unit].to_s] }
-  end
+        item.merge!(
+          on_hand: on_hand,
+          onhand_minimum: minimum,
+          below_onhand_minimum: below_onhand_minimum
+        )
+      end
 
-  #
-  # Returns a CSV string representation of the itemized breakdown of
-  # what was requested
-  #
-  # @return [String]
-  def fetch_csv
-    convert_to_csv(fetch)
-  end
+      items_requested.sort_by { |item| [item[:name], item[:unit].to_s] }
+    end
 
-  private
+    def csv(organization:, request_ids:)
+      convert_to_csv(fetch(organization: organization, request_ids: request_ids))
+    end
 
-  attr_reader :organization, :request_ids
+    private
 
-  def current_onhand_quantities(inventory)
-    inventory.all_items.group_by(&:name).to_h { |k, v| [k, v.sum { |r| r.quantity.to_i }] }
-  end
+    def current_onhand_quantities(inventory)
+      inventory.all_items.group_by(&:name).to_h { |k, v| [k, v.sum { |r| r.quantity.to_i }] }
+    end
 
-  def current_onhand_minimums(inventory)
-    inventory.all_items.group_by(&:name).to_h { |k, v| [k, v.map(&:on_hand_minimum_quantity).compact.max] }
-  end
+    def current_onhand_minimums(inventory)
+      inventory.all_items.group_by(&:name).to_h { |k, v| [k, v.map(&:on_hand_minimum_quantity).compact.max] }
+    end
 
-  def fetch_items_requested
-    Partners::ItemRequest
-      .includes(:item)
-      .where(partner_request_id: @request_ids)
-      .group_by { |ir| [ir.item_id, ir.request_unit] }
-      .map do |(item_id, unit), grouped|
-        item = grouped.first.item
-        {
-          item_id: item.id,
-          name: item.name,
-          unit: unit,
-          quantity: grouped.sum { |ri| ri.quantity.to_i }
-        }
-      end
-  end
+    def fetch_items_requested(organization:, request_ids:)
+      Partners::ItemRequest
+        .includes(:item)
+        .where(partner_request_id: request_ids)
+        .group_by { |ir| [ir.item_id, ir.request_unit] }
+        .map do |(item_id, unit), grouped|
+          item = grouped.first.item
+          {
+            item_id: item.id,
+            name: item.name,
+            unit: unit,
+            quantity: grouped.sum { |ri| ri.quantity.to_i }
+          }
+        end
+    end
 
-  def convert_to_csv(items_requested_data)
-    CSV.generate do |csv|
-      csv << ["Item", "Total Requested", "Total On Hand"]
-      items_requested_data.each do |item|
-        csv << [item[:name], item[:quantity], item[:on_hand]]
+    def convert_to_csv(items_requested_data)
+      CSV.generate do |csv|
+        csv << ["Item", "Total Requested", "Total On Hand"]
+        items_requested_data.each do |item|
+          csv << [item[:name], item[:quantity], item[:on_hand]]
+        end
       end
     end
   end
-
-  def inventory
-    @inventory ||= View::Inventory.new(@organization.id)
-  end
 end

spec/services/request_itemized_breakdown_service_spec.rb

@@ -22,8 +22,9 @@
   end
 
   describe "#fetch" do
-    subject(:result) { service.fetch }
-    let(:service) { described_class.new(organization: organization, request_ids: [request_1.id, request_2.id]) }
+    subject(:result) do
+      described_class.call(organization: organization, request_ids: [request_1.id, request_2.id])
+    end
 
     it "should include the break down of requested items" do
       expected_output = [
@@ -35,8 +36,9 @@
   end
 
   describe "#fetch_csv" do
-    subject(:subject) { service.fetch_csv }
-    let(:service) { described_class.new(organization: organization, request_ids: [request_1.id, request_2.id]) }
+    subject(:subject) do
+      described_class.call(organization: organization, request_ids: [request_1.id, request_2.id], format: :csv)
+    end
 
     it "should output the expected output but in CSV format" do
       expected_csv = <<~CSV