Fix lint failures

Author: dorner

app/models/organization.rb

@@ -167,8 +167,8 @@ def ordered_requests
 
   # Computes full address string based on street, city, state, and zip, adding ', ' and ' ' separators
   def address
-    state_and_zip = [state, zipcode].select(&:present?).join(' ')
-    [street, city, state_and_zip].select(&:present?).join(', ')
+    state_and_zip = [state, zipcode].compact_blank.join(' ')
+    [street, city, state_and_zip].compact_blank.join(', ')
   end
 
   def address_changed?
@@ -298,6 +298,6 @@ def get_admin_email
   end
 
   def logo_size_check
-    errors.add(:logo, 'File size is greater than 1 MB') if logo.byte_size > 1.megabytes
+    errors.add(:logo, 'File size is greater than 1 MB') if logo.byte_size > 1.megabyte
   end
 end

spec/rails_helper.rb

@@ -31,8 +31,8 @@
 # directory. Alternatively, in the individual `*_spec.rb` files, manually
 # require only the support files necessary.
 #
-Dir[Rails.root.join("spec/support/**/*.rb")].sort.each { |f| require f }
-Dir[Rails.root.join("spec/controllers/shared_examples/*.rb")].sort.each { |f| require f }
+Rails.root.glob("spec/support/**/*.rb").sort.each { |f| require f }
+Rails.root.glob("spec/controllers/shared_examples/*.rb").sort.each { |f| require f }
 
 # Checks for pending migration and applies them before tests are run.
 # If you are not using ActiveRecord, you can remove this line.

spec/system/storage_location_system_spec.rb

@@ -185,8 +185,8 @@
       create(:storage_location, :with_items, item: item3, item_quantity: 10, name: "Baz")
       visit subject
 
-      expect(page.all('select[name="filters[containing]"] option').map(&:text).select(&:present?)).to eq(expected_order)
-      expect(page.all('select[name="filters[containing]"] option').map(&:text).select(&:present?)).not_to eq(expected_order.reverse)
+      expect(page.all('select[name="filters[containing]"] option').map(&:text).compact_blank).to eq(expected_order)
+      expect(page.all('select[name="filters[containing]"] option').map(&:text).compact_blank).not_to eq(expected_order.reverse)
     end
   end