Skip to content

Commit d5f4dce

Browse files
Missed a non-GET link, button without disable_with, and change made by linter
1 parent 2a92e7f commit d5f4dce

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

app/views/layouts/_lte_admin_navbar.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
<div class="dropdown-divider"></div>
1515

16-
<%= link_to destroy_user_session_path, class:"dropdown-item dropdown-footer", method: :delete do %>
16+
<%= button_to destroy_user_session_path, class:"dropdown-item dropdown-footer", method: :delete, data: {disable_with: "Please wait..."} do %>
1717
<i class="fa fa-sign-out mr-2"></i> Log Out
1818
<% end %>
1919
</div>

app/views/users/sessions/new.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,6 @@
5353
</div>
5454
<% end %>
5555

56-
<%= button_to user_google_oauth2_omniauth_authorize_path, method: :post, class: "btn btn-block", form_class: "d-inline-block" do %>
56+
<%= button_to user_google_oauth2_omniauth_authorize_path, method: :post, class: "btn btn-block", form_class: "d-inline-block", data: {disable_with: "Please wait..."} do %>
5757
<img src="../img/[email protected]" alt="Sign in with Google" class="d-block w-100">
5858
<% end %>

spec/system/barcode_item_system_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272

7373
it "can delete a barcode item" do
7474
item = create(:item, name: "Red 1T Diapers", base_item: base_item)
75-
b_item = create(:barcode_item, organization: organization, barcodeable: item, value: "barcode_to_delete")
75+
create(:barcode_item, organization: organization, barcodeable: item, value: "barcode_to_delete")
7676

7777
visit subject
7878
expect(page).to have_content("barcode_to_delete")

0 commit comments

Comments
 (0)