Update standard and rubocop

dorner · dorner · commit dc82968ce360 · 2025-10-10T13:32:02.000-04:00
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -341,7 +341,7 @@ GEM
       actionview (>= 5.0.0)
       activesupport (>= 5.0.0)
     jmespath (1.6.2)
-    json (2.12.2)
+    json (2.15.1)
     jwt (3.1.2)
       base64
     kaminari (1.2.2)
@@ -466,7 +466,7 @@ GEM
       activerecord (>= 6.1)
       request_store (~> 1.4)
     parallel (1.27.0)
-    parser (3.3.8.0)
+    parser (3.3.9.0)
       ast (~> 2.4.1)
       racc
     pdf-core (0.9.0)
@@ -493,7 +493,7 @@ GEM
     prawn-table (0.2.2)
       prawn (>= 1.3.0, < 3.0.0)
     prettyprint (0.2.0)
-    prism (1.4.0)
+    prism (1.5.2)
     pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
@@ -578,7 +578,7 @@ GEM
       erb
       psych (>= 4.0.0)
     recaptcha (5.20.1)
-    regexp_parser (2.11.2)
+    regexp_parser (2.11.3)
     reline (0.6.2)
       io-console (~> 0.5)
     request_store (1.7.0)
@@ -610,18 +610,18 @@ GEM
       rspec-mocks (~> 3.13)
       rspec-support (~> 3.13)
     rspec-support (3.13.4)
-    rubocop (1.75.8)
+    rubocop (1.80.2)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.44.0, < 2.0)
+      rubocop-ast (>= 1.46.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.45.1)
+    rubocop-ast (1.47.1)
       parser (>= 3.3.7.2)
       prism (~> 1.4)
     rubocop-performance (1.25.0)
@@ -689,10 +689,10 @@ GEM
       activesupport (>= 5.2)
       sprockets (>= 3.0.0)
     stackprof (0.2.27)
-    standard (1.50.0)
+    standard (1.51.1)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.0)
-      rubocop (~> 1.75.5)
+      rubocop (~> 1.80.2)
       standard-custom (~> 1.0.0)
       standard-performance (~> 1.8)
     standard-custom (1.0.2)
@@ -720,9 +720,9 @@ GEM
       railties (>= 7.1.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (3.1.4)
-      unicode-emoji (~> 4.0, >= 4.0.4)
-    unicode-emoji (4.0.4)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.1.0)
     uniform_notifier (1.17.0)
     uri (1.0.3)
     useragent (0.16.11)
diff --git a/app/controllers/partners/family_requests_controller.rb b/app/controllers/partners/family_requests_controller.rb
@@ -1,6 +1,7 @@
 module Partners
   class FamilyRequestsController < BaseController
     include Validatable
+
     before_action :verify_partner_is_active
     before_action :authorize_verified_partners
 
diff --git a/app/controllers/partners/individuals_requests_controller.rb b/app/controllers/partners/individuals_requests_controller.rb
@@ -1,6 +1,7 @@
 module Partners
   class IndividualsRequestsController < BaseController
     include Validatable
+
     before_action :verify_partner_is_active
     before_action :authorize_verified_partners
 
diff --git a/app/controllers/partners/requests_controller.rb b/app/controllers/partners/requests_controller.rb
@@ -1,6 +1,7 @@
 module Partners
   class RequestsController < BaseController
     include Validatable
+
     skip_before_action :require_partner, only: [:new, :create, :validate]
     before_action :require_partner_or_org_admin, only: [:new, :create, :validate]
     layout :layout
diff --git a/app/controllers/partners_controller.rb b/app/controllers/partners_controller.rb
@@ -3,6 +3,7 @@
 # of which Partners are associated with which Diaperbanks.
 class PartnersController < ApplicationController
   include Importable
+
   before_action :validate_user_role, only: :show
   skip_before_action :require_organization, only: :show
 
diff --git a/app/controllers/product_drives_controller.rb b/app/controllers/product_drives_controller.rb
@@ -1,5 +1,6 @@
 class ProductDrivesController < ApplicationController
   include Importable
+
   before_action :set_product_drive, only: [:show, :edit, :update, :destroy]
   before_action :set_tags, only: [:index, :new, :edit]
 
diff --git a/app/helpers/distribution_helper.rb b/app/helpers/distribution_helper.rb
@@ -1,6 +1,7 @@
 # Encapsulates methods that need some business logic
 module DistributionHelper
   include ActionView::Helpers::NumberHelper
+
   def pickup_day_params
     return {} unless params.key?(:filters)
 
diff --git a/app/models/adjustment.rb b/app/models/adjustment.rb
@@ -20,6 +20,7 @@ class Adjustment < ApplicationRecord
   include Exportable
   include Itemizable
   include Filterable
+
   scope :at_location, ->(location_id) { where(storage_location_id: location_id) }
   scope :by_user, ->(user_id) { where(user_id: user_id) }
   scope :during, ->(range) { where(adjustments: { created_at: range }) }
diff --git a/app/models/audit.rb b/app/models/audit.rb
@@ -21,6 +21,7 @@ class Audit < ApplicationRecord
 
   include Itemizable
   include Filterable
+
   scope :at_location, ->(location_id) { where(storage_location_id: location_id) }
 
   accepts_nested_attributes_for :adjustment
diff --git a/app/models/barcode_item.rb b/app/models/barcode_item.rb
@@ -25,6 +25,7 @@ class BarcodeItem < ApplicationRecord
 
   include Filterable
   include Exportable
+
   default_scope { order("barcodeable_type DESC, created_at ASC") }
 
   scope :barcodeable_id, ->(barcodeable_id) { where(barcodeable_id: barcodeable_id) }
diff --git a/app/models/concerns/filterable.rb b/app/models/concerns/filterable.rb
@@ -1,6 +1,7 @@
 # H/T to http://www.justinweiss.com/articles/search-and-filter-rails-models-without-bloating-your-controller/
 module Filterable
   extend ActiveSupport::Concern
+
   # This is the core logic behind all of the #index filters. It allows a model
   # to accept a hash of parameters to filter on, where the keys are scopes and the
   # values are arguments.
diff --git a/app/models/concerns/geocodable.rb b/app/models/concerns/geocodable.rb
@@ -1,6 +1,7 @@
 # Extracts geocoding logic.
 module Geocodable
   extend ActiveSupport::Concern
+
   included do
     geocoded_by :address
     after_validation :geocode, if: ->(obj) { obj.address.present? && obj.address_changed? && !Rails.env.development? }
diff --git a/app/models/event.rb b/app/models/event.rb
@@ -16,6 +16,7 @@
 #
 class Event < ApplicationRecord
   include Filterable
+
   scope :for_organization, ->(organization_id) { where(organization_id: organization_id).order(:event_time, :updated_at) }
   scope :without_snapshots, -> { where("type != 'SnapshotEvent'") }
   scope :during, ->(range) { where(events: {created_at: range}) }
diff --git a/app/models/line_item.rb b/app/models/line_item.rb
@@ -14,6 +14,7 @@
 class LineItem < ApplicationRecord
   has_paper_trail
   include ItemQuantity
+
   MAX_INT = 2**31
   MIN_INT = -2**31
 
diff --git a/app/models/partner.rb b/app/models/partner.rb
@@ -63,6 +63,7 @@ class Partner < ApplicationRecord
 
   include Filterable
   include Exportable
+
   scope :by_status, ->(status) {
     where(status: status.to_sym)
   }
diff --git a/app/models/request.rb b/app/models/request.rb
@@ -41,6 +41,7 @@ class Request < ApplicationRecord
   after_validation :sanitize_items_data
 
   include Filterable
+
   # add request item scope to allow filtering distributions by request item
   scope :by_request_item_id, ->(item_id) { where("request_items @> :with_item_id ", with_item_id: [{ item_id: item_id.to_i }].to_json) }
   # partner scope to allow filtering by partner
diff --git a/app/models/transfer.rb b/app/models/transfer.rb
@@ -19,6 +19,7 @@ class Transfer < ApplicationRecord
 
   include Itemizable
   include Filterable
+
   # to make it play nice with Itemizable - alias of `from`
   belongs_to :storage_location, class_name: "StorageLocation", inverse_of: :transfers_from, foreign_key: :from_id
   scope :from_location, ->(location_id) { where(from_id: location_id) }
diff --git a/app/services/adjustment_create_service.rb b/app/services/adjustment_create_service.rb
@@ -2,6 +2,7 @@
 
 class AdjustmentCreateService
   include ServiceObjectErrorsMixin
+
   attr_reader :adjustment
 
   def initialize(adjustment_or_params)
diff --git a/app/services/exports/export_product_drives_csv_service.rb b/app/services/exports/export_product_drives_csv_service.rb
@@ -1,6 +1,7 @@
 module Exports
   class ExportProductDrivesCSVService
     include ItemsHelper
+
     HEADERS = ["Product Drive Name", "Start Date", "End Date", "Held Virtually?", "Quantity of Items",
       "Variety of Items", "In Kind Value"].freeze
 
diff --git a/app/services/partner_profile_update_service.rb b/app/services/partner_profile_update_service.rb
@@ -1,5 +1,6 @@
 class PartnerProfileUpdateService
   include ServiceObjectErrorsMixin
+
   attr_reader :error
   def initialize(old_partner, new_partner_params, new_profile_params)
     @partner = old_partner
diff --git a/app/services/partners/update_family.rb b/app/services/partners/update_family.rb
@@ -3,6 +3,7 @@
 module Partners
   module UpdateFamily
     extend ServiceObjectErrorsMixin
+
     # rubocop:disable Rails/SkipsModelValidations
     def self.archive(family)
       if family.children.exists?
diff --git a/app/services/reports/adult_incontinence_report_service.rb b/app/services/reports/adult_incontinence_report_service.rb
@@ -1,6 +1,7 @@
 module Reports
   class AdultIncontinenceReportService
     include ActionView::Helpers::NumberHelper
+
     attr_reader :year, :organization
 
     # @param year [Integer]
diff --git a/app/services/reports/children_served_report_service.rb b/app/services/reports/children_served_report_service.rb
@@ -1,6 +1,7 @@
 module Reports
   class ChildrenServedReportService
     include ActionView::Helpers::NumberHelper
+
     attr_reader :year, :organization
 
     # @param year [Integer]
diff --git a/app/services/reports/diaper_report_service.rb b/app/services/reports/diaper_report_service.rb
@@ -1,6 +1,7 @@
 module Reports
   class DiaperReportService
     include ActionView::Helpers::NumberHelper
+
     attr_reader :year, :organization
 
     # @param year [Integer]
diff --git a/app/services/reports/other_products_report_service.rb b/app/services/reports/other_products_report_service.rb
@@ -1,6 +1,7 @@
 module Reports
   class OtherProductsReportService
     include ActionView::Helpers::NumberHelper
+
     attr_reader :year, :organization
 
     # @param year [Integer]
diff --git a/app/services/reports/partner_info_report_service.rb b/app/services/reports/partner_info_report_service.rb
@@ -1,6 +1,7 @@
 module Reports
   class PartnerInfoReportService
     include ActionView::Helpers::NumberHelper
+
     attr_reader :year, :organization
 
     # @param year [Integer]
diff --git a/app/services/reports/period_supply_report_service.rb b/app/services/reports/period_supply_report_service.rb
@@ -1,6 +1,7 @@
 module Reports
   class PeriodSupplyReportService
     include ActionView::Helpers::NumberHelper
+
     attr_reader :year, :organization
 
     # @param year [Integer]
diff --git a/app/services/reports/summary_report_service.rb b/app/services/reports/summary_report_service.rb
@@ -1,6 +1,7 @@
 module Reports
   class SummaryReportService
     include ActionView::Helpers::NumberHelper
+
     attr_reader :year, :organization
 
     # @param year [Integer]
diff --git a/spec/helpers/date_range_helper_spec.rb b/spec/helpers/date_range_helper_spec.rb
@@ -4,6 +4,7 @@
   let(:dummy_class) do
     Class.new do
       include DateRangeHelper
+
       attr_accessor :params, :flash
 
       def initialize(params = {}, flash = nil)
