Remove param organization_name where it's not needed

Remnant from #4331

Author: jp524

app/views/partners/_statuses.html.erb

@@ -11,7 +11,7 @@
     partner_count = status_counts[status] || 0 %>
   <li>
     <%= fa_icon icon_mapping[status] || '', class: "bg-partner-#{status}  " %>
-    <%= link_to_unless partner_count.zero?, "#{partner_count} #{status.humanize}", partners_path(organization_name:nil, filters: { by_status: status }), class: ("filtering" if status == current_filtered_status) %>
+    <%= link_to_unless partner_count.zero?, "#{partner_count} #{status.humanize}", partners_path(filters: { by_status: status }), class: ("filtering" if status == current_filtered_status) %>
   </li>
   <% end %>
   <li>

spec/controllers/distributions_controller_spec.rb

@@ -21,7 +21,6 @@
       context "when distribution causes inventory to remain above minimum quantity for an organization" do
         let(:params) do
           {
-            organization_name: organization.id,
             distribution: {
               partner_id: partner.id,
               issued_at: Date.yesterday,
@@ -45,7 +44,6 @@
         context "when distribution causes inventory to fall below minimum quantity for a storage location" do
           let(:params) do
             {
-              organization_name: organization.id,
               distribution: {
                 partner_id: partner.id,
                 storage_location_id: second_storage_location.id,
@@ -70,7 +68,6 @@
         let(:storage_location) { create(:storage_location, :with_items, item: first_item, item_quantity: 20, organization: organization) }
         let(:params) do
           {
-            organization_name: organization.id,
             distribution: {
               partner_id: partner.id,
               storage_location_id: storage_location.id,
@@ -96,7 +93,6 @@
           let(:storage_location) { create(:storage_location, organization: organization) }
           let(:params) do
             {
-              organization_name: organization.id,
               distribution: {
                 partner_id: partner.id,
                 storage_location_id: storage_location.id,
@@ -140,7 +136,6 @@
         end
         let(:params) do
           {
-            organization_name: organization.id,
             distribution: {
               partner_id: partner.id,
               storage_location_id: storage_location.id,
@@ -179,7 +174,6 @@
         end
         let(:params) do
           {
-            organization_name: organization.id,
             distribution: {
               partner_id: partner.id,
               storage_location_id: storage_location.id,
@@ -207,7 +201,6 @@
         let(:storage_location) { create(:storage_location, :with_items, item: item, item_quantity: 2, organization: organization) }
         let(:params) do
           {
-            organization_name: organization.id,
             distribution: {
               partner_id: partner.id,
               storage_location_id: storage_location.id,
@@ -230,7 +223,6 @@
       context "when distribution reminder email is enabled" do
         let(:params) do
           {
-            organization_name: organization.id,
             distribution: {
               partner_id: partner.id,
               issued_at: Date.tomorrow,
@@ -288,7 +280,6 @@
         let(:distribution) { create(:distribution, storage_location: storage_location) }
         let(:params) do
           {
-            organization_name: organization.id,
             id: distribution.id,
             distribution: {
               storage_location_id: distribution.storage_location.id,
@@ -326,7 +317,6 @@
         let(:distribution) { create(:distribution, storage_location: storage_location, organization: organization) }
         let(:params) do
           {
-            organization_name: organization.id,
             id: distribution.id,
             distribution: {
               storage_location_id: distribution.storage_location.id,
@@ -363,7 +353,6 @@
         let(:distribution) { create(:distribution, :with_items, item: item1, storage_location: storage_location, organization: organization) }
         let(:params) do
           {
-            organization_name: organization.id,
             id: distribution.id,
             distribution: {
               storage_location_id: distribution.storage_location.id,
@@ -410,7 +399,6 @@
         let(:distribution) { create(:distribution, :with_items, item: item1, storage_location: storage_location, organization: organization, reminder_email_enabled: false, partner: partner) }
         let(:params) do
           {
-            organization_name: organization.id,
             id: distribution.id,
             distribution: {
               storage_location_id: distribution.storage_location.id,

spec/controllers/help_controller_spec.rb

@@ -2,17 +2,13 @@
   let(:organization) { create(:organization) }
   let(:user) { create(:user, organization: organization) }
 
-  let(:default_params) do
-    { organization_name: organization.to_param }
-  end
-
   context "While signed in as a normal user >" do
     before do
       sign_in(user)
     end
 
     describe "GET #show" do
-      subject { get :show, params: default_params }
+      subject { get :show }
       it "returns http success" do
         expect(subject).to be_successful
       end

spec/requests/admin/organizations_requests_spec.rb

@@ -1,8 +1,5 @@
 RSpec.describe "Admin::Organizations", type: :request do
   let(:organization) { create(:organization) }
-  let(:default_params) do
-    { organization_name: organization.id }
-  end
 
   context "When logged in as a super admin" do
     before do
@@ -110,7 +107,7 @@
     describe "PATCH #update" do
       let(:organization) { create(:organization, name: "Original Name") }
       subject do
-        patch admin_organization_path(default_params.merge(id: organization.id, organization: { name: updated_name }))
+        patch admin_organization_path(id: organization.id, organization: { name: updated_name })
       end
 
       context "with a valid update" do
@@ -128,7 +125,7 @@
         let(:successful) { 200 }
 
         subject do
-          patch admin_organization_path(default_params.merge(id: organization.id, organization: { name: updated_name }))
+          patch admin_organization_path(id: organization.id, organization: { name: updated_name })
         end
 
         it "returns http success" do

spec/requests/dashboard_requests_spec.rb

@@ -26,14 +26,6 @@
           expect(response.body).to include('switch_to_role')
         end
       end
-
-      context "for another org" do
-        it "still displays the user's org" do
-          # another org
-          get dashboard_path(organization_name: create(:organization).to_param)
-          expect(response.body).to include(organization.name)
-        end
-      end
     end
 
     context "BroadcastAnnouncement card" do

spec/requests/storage_locations_requests_spec.rb

@@ -288,7 +288,7 @@
           file = fixture_file_upload("inventory.csv", "text/csv")
 
           params = { file: file, storage_location: storage_location_with_items.id }
-          post import_inventory_storage_locations_path(organization_name: organization.to_param), params: params
+          post import_inventory_storage_locations_path, params: params
 
           expect(response).to be_redirect
           expect(response).to have_error "Could not complete action: inventory already has items stored"