Merge pull request #622 from maebeale/fix-form-when-no-responses

Allow for no custom questions on ask/offer form

Author: solebared

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+### Bugfixes
+* Ask/Offer form breaks when no custom questions are configured #621, #622
+
 ## [0.2.8] - 2020-08-02
 ### Bugfixes
 * Remove final & operator so all nils -> 0.0  #618

app/forms/submission_form.rb

@@ -1,11 +1,12 @@
 class SubmissionForm < BaseForm
+  hash :responses_attributes, strip: false, default: {}
+
   with_options default: nil do
     integer :id
     record  :service_area
     hash    :listing_attributes,   strip: false
     hash    :location_attributes,  strip: false
     hash    :person_attributes,    strip: false
-    hash    :responses_attributes, strip: false
     string  :form_name
     string  :privacy_level_requested  # fixme: not submitted as yet
   end
@@ -38,6 +39,7 @@ def build_listing
 
     def build_submission
       submission.tap do |submission|
+        # todo: this has to be smarter if we want to support partial updates
         submission.attributes = submission_attributes
       end
     end

spec/forms/submission_form_spec.rb

@@ -28,10 +28,9 @@
         email: '[email protected]',
         name: 'Harriet Tubman',
       },
-      responses_attributes: {
-        questions.first.id.to_s  => "answer 1",
-        questions.second.id.to_s => "answer 2"
-      },
+      responses_attributes: questions.map.with_index { |question, index|
+        [question.id.to_s, "answer #{index + 1}"]
+      }.to_h,
     }}
 
     subject(:submission) { SubmissionForm.build params }
@@ -129,6 +128,14 @@
         expect(submission_responses.length).to eq(2)
         expect(submission_responses.first.string_response).to eq("answer 1")
       end
+
+      context 'when there are no custom questions' do
+        let(:questions) { [] }
+
+        it 'works without error' do
+          expect(submission_responses).to be_empty
+        end
+      end
     end
 
     describe 'submission capture' do