Remove unused child association & related endpoint

Author: edwinthinks

app/controllers/children_controller.rb

@@ -65,14 +65,6 @@ def update
     end
   end
 
-  def destroy
-    child = current_partner.children.find_by(id: params[:id])
-    if child.present?
-      child.destroy
-      redirect_to children_url, notice: "Child was successfully destroyed."
-    end
-  end
-
   private
 
   def family

app/models/child.rb

@@ -23,8 +23,6 @@
 class Child < ApplicationRecord
   serialize :child_lives_with, Array
   belongs_to :family
-  has_many :family_request_child, dependent: :destroy
-  has_many :family_requests, through: :family_request_child
   has_many :child_item_requests, dependent: :destroy
 
   include Filterable

config/routes.rb

@@ -9,8 +9,7 @@
     sessions: "users/sessions",
     invitations: "users/invitations"
   }
-  # TODO: remove these two
-  resources :children do
+  resources :children, except: [:destroy] do
     post :active
   end
   resources :families

spec/requests/children_spec.rb

@@ -0,0 +1,41 @@
+require "rails_helper"
+
+RSpec.describe "Children", type: :request do
+  let(:partner) { create(:partner) }
+  let(:family) { create(:family, partner_id: partner.id) }
+
+  before do
+    user = create(:user, partner: partner)
+    sign_in(user)
+  end
+
+  describe "POST #create" do
+    it "should create and redirect to child_path" do
+      post children_path, params: { family_id: family.id, child: attributes_for(:child) }
+
+      select_child = Child.select(:id).last
+      expect(response).to redirect_to(child_path(select_child.id))
+      expect(request.flash[:notice]).to eql "Child was successfully created."
+    end
+  end
+
+  let(:child) { create(:child, family_id: family.id) }
+
+  describe "PUT #update" do
+    it "should update and redirect to child_path" do
+      put child_path(child), params: { child: attributes_for(:child) }
+
+      expect(response).to redirect_to(child_path(child.id))
+      expect(request.flash[:notice]).to eql "Child was successfully updated."
+    end
+  end
+
+  describe "POST #active" do
+    it "should verify if child is active" do
+      post child_active_path(child), params: { child_id: child.id }
+
+      expect(child.active).to eq true
+    end
+  end
+end
+