Create individuals orders (#435)

* Allow HTTP hosts on DiaperBankClient (i.e.: localhost)

* Extract multi-item-form helpers from partner requests

* Add soft and hard deletes to multi-item-form

* Move verify_staus_in_diaper_base to before_filter on PartnerRequestsController

* Extract authorize_verified_partners before_action

* Introduce individuals requests form

* Introduce FamilyRequest model

* Use FamilyRequest model on individuals requests

* Pull up payload generation for DiaperBankClient.send_family_request

* Create individuals request with FamilyRequestService

* Rename people_count to person_count to match family request

* Introduce item.as_payload to make sure item_id is integer

* Leverage FamilyRequest on FamilyRequestPayloadService

* Support assigning children through FamilyRequestService

* Submit family requests using FamilyRequestService

* Add link to individuals diaper request

* Fix rubocop violations

* Relable person count fields

* Verify response directly from subject

* Remove flaky test

* Remove unused method

Author: xjunior

app/assets/javascripts/multi-item-form.js

@@ -0,0 +1,23 @@
+$(document).on('click', '[data-add-target][data-add-template]', (event) => {
+  var button = $(event.target)
+  var target = button.data('add-target');
+  var template = button.data("add-template");
+  var templateId = new Date().getTime();
+  var rendered = template.replace(/([\[_])([0-9]+)([\]_])/g, "$1" + templateId + '$3');
+
+  $(target).append(rendered);
+
+  event.preventDefault();
+});
+
+$(document).on('click', '[data-remove-item]', (event) => {
+  var button = $(event.target)
+  var wrapper = button.closest('tr')
+  if (button.data("remove-item") === "soft") {
+    wrapper.hide();
+    button.prev('input[type=hidden]').val('1');
+  } else {
+    wrapper.remove()
+  }
+  event.preventDefault();
+});

app/assets/javascripts/partner_requests.js

@@ -33,6 +33,12 @@ def verify_status_in_diaper_base
     end
   end
 
+  def authorize_verified_partners
+    return if current_partner.verified?
+
+    redirect_to partner_requests_path, notice: "Please review your application details and submit for approval in order to make a new request."
+  end
+
   private
 
   def user_not_authorized

app/controllers/application_controller.rb

@@ -1,8 +1,9 @@
 class FamilyRequestsController < ApplicationController
   before_action :authenticate_user!
+  before_action :verify_status_in_diaper_base
+  before_action :authorize_verified_partners
 
   def new
-    verify_status_in_diaper_base
     @filterrific = initialize_filterrific(
       current_partner.children
           .order(last_name: :asc)
@@ -13,43 +14,13 @@ def new
   end
 
   def create
-    verify_status_in_diaper_base
-    children = current_partner.children.active.where.not(item_needed_diaperid: nil)
-    children_grouped_by_diaperid = children.group_by(&:item_needed_diaperid)
-    api_response = DiaperBankClient.send_family_request(
-      children: children,
-      partner: current_partner
-    )
+    children = current_partner.children.active.where.not(item_needed_diaperid: [nil, 0])
+    request = FamilyRequestPayloadService.execute(children: children, partner: current_partner)
 
-    if api_response
-      flash[:notice] = "Request sent to diaper bank successfully"
-      partner_request = PartnerRequest.new(
-        api_response
-        .slice("organization_id")
-        .merge(partner_id: current_partner.id, sent: true, for_families: true)
-      )
-      api_response["requested_items"].each do |item_hash|
-        partner_request.item_requests.new(
-          name: item_hash["item_name"],
-          item_id: item_hash["item_id"],
-          quantity: item_hash["count"],
-        ).tap do |item_request|
-          item_request.children =
-            children_grouped_by_diaperid[item_hash["item_id"]].to_a
-        end
-      end
-      partner_request.save!
-      redirect_to partner_requests_path
-    else
-      render :new
-    end
-  end
-
-  private
+    FamilyRequestService.execute(request)
 
-  def family_request_params
-    params.require(:family_request).slice(
-      :child_ids
-    )
+    redirect_to partner_requests_path, notice: "Requested items successfuly!"
+  rescue ActiveModel::ValidationError
+    render :new
   end
 end

app/controllers/family_requests_controller.rb

@@ -0,0 +1,28 @@
+class IndividualsRequestsController < ApplicationController
+  helper MultiItemFormHelper
+
+  before_action :authenticate_user!
+  before_action :verify_status_in_diaper_base
+  before_action :authorize_verified_partners
+
+  def new
+    @request = FamilyRequest.new({}, initial_items: 1)
+  end
+
+  def create
+    @request = FamilyRequest.new(family_request_params, partner: current_partner)
+
+    FamilyRequestService.execute(@request)
+
+    redirect_to partner_requests_path, notice: "Requested items successfuly!"
+  rescue ActiveModel::ValidationError
+    render :new
+  end
+
+  private
+
+  def family_request_params
+    params.require(:family_request)
+          .permit(:comments, items_attributes: %i[item_id person_count])
+  end
+end

app/controllers/individuals_requests_controller.rb

@@ -1,23 +1,21 @@
 class PartnerRequestsController < ApplicationController
+  helper MultiItemFormHelper
+
   before_action :authenticate_user!
+  before_action :verify_status_in_diaper_base, only: %i[new create]
+  before_action :authorize_verified_partners, only: %i[new]
 
   def index
     @partner = current_partner
     @partner_requests = current_partner.partner_requests.order(created_at: :desc) # PartnerRequest.where(partner_id: current_partner.id)
   end
 
   def new
-    verify_status_in_diaper_base
-    if current_partner.partner_status.casecmp("verified").zero?
-      @partner_request = PartnerRequest.new
-      @partner_request.item_requests.build # required to render the empty items form
-    else
-      redirect_to partner_requests_path, notice: "Please review your application details and submit for approval in order to make a new request."
-    end
+    @partner_request = PartnerRequest.new
+    @partner_request.item_requests.build # required to render the empty items form
   end
 
   def create
-    verify_status_in_diaper_base
     @partner_request = PartnerRequest.new(partner_request_params.merge(partner_id: current_partner.id))
     @partner_request.item_requests << create_item_requests
     respond_to do |format|

app/controllers/partner_requests_controller.rb

@@ -0,0 +1,13 @@
+module MultiItemFormHelper
+  def remove_item_button(label, soft: false)
+    link_to label, 'javascript:void(0)', class: 'btn btn-warning', data: { remove_item: soft ? "soft" : nil }
+  end
+
+  def add_item_button(label, container: ".fields", &block)
+    link_to(
+      label, "javascript:void(0)",
+      class: "btn btn-outline-primary",
+      data: { add_target: container, add_template: capture(&block) }
+    )
+  end
+end

app/helpers/multi_item_form_helper.rb

@@ -0,0 +1,36 @@
+class FamilyRequest
+  include ActiveModel::Model
+
+  attr_accessor :comments, :partner
+  attr_reader :items
+
+  def initialize(params, partner: nil, initial_items: nil)
+    @items = [Item.new] * initial_items if initial_items
+    @partner = partner
+    super params
+  end
+
+  def items_attributes=(attributes)
+    @items = attributes.map do |_, params|
+      Item.new(params.slice(:item_id, :person_count, :children))
+    end
+  end
+
+  def as_payload
+    {
+      organization_id: partner&.diaper_bank_id,
+      partner_id: partner&.diaper_partner_id,
+      requested_items: items.map(&:as_payload)
+    }
+  end
+
+  class Item
+    include ActiveModel::Model
+
+    attr_accessor :item_id, :person_count, :children
+
+    def as_payload
+      { item_id: item_id&.to_i, person_count: person_count&.to_i }
+    end
+  end
+end

app/helpers/partner_requests_helper.rb

@@ -15,11 +15,8 @@ def self.get_available_items(diaper_bank_id)
     end
   end
 
-  def self.send_family_request(children:, partner:)
-    payload = FamilyRequestPayloadService
-              .execute(children: children, partner: partner)
-
-    response = diaper_post_request(routes.family_requests, payload)
+  def self.send_family_request(payload)
+    response = diaper_post_request(routes.family_requests, payload.to_json)
     response.body ? JSON.parse(response.body) : nil
   end
 
@@ -35,7 +32,7 @@ def self.request_submission_post(partner_request_id)
   def self.https(uri)
     # Use a uri with `http://` to not use ssl.
     Net::HTTP.new(uri.host, uri.port).tap do |http|
-      http.use_ssl = true
+      http.use_ssl = uri.scheme.eql?("https")
       http.verify_mode = OpenSSL::SSL::VERIFY_NONE
     end
   end