Merge pull request #385 from rubyforgood/remove-unused-child-related-code

Remove unused child association & related endpoint

Author: edwinthinks

app/controllers/children_controller.rb

@@ -65,14 +65,6 @@ def update
     end
   end
 
-  def destroy
-    child = current_partner.children.find_by(id: params[:id])
-    if child.present?
-      child.destroy
-      redirect_to children_url, notice: "Child was successfully destroyed."
-    end
-  end
-
   private
 
   def family

app/models/child.rb

@@ -23,8 +23,6 @@
 class Child < ApplicationRecord
   serialize :child_lives_with, Array
   belongs_to :family
-  has_many :family_request_child, dependent: :destroy
-  has_many :family_requests, through: :family_request_child
   has_many :child_item_requests, dependent: :destroy
 
   include Filterable

config/routes.rb

@@ -9,8 +9,7 @@
     sessions: "users/sessions",
     invitations: "users/invitations"
   }
-  # TODO: remove these two
-  resources :children do
+  resources :children, except: [:destroy] do
     post :active
   end
   resources :families

spec/requests/children_controller_spec.rb

@@ -9,6 +9,15 @@
     sign_in(user)
   end
 
+  describe "GET #index" do
+    context "when specifying the csv format in the request" do
+      it "responds correct Content-Type" do
+        get children_path, headers: { "ACCEPT" => "text/csv" }
+        expect(response.content_type).to eq "text/csv"
+      end
+    end
+  end
+
   describe "POST #create" do
     it "should create and redirect to child_path" do
       post children_path, params: { family_id: family.id, child: attributes_for(:child) }
@@ -30,15 +39,6 @@
     end
   end
 
-  describe "DELETE #destroy" do
-    it "should destroy and redirect to child_path" do
-      delete child_path(child)
-
-      expect(response).to redirect_to(children_path)
-      expect(request.flash[:notice]).to eql "Child was successfully destroyed."
-    end
-  end
-
   describe "POST #active" do
     it "should verify if child is active" do
       post child_active_path(child), params: { child_id: child.id }
@@ -47,3 +47,4 @@
     end
   end
 end
+

…/controllers/children_controller_spec.rb spec/requests/children_spec.rbspec/controllers/children_controller_spec.rb renamed to spec/requests/children_spec.rb spec/controllers/children_controller_spec.rb renamed to spec/requests/children_spec.rb

@@ -29,9 +29,5 @@
     it "routes to #update via PATCH" do
       expect(patch: "/children/1").to route_to("children#update", id: "1")
     end
-
-    it "routes to #destroy" do
-      expect(delete: "/children/1").to route_to("children#destroy", id: "1")
-    end
   end
 end