Merge branch 'main' into language-model-16

* main:
  remove maily
  update authentication helpers for tests
  update Readme
  add maily, letter_opener and bullet

Author: dmitrytrager

Gemfile

@@ -58,6 +58,8 @@ end
 
 group :development do
   gem "hotwire-spark"
+  gem "bullet"
+  gem "letter_opener"
   # Use console on exceptions pages [https://github.com/rails/web-console]
   gem "web-console"
 end

Gemfile.lock

@@ -88,6 +88,9 @@ GEM
     brakeman (7.0.0)
       racc
     builder (3.3.0)
+    bullet (8.0.0)
+      activesupport (>= 3.0.0)
+      uniform_notifier (~> 1.11)
     capybara (3.40.0)
       addressable
       matrix
@@ -97,6 +100,8 @@ GEM
       rack-test (>= 0.6.3)
       regexp_parser (>= 1.5, < 3.0)
       xpath (~> 3.2)
+    childprocess (5.1.0)
+      logger (~> 1.5)
     concurrent-ruby (1.3.5)
     connection_pool (2.5.0)
     crass (1.0.6)
@@ -162,6 +167,12 @@ GEM
       thor (~> 1.3)
       zeitwerk (>= 2.6.18, < 3.0)
     language_server-protocol (3.17.0.4)
+    launchy (3.1.0)
+      addressable (~> 2.8)
+      childprocess (~> 5.0)
+      logger (~> 1.6)
+    letter_opener (1.10.0)
+      launchy (>= 2.2, < 4)
     listen (3.9.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
@@ -388,6 +399,7 @@ GEM
     unicode-display_width (3.1.4)
       unicode-emoji (~> 4.0, >= 4.0.4)
     unicode-emoji (4.0.4)
+    uniform_notifier (1.16.0)
     uri (1.0.2)
     useragent (0.16.11)
     web-console (4.2.1)
@@ -421,6 +433,7 @@ DEPENDENCIES
   bcrypt (~> 3.1.7)
   bootsnap
   brakeman
+  bullet
   capybara
   debug
   factory_bot_rails
@@ -429,6 +442,7 @@ DEPENDENCIES
   importmap-rails
   jbuilder
   kamal
+  letter_opener
   pg (~> 1.1)
   propshaft
   puma (>= 5.0)

README.md

@@ -11,14 +11,15 @@ SkillRX is one of many projects initiated and run by Ruby for Good. You can find
 # Welcome Contributors!
 Thank you for checking out our work. We are in the process of setting up the repository, roadmap, values, and contribution guidelines for the project. We will be adding issues and putting out a call for contributions soon.
 
+# Setup
+
+Clone this repo and run `bin/setup`. Run `bin/dev` or `bin/server` (if you like Overmind) to start working with app.
+
 # Testing
 
 This project uses:
 * `rspec` for testing
 * `shoulda-matchers` for expectations
 * `factory_bot` for making records
 
-To run tests execute
-```
-bin/rspec
-```
+To run tests simply use `bin/rspec`. You can also you `bin/quality` to check for code style issues.

bin/quality

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+
+require 'pathname'
+require 'fileutils'
+include FileUtils
+
+# path to your application root.
+APP_ROOT = Pathname.new File.expand_path('../../', __FILE__)
+
+def system!(*args)
+  system(*args) || abort("\n== Command #{args} failed ==")
+end
+
+# rubocop
+chdir APP_ROOT do
+  system! 'bin/rubocop --config .rubocop.yml'
+end
+
+# brakeman
+chdir APP_ROOT do
+  system! 'bin/brakeman --no-pager --no-progress'
+end
+
+# js
+chdir APP_ROOT do
+  system! 'bin/importmap audit'
+end

config/environments/development.rb

@@ -1,6 +1,17 @@
 require "active_support/core_ext/integer/time"
 
 Rails.application.configure do
+  if defined?(Bullet)
+    config.after_initialize do
+      Bullet.enable        = true
+      Bullet.alert         = true
+      Bullet.bullet_logger = true
+      Bullet.console       = true
+      Bullet.rails_logger  = true
+      Bullet.add_footer    = true
+    end
+  end
+
   # Settings specified here will take precedence over those in config/application.rb.
 
   # Make code changes take effect immediately without server restart.
@@ -31,6 +42,9 @@
   # Store uploaded files on the local file system (see config/storage.yml for options).
   config.active_storage.service = :local
 
+  config.action_mailer.delivery_method = :letter_opener
+  config.action_mailer.perform_deliveries = true
+
   # Don't care if the mailer can't send.
   config.action_mailer.raise_delivery_errors = false
 

config/environments/test.rb

@@ -4,6 +4,14 @@
 # and recreated between test runs. Don't rely on the data there!
 
 Rails.application.configure do
+  if defined?(Bullet)
+    config.after_initialize do
+      Bullet.enable        = true
+      Bullet.bullet_logger = true
+      Bullet.raise         = true # raise an error if n+1 query occurs
+    end
+  end
+
   # Settings specified here will take precedence over those in config/application.rb.
 
   # While tests run files are not watched, reloading is not necessary.

config/initializers/letter_opener.rb

@@ -0,0 +1,17 @@
+if defined?(LetterOpener)
+  LetterOpener.configure do |config|
+    # To overrider the location for message storage.
+    # Default value is `tmp/letter_opener`
+    config.location = Rails.root.join("tmp", "my_mails")
+
+    # To render only the message body, without any metadata or extra containers or styling.
+    # Default value is `:default` that renders styled message with showing useful metadata.
+    config.message_template = :light
+
+    # To change default file URI scheme you can provide `file_uri_scheme` config.
+    # It might be useful when you use WSL (Windows Subsystem for Linux) and default
+    # scheme doesn't work for you.
+    # Default value is blank
+    config.file_uri_scheme = "file://///wsl$/Ubuntu-18.04"
+  end
+end

spec/requests/regions_spec.rb

@@ -1,4 +1,4 @@
-require 'rails_helper'
+require "rails_helper"
 
 # This spec was generated by rspec-rails when you ran the scaffold generator.
 # It demonstrates how one might use RSpec to test the controller code that

spec/support/authentication_helper.rb

@@ -0,0 +1,9 @@
+module AuthenticationHelpers
+  def sign_in(user)
+    post session_url, params: { email: user.email, password: user.password }
+  end
+end
+
+RSpec.configure do |config|
+  config.include AuthenticationHelpers, type: :request
+end