Skip to content

Commit 2a012f9

Browse files
authored
fix: select columns and join tables manually for all providers xml file (#396)
2 parents 55cf7e3 + 1e4a04b commit 2a012f9

File tree

5 files changed

+16
-18
lines changed

5 files changed

+16
-18
lines changed

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ ruby "3.4.1"
55
gem "active_storage_validations"
66
gem "acts-as-taggable-on"
77
gem "aws-sdk-s3", require: false
8-
gem "azure_file_shares", github: "dmitrytrager/azure_file_shares"
8+
gem "azure_file_shares"
99
gem "bcrypt", "~> 3.1.7"
1010
gem "bootsnap", require: false
1111
gem "csv"

Gemfile.lock

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,3 @@
1-
GIT
2-
remote: https://github.com/dmitrytrager/azure_file_shares.git
3-
revision: 1df11d8f198e726e8eb8a2a9cc6826cc1c6707a6
4-
specs:
5-
azure_file_shares (0.1.5)
6-
faraday (~> 2.7)
7-
faraday-retry (~> 2.0)
8-
jwt (~> 2.7)
9-
nokogiri (~> 1.15)
10-
111
GEM
122
remote: https://rubygems.org/
133
specs:
@@ -116,6 +106,11 @@ GEM
116106
aws-sigv4 (~> 1.5)
117107
aws-sigv4 (1.12.1)
118108
aws-eventstream (~> 1, >= 1.0.2)
109+
azure_file_shares (0.1.5)
110+
faraday (~> 2.7)
111+
faraday-retry (~> 2.0)
112+
jwt (~> 2.7)
113+
nokogiri (~> 1.15)
119114
base64 (0.3.0)
120115
bcrypt (3.1.20)
121116
bcrypt_pbkdf (1.1.1)
@@ -594,7 +589,7 @@ DEPENDENCIES
594589
acts-as-taggable-on
595590
annotaterb
596591
aws-sdk-s3
597-
azure_file_shares!
592+
azure_file_shares
598593
bcrypt (~> 3.1.7)
599594
bootsnap
600595
brakeman

app/services/csv_generator/tag_details.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@ def headers
1414

1515
def scope
1616
language.topics.active.includes(:tags)
17-
.flat_map do |topic|
18-
topic.tags_on(language.code.to_sym)
19-
end
17+
.flat_map { |topic| topic.tags_on(language.code.to_sym) }
2018
.uniq
2119
.map do |tag|
2220
[

app/services/xml_generator/all_providers.rb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@ def initialize(language, **args)
77
attr_reader :language, :args
88

99
def xml_content(xml)
10-
language.providers.includes(:topics)
10+
language.providers
11+
.select("providers.id, providers.name, topics.id AS topic_id, topics.title AS topic_title, topics.created_at AS topic_created_at")
12+
.joins(:topics)
13+
.merge(Topic.with_attached_documents)
1114
.each do |provider|
1215
xml << provider_xml(provider)
1316
end

spec/services/xml_generator/all_providers_spec.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
let(:provider1) { create(:provider) }
88
let(:provider2) { create(:provider) }
99
let!(:topic1) { create(:topic, :tagged, language:, provider: provider1) }
10-
let!(:topic2) { create(:topic, :tagged, language:, provider: provider2) }
10+
let!(:topic2) { create(:topic, :with_documents, :tagged, language:, provider: provider2) }
1111
let(:tag_topic1) { create(:tag, name: "flu") }
1212
let(:tag_topic2) { create(:tag, name: "diabetes") }
1313

@@ -39,7 +39,9 @@
3939
<topic_month month="#{topic2.created_at.strftime("%m_%B")}">
4040
<title name="#{topic2.title}">
4141
<topic_id>#{topic2.id}</topic_id>
42-
<topic_files files="Files"/>
42+
<topic_files files="Files">
43+
<file_name_1 file_size="494323">test_image.png</file_name_1>
44+
</topic_files>
4345
<topic_tags>#{topic2.current_tags_list.join(", ")}</topic_tags>
4446
</title>
4547
</topic_month>

0 commit comments

Comments
 (0)