Use the tag methods provided by acts-as-taggable-on

Author: Oli0li

app/jobs/synchronize_cognates_on_topics_job.rb

@@ -1,7 +1,7 @@
 class SynchronizeCognatesOnTopicsJob < ApplicationJob
   def perform(tag)
     Topic.where(id: tag.taggings.select(:taggable_id)).each do |topic|
-      tags = topic.current_tags_list << tag.cognates_tags.uniq.pluck(:name)
+      tags = topic.tag_list << tag.cognates_tags.uniq.pluck(:name)
       topic.tag_list.add(tags)
       topic.save
     end

app/models/concerns/taggable.rb

@@ -13,20 +13,6 @@ class LanguageContextError < StandardError; end
     end
   end
 
-  # Retrieves associated tags
-  #
-  # @return [Array<Tag>] list of tags
-  def current_tags
-    tags
-  end
-
-  # Retrieves associated tags
-  #
-  # @return [Array<String>] list of tag names
-  def current_tags_list
-    tag_list
-  end
-
   # Updates the list of tags for a specific record
   # @param attrs [Array<String>] the list of tags
   # @return [Boolean] true if tags are processed successfully, false otherwise
@@ -49,7 +35,7 @@ def process_tags(tag_names)
     return unless tag_names.present?
 
     Rails.logger.info "Processing tags: #{tag_names} for record: #{id}"
-    removed_tags = current_tags_list - tag_names
+    removed_tags = tag_list - tag_names
     @full_list_of_tags = tag_names + removed_tags
     removed_tags_with_cognates = tags_with_cognates(removed_tags)
     tag_names_without_redundant_cognates = tag_names - removed_tags_with_cognates

app/services/text_generator/tags.rb

@@ -10,7 +10,7 @@ def initialize(language, **args)
 
   def text_content
     scope
-      .flat_map { |topic| topic.current_tags_list }
+      .flat_map { |topic| topic.tag_list }
       .uniq
       .sort
       .join("\n")

app/services/text_generator/title_and_tags.rb

@@ -11,7 +11,7 @@ def initialize(language, **args)
   def text_content
     scope
       .flat_map do |topic|
-        [ topic.title ] + topic.current_tags_list
+        [ topic.title ] + topic.tag_list
       end
       .join("\n")
   end

app/views/topics/_form.html.erb

@@ -47,7 +47,7 @@
                            ActsAsTaggableOn::Tag.all&.order(name: :asc),
                            :name,
                            :name,
-                           topic.current_tags_list
+                           topic.tag_list
                          ),
                          { prompt: "Select tags", include_blank: true },
                          multiple: true,

app/views/topics/_topic.html.erb

@@ -31,7 +31,7 @@
       </div>
       <div class="card-footer">
         <strong>Tags:</strong>
-        <% topic.current_tags.each do |tag| %>
+        <% topic.tags.each do |tag| %>
           <%= link_to tag.name, tag_path(tag), class: "badge bg-success text-decoration-none me-1", target: "_blank" %>
         <% end %>
       </div>

lib/autorequire/data_import.rb

@@ -204,7 +204,7 @@ def self.import_topic_tags
       topic.tag_list.add(tag_names_str)
       topic.save!
 
-      puts "#{topic.title} - #{topic.id} / Tags: #{topic.current_tags_list}"
+      puts "#{topic.title} - #{topic.id} / Tags: #{topic.tag_list}"
     end
     puts "Topic tags import completed"
   end

spec/factories/tags.rb

@@ -21,7 +21,7 @@
     trait :english do
       after(:build) do |tag|
         topic = create(:topic)
-        topic.current_tags << tag
+        topic.tags << tag
         topic.save
       end
     end

spec/jobs/synchronize_cognates_on_topics_job_spec.rb

@@ -34,7 +34,7 @@
 
     it "adds new cognates to topics tagged with the original tag" do
       SynchronizeCognatesOnTopicsJob.perform_now(tag)
-      expect(Topic.find_by(id: english_topic_1.id).current_tags_list)
+      expect(Topic.find_by(id: english_topic_1.id).tag_list)
         .to match_array([ "tag", "english cognate", "english reverse cognate", "spanish cognate", "spanish reverse cognate" ])
     end
   end

spec/requests/topics/update_spec.rb

@@ -37,7 +37,7 @@
           put topic_url(topic), params: { topic: topic_params }
 
           expect(response).to redirect_to(topics_url)
-          expect(topic.reload.current_tags).to be_empty
+          expect(topic.reload.tags).to be_empty
           expect(Tag.find_by(name: tag.name)).to be_nil
         end
       end
@@ -54,7 +54,7 @@
         it "removes the tag from the topic but does not destroy the tag" do
           put topic_url(topic), params: { topic: topic_params }
           expect(response).to redirect_to(topics_url)
-          expect(topic.reload.current_tags).to be_empty
+          expect(topic.reload.tags).to be_empty
           expect(Tag.find_by(name: tag.name)).to be_present
         end
       end
@@ -75,7 +75,7 @@
         put topic_url(topic), params: { topic: topic_params }
 
         expect(response).to redirect_to(topics_url)
-        expect(topic.reload.current_tags).to eq([])
+        expect(topic.reload.tags).to eq([])
         expect(Tag.find_by(name: "tag")).to be_nil
         expect(Tag.find_by(name: "cognate")).to be_nil
       end