Remove placeholders and fix footer (#315)

Oli0li · web-flow · commit 755d024035fe · 2025-07-28T10:02:06.000+01:00
diff --git a/app/controllers/concerns/authentication.rb b/app/controllers/concerns/authentication.rb
@@ -13,7 +13,7 @@ def allow_unauthenticated_access(**options)
   end
 
   def redirect_contributors
-    redirect_to dashboard_path unless Current.user.is_admin?
+    redirect_to topics_path unless Current.user.is_admin?
   end
 
   private
@@ -39,7 +39,7 @@ def request_authentication
     end
 
     def after_authentication_url
-      session.delete(:return_to_after_authenticating) || dashboard_url
+      session.delete(:return_to_after_authenticating) || topics_url
     end
 
     def start_new_session_for(user)
diff --git a/app/controllers/dashboard_controller.rb b/app/controllers/dashboard_controller.rb
diff --git a/app/views/dashboard/index.html.erb b/app/views/dashboard/index.html.erb
diff --git a/app/views/home/index.html.erb b/app/views/home/index.html.erb
@@ -12,7 +12,7 @@
         <!-- New Sign In link using Rails 8 authentication -->
         <% if authenticated? %>
           <li class="nav-item">
-            <%= link_to "Dashboard", dashboard_path, class: "nav-link" %>
+            <%= link_to "Dashboard", topics_path, class: "nav-link" %>
           </li>
           <li class="nav-item">
             <%= button_to "Sign Out", session_path, method: :delete, class: "nav-link" %>
@@ -36,9 +36,6 @@
         <p class="lead">Empowering healthcare professionals worldwide with accessible continuing medical education</p>
         <%= link_to "Get Started", new_session_path, class: "btn btn-light btn-lg" %>
       </div>
-      <div class="col-lg-6">
-        <img src="/api/placeholder/600/400" alt="Medical professionals using SkillRx" class="img-fluid rounded">
-      </div>
     </div>
   </div>
 </header>
@@ -89,9 +86,6 @@
           <li class="mb-2">✓ Adaptable to local needs</li>
       </ul>
       </div>
-      <div class="col-lg-6">
-        <img src="/api/placeholder/600/400" alt="Healthcare professionals collaborating" class="img-fluid rounded">
-      </div>
     </div>
   </div>
 </section>
diff --git a/app/views/languages/index.html.erb b/app/views/languages/index.html.erb
@@ -12,7 +12,6 @@
         </div>
         <div class="card-content">
           <div class="card-body">
-            <p class="card-text"> Some important information or instruction can be placed here.</p>
             <div class="table-responsive">
               <table class="table table-lg table-striped mb-0">
                 <thead>
diff --git a/app/views/layouts/_sidebar.html.erb b/app/views/layouts/_sidebar.html.erb
@@ -4,7 +4,7 @@
     <div class="sidebar-header position-relative">
       <div class="d-flex justify-content-between align-items-center">
         <div class="logo">
-          <%= link_to("SkillRx", dashboard_path) %>
+          <%= link_to("SkillRx", root_path) %>
         </div>
         <div class="theme-toggle d-flex gap-2  align-items-center mt-2">
           <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" aria-hidden="true"
diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb
@@ -51,7 +51,6 @@
       }
 
       footer {
-        position: absolute;
         bottom: 0;
         width: 100%;
         height: 60px; /* Fixed height */
@@ -75,7 +74,7 @@
 
     <div id="app">
       <%= render "layouts/sidebar" %>
-      <div id="main" class='layout-navbar navbar-fixed'>
+      <div id="main" class='layout-navbar'>
         <div id="main-content">
           <%= render "shared/flash" %>
 
diff --git a/app/views/providers/index.html.erb b/app/views/providers/index.html.erb
@@ -12,16 +12,6 @@
         </div>
         <div class="card-content">
           <div class="card-body">
-            <p class="card-text">
-              Lorem ipsum dolor sit amet, <code>consectetur adipiscing</code> elit. Sed do eiusmod tempor incididunt ut
-              labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut
-              aliquip
-              ex ea commodo consequat. Duis aute irure dolor in <code>reprehenderit</code> in voluptate velit esse
-              cillum dolore eu fugiat nulla
-              pariatur. Excepteur sint <code>occaecat cupidatat</code> non proident, sunt in culpa qui officia deserunt
-              mollit anim id est
-              laborum.
-            </p>
             <!-- table striped -->
             <div class="table-responsive">
               <table class="table table-lg table-striped mb-0">
diff --git a/app/views/providers/new.html.erb b/app/views/providers/new.html.erb
@@ -9,11 +9,6 @@
         </div>
         <div class="card-content">
           <div class="card-body">
-            <p>Providers should ... Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed do eiusmod tempor incididunt ut
-              labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip
-              ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla
-              pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est
-              laborum.</p>
             <%= render "form", provider: @provider %>
           </div>
         </div>
diff --git a/app/views/regions/index.html.erb b/app/views/regions/index.html.erb
@@ -12,16 +12,6 @@
         </div>
         <div class="card-content">
           <div class="card-body">
-            <p class="card-text">
-              Lorem ipsum dolor sit amet, <code>consectetur adipiscing</code> elit. Sed do eiusmod tempor incididunt ut
-              labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut
-              aliquip
-              ex ea commodo consequat. Duis aute irure dolor in <code>reprehenderit</code> in voluptate velit esse
-              cillum dolore eu fugiat nulla
-              pariatur. Excepteur sint <code>occaecat cupidatat</code> non proident, sunt in culpa qui officia deserunt
-              mollit anim id est
-              laborum.
-            </p>
             <!-- table striped -->
             <div class="table-responsive">
               <table class="table table-lg table-striped mb-0">
@@ -59,4 +49,3 @@
     </div>
   </div>
 </section>
-
diff --git a/app/views/regions/new.html.erb b/app/views/regions/new.html.erb
@@ -9,11 +9,6 @@
         </div>
         <div class="card-content">
           <div class="card-body">
-            <p>Regions should ... Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed do eiusmod tempor incididunt ut 
-              labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip 
-              ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla
-              pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est 
-              laborum.</p>
             <%= render "form", region: @region %>
           </div>
         </div>
diff --git a/app/views/topics/index.html.erb b/app/views/topics/index.html.erb
@@ -17,7 +17,6 @@
               <% if @available_providers.any? %>
                 <%= render "choose_provider", providers: @available_providers %>
               <% end %>
-              <p class="card-text"> Some important information or instruction can be placed here.</p>
               <%= turbo_frame_tag "topic-list" do %>
                 <div class="table-responsive">
                   <table class="table table-lg table-striped mb-0">
diff --git a/app/views/users/new.html.erb b/app/views/users/new.html.erb
@@ -9,11 +9,6 @@
         </div>
         <div class="card-content">
           <div class="card-body">
-            <p>User should ... Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed do eiusmod tempor incididunt ut 
-              labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip 
-              ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla
-              pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est 
-              laborum.</p>
             <%= render "form", user: @user %>
           </div>
         </div>
diff --git a/config/routes.rb b/config/routes.rb
@@ -33,7 +33,6 @@
   get "up" => "rails/health#show", as: :rails_health_check
 
   get "home/index", as: :home
-  get "dashboard/index", as: :dashboard
 
   # Render dynamic PWA files from app/views/pwa/* (remember to link manifest in application.html.erb)
   # get "manifest" => "rails/pwa#manifest", as: :pwa_manifest
diff --git a/spec/requests/authorizations_spec.rb b/spec/requests/authorizations_spec.rb
@@ -13,22 +13,22 @@
 
     it "cannot access the Regions tab" do
       get "/regions"
-      expect(response).to redirect_to(dashboard_path)
+      expect(response).to redirect_to(topics_path)
     end
 
     it "cannot access the Providers tab" do
       get "/providers"
-      expect(response).to redirect_to(dashboard_path)
+      expect(response).to redirect_to(topics_path)
     end
 
     it "cannot access the Languages tab" do
       get "/languages"
-      expect(response).to redirect_to(dashboard_path)
+      expect(response).to redirect_to(topics_path)
     end
 
     it "cannot access the Users tab" do
       get "/users"
-      expect(response).to redirect_to(dashboard_path)
+      expect(response).to redirect_to(topics_path)
     end
   end
 
diff --git a/spec/requests/dashboard_spec.rb b/spec/requests/dashboard_spec.rb
diff --git a/spec/system/topics/search_spec.rb b/spec/system/topics/search_spec.rb
@@ -183,21 +183,9 @@
   context "when the user is a contributor" do
     let(:user) { create(:user) }
 
-    context "with no associated providers" do
-      before { click_link("Topics") }
-
-      it "shows no topics" do
-        expect(page).to have_link("Add New Topic")
-        expect(page).not_to have_text(english_active_topic.title)
-        expect(page).not_to have_text(spanish_active_topic.title)
-        expect(page).not_to have_text(english_archived_topic.title)
-        expect(page).not_to have_text(other_provider_topic.title)
-      end
-    end
-
     context "with 1 associated provider" do
       before do
-        user.providers << provider_1
+        user.update(provider_ids: [ provider_1.id ])
         click_link("Topics")
       end
 
@@ -316,7 +304,7 @@
 
     context "with multiple associated providers" do
       before do
-        user.providers << [ provider_1, provider_2 ]
+        user.update(provider_ids: [ provider_1.id, provider_2.id ])
         click_link("Topics")
       end
 
diff --git a/spec/views/home/index.html.erb_spec.rb b/spec/views/home/index.html.erb_spec.rb
@@ -15,7 +15,7 @@
 
     it "displays link to the dashboard" do
       render
-      expect(rendered).to have_link("Dashboard", href: dashboard_path)
+      expect(rendered).to have_link("Dashboard", href: topics_path)
     end
 
     it "has button to sign out" do
