Remove condition for #shadow_delete_documents

On the row where #shadow_delete_documents is called, topic.persisted?
also returns true for newly created topics since we just saved.
I don't think we really need a condition because docs_to_delete would be
blank for newly created topics. If we do want one, using
topic.previously_new_record? wouldn't work because topic gets updated
when running #attach_files, so we would have to do something like
"new_record = topic.new_record?" before calling topic.save_with_tags
and then use "unless new_record".

Author: Oli0li

app/services/topics/mutator.rb

@@ -53,8 +53,7 @@ def mutate
     ActiveRecord::Base.transaction do
       topic.save_with_tags(params)
       attach_files(document_signed_ids)
-      # topic.persisted? means that we are updating existing topic and documents can be removed
-      shadow_delete_documents(docs_to_delete) if topic.persisted?
+      shadow_delete_documents(docs_to_delete)
       rename_files(document_signed_ids)
       # document_signed_ids.any? means that some new documents were attached and we need to sync them
       sync_docs_for_topic_updates if document_signed_ids.any?
@@ -75,7 +74,7 @@ def attach_files(signed_ids)
   def rename_files(signed_ids)
     return if signed_ids.blank?
     signed_ids.each do |signed_id|
-    document = topic.documents.find { |doc| doc.blob.signed_id == signed_id }
+      document = topic.documents.find { |doc| doc.blob.signed_id == signed_id }
       next unless document
 
       new_filename = topic.custom_file_name(document)