Reset topic ID starting value during import #265 (#268)

Author: dcollie2

Gemfile.lock

@@ -123,7 +123,7 @@ GEM
     bindex (0.8.1)
     bootsnap (1.18.6)
       msgpack (~> 1.2)
-    brakeman (7.0.2)
+    brakeman (7.1.0)
       racc
     builder (3.3.0)
     bullet (8.0.8)

brakeman

@@ -0,0 +1,28 @@
+{
+  "ignored_warnings": [
+    {
+      "warning_type": "SQL Injection",
+      "warning_code": 0,
+      "fingerprint": "05636d40d833157e028a2fd9aecd6f263d7f3915f8ed3334a502e18763f1841d",
+      "check_name": "SQL",
+      "message": "Possible SQL injection",
+      "file": "lib/autorequire/data_import.rb",
+      "line": 148,
+      "link": "https://brakemanscanner.org/docs/warning_types/sql_injection/",
+      "code": "ActiveRecord::Base.connection.execute(\"SELECT setval('topics_id_seq', #{((Topic.maximum(:id) or 0) + 1)}, ?)\", false)",
+      "render_path": null,
+      "location": {
+        "type": "method",
+        "class": "DataImport",
+        "method": "s(:self).reset_topic_id_starting_value"
+      },
+      "user_input": "Topic.maximum(:id)",
+      "confidence": "High",
+      "cwe_id": [
+        89
+      ],
+      "note": ""
+    }
+  ],
+  "brakeman_version": "7.0.2"
+}

config/brakeman.ignore

@@ -0,0 +1,28 @@
+{
+  "ignored_warnings": [
+    {
+      "warning_type": "SQL Injection",
+      "warning_code": 0,
+      "fingerprint": "05636d40d833157e028a2fd9aecd6f263d7f3915f8ed3334a502e18763f1841d",
+      "check_name": "SQL",
+      "message": "Possible SQL injection",
+      "file": "lib/autorequire/data_import.rb",
+      "line": 148,
+      "link": "https://brakemanscanner.org/docs/warning_types/sql_injection/",
+      "code": "ActiveRecord::Base.connection.execute(\"SELECT setval('topics_id_seq', #{((Topic.maximum(:id) or 0) + 1)}, ?)\", false)",
+      "render_path": null,
+      "location": {
+        "type": "method",
+        "class": "DataImport",
+        "method": "s(:self).reset_topic_id_starting_value"
+      },
+      "user_input": "Topic.maximum(:id)",
+      "confidence": "High",
+      "cwe_id": [
+        89
+      ],
+      "note": ""
+    }
+  ],
+  "brakeman_version": "7.0.2"
+}

lib/autorequire/data_import.rb

@@ -139,6 +139,14 @@ def self.import_topics
       puts "#{topic.title} #{topic.new_record? ? "created" : "already exists"}"
       topic.save!
     end
+    reset_topic_id_starting_value
+  end
+
+  def self.reset_topic_id_starting_value
+    max_id = Topic.maximum(:id) || 0
+    new_start_value = max_id + 1
+      ActiveRecord::Base.connection.execute("SELECT setval('topics_id_seq', #{new_start_value}, ?)", false)
+    puts "Reset topics ID starting value to #{new_start_value}"
   end
 
   def self.import_tags