Add search functionality to users

There used to be a search functionality in the users index page that was
using Mazer's datatable stylesheet (PR#52), but it was then removed in
PR#86 as we discussed doing it our way instead.

This commit enables searching Users by using a similar logic to what
Dmitry did for searching Topics.

Author: Oli0li

app/controllers/users_controller.rb

@@ -3,7 +3,7 @@ class UsersController < ApplicationController
   before_action :set_user, only: %i[ edit update destroy ]
 
   def index
-    @users = User.all
+    @users = User.all.search_with_params(user_search_params)
   end
 
   def new
@@ -52,4 +52,9 @@ def set_user
   def user_params
     params.expect(user: [ :email, :password, :is_admin ])
   end
+
+  def user_search_params
+    return {} unless params[:search].present?
+    params.expect(search: [ :email, :is_admin, :order ])
+  end
 end

app/models/user.rb

@@ -24,6 +24,13 @@ class User < ApplicationRecord
   validates :email, presence: true, uniqueness: true, format: URI::MailTo::EMAIL_REGEXP
   validates :password_digest, presence: true
 
+  scope :search_with_params, ->(params) do
+    self
+    .then { |scope| params[:email].present? ? scope.where("email ILIKE ?", "%#{params[:email]}%") : scope }
+    .then { |scope| params[:is_admin].present? ? scope.where(is_admin: params[:is_admin]) : scope }
+    .then { |scope| scope.order(created_at: params[:order]&.to_sym || :desc) }
+  end
+
   def topics
     Topic.where(provider_id: providers.pluck(:id))
   end

app/views/users/index.html.erb

@@ -1,5 +1,42 @@
 <div class="page-heading">
   <section class="section">
+    <div class="card">
+      <div class="card-header d-flex justify-content-between align-items-center">
+        <h2 class="card-title">Search</h2>
+      </div>
+      <div class="card-content">
+        <div class="card-body">
+          <%= form_for :search, url: users_path, method: :get, data: { controller: "search", search_target: "search", turbo_frame: "user-list", turbo_action: "advance" } do |f| %>
+            <div class="form-body">
+              <div class="row">
+                <div class="col-md-6 col-12">
+                  <div class="form-group">
+                    <%= f.label :email %>
+                    <%= f.text_field :email, value: params.dig(:search, :email), class: "form-control", data: { action: "input->search#submit" } %>
+                  </div>
+                </div>
+                <div class="col-md-6 col-12">
+                  <div class="form-group">
+                    <%= f.label "Role" %>
+                    <%= f.select :is_admin, options_for_select([["Admin", "true"], ["Contributor", "false"]], params.dig(:search, :is_admin)), { prompt: "Select user role" }, class: "form-select", data: { action: "change->search#submit" } %>
+                  </div>
+                </div>
+                <div class="col-md-6 col-12">
+                  <div class="form-group">
+                    <%= f.label :order %>
+                    <%= f.select :order, options_for_select([["By most recently added", :desc], ["By least recently added", :asc]], params.dig(:search, :order)), {}, class: "form-select", data: { action: "change->search#submit" } %>
+                  </div>
+                </div>
+                <div class="col-12 d-flex justify-content-end">
+                  <%= link_to "Clear", users_path, class: "btn btn-light-secondary me-1 mb-1" %>
+                </div>
+              </div>
+            </div>
+          <% end %>
+        </div>
+      </div>
+    </div>
+
     <div class="card">
       <div class="card-header d-flex justify-content-between align-items-center">
         <h2>User List</h2>
@@ -20,7 +57,7 @@
             <% @users.each do |user| %>
               <tr>
                 <td><%= user.email %></td>
-                <td><%= user.is_admin %></td>
+                <td><%= user.is_admin ? "✅" : "✖️"  %></td>
                 <td class="text-end">
                   <%= link_to edit_user_path(user), class: "btn btn-secondary btn-sm pr-2" do %>
                     <i class="bi bi-pencil"></i> Edit

spec/system/user_search_spec.rb

@@ -0,0 +1,49 @@
+require "rails_helper"
+
+RSpec.describe "User search", type: :system do
+  let(:admin) { create(:user, :admin, email: "[email protected]", created_at: 3.days.ago) }
+  let!(:martin) { create(:user, email: "[email protected]", created_at: 2.days.ago) }
+  let!(:rosemary) { create(:user, email: "[email protected]", created_at: 1.day.ago) }
+
+  before do
+    login_as(admin)
+    click_link("Users")
+  end
+
+  it "shows by default the users from most to least recently added" do
+    expect(page).to have_text(/#{rosemary.email}.+#{martin.email}.+#{admin.email}/m)
+  end
+
+  context "searching by email" do
+    it "only displays users matching the search" do
+      fill_in "search[email]", with: "mar"
+
+      expect(page).to have_text(rosemary.email)
+      expect(page).to have_text(martin.email)
+      expect(page).not_to have_text(admin.email)
+    end
+  end
+
+  context "searching by role" do
+    it "only displays users matching the search" do
+      select "Admin", from: "search_is_admin"
+
+      expect(page).to have_text(admin.email)
+      expect(page).not_to have_text(rosemary.email)
+      expect(page).not_to have_text(martin.email)
+
+      select "Contributor", from: "search_is_admin"
+
+      expect(page).to have_text(rosemary.email)
+      expect(page).to have_text(martin.email)
+      expect(page).not_to have_text(admin.email)
+    end
+  end
+
+  context "sorting" do
+    it "displays users in the selected order" do
+      select "By least recently added", from: "search_order"
+      expect(page).to have_text(/#{admin.email}.+#{martin.email}.+#{rosemary.email}/m)
+    end
+  end
+end