Consolidate specs

Author: hernanvicente

app/models/training_resource.rb

@@ -1,8 +1,10 @@
 class TrainingResource < ApplicationRecord
   belongs_to :topic
+  has_one :language, through: :topic
   has_one_attached :document
 
   validates :state, presence: true
+
   validates_with DocumentValidator
   validates_with ResourceLanguageValidator
 end

spec/factories/providers.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory :provider do
-    name { "ACME" }
+    sequence(:name) { |n| "provider_#{n}" }
     provider_type { "provider" }
   end
 end

spec/factories/training_resources.rb

@@ -1,8 +1,8 @@
 FactoryBot.define do
   factory :training_resource do
-    state { 1 }
+    sequence(:file_name_override) { |n| "file_name_override_#{n}.jpg" }
     document {  Rack::Test::UploadedFile.new("spec/support/images/logo_ruby_for_good.png", "image/png") }
-    topic { create(:topic) }
-    file_name_override { "test.jpg" }
+    state { 1 }
+    topic
   end
 end

spec/requests/training_resources/create_spec.rb

@@ -0,0 +1,58 @@
+require "rails_helper"
+
+RSpec.describe "Training Resources", type: :request do
+  describe "POST /training_resources" do
+    let(:user) { create(:user) }
+    let(:topic) { create(:topic) }
+    let(:valid_attributes) { attributes_for(:training_resource, topic_id: topic.id) }
+    let(:invalid_attributes) { { document: "", file_name_override: "", state: "", topic_id: "" } }
+
+    before { sign_in(user) }
+
+    context "with valid parameters" do
+      it "creates a new TrainingResource" do
+        expect {
+          post training_resources_url, params: { training_resource: valid_attributes }
+        }.to change(TrainingResource, :count).by(1)
+      end
+
+      it "redirects to the created training_resource" do
+        post training_resources_url, params: { training_resource: valid_attributes }
+        expect(response).to redirect_to(training_resource_url(TrainingResource.last))
+      end
+    end
+
+    context "with invalid parameters" do
+      it "does not create a new TrainingResource" do
+        expect {
+          post training_resources_url, params: { training_resource: invalid_attributes }
+        }.to change(TrainingResource, :count).by(0)
+      end
+
+      it "renders a response with 422 status (i.e. to display the 'new' template)" do
+        post training_resources_url, params: { training_resource: invalid_attributes }
+        expect(response).to have_http_status(:unprocessable_entity)
+      end
+    end
+
+    context "with file_name_override present" do
+      it "does not create a new TrainingResource if there is already a preexistent entry with the same language" do
+        preexistent_topic = create(:topic, language_id: topic.language_id)
+        TrainingResource.create! valid_attributes
+
+        post training_resources_url, params: { training_resource: valid_attributes.merge(topic_id: preexistent_topic.id) }
+
+        expect(response).to have_http_status(:unprocessable_entity)
+      end
+
+      it "creates a new Training Resource if file_name_override has a different language" do
+        preexistent_topic = create(:topic)
+        TrainingResource.create! valid_attributes
+
+        post training_resources_url, params: { training_resource: valid_attributes.merge(topic_id: preexistent_topic.id) }
+
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+  end
+end

spec/requests/training_resources/destroy_spec.rb

@@ -0,0 +1,24 @@
+require "rails_helper"
+
+RSpec.describe "Training Resources", type: :request do
+  describe "DELETE /destroy" do
+    let(:user) { create(:user) }
+    let(:topic) { create(:topic) }
+    let(:valid_attributes) { attributes_for(:training_resource, topic_id: topic.id) }
+
+    before { sign_in(user) }
+
+    it "destroys the requested training_resource" do
+      training_resource = TrainingResource.create! valid_attributes
+      expect {
+        delete training_resource_url(training_resource)
+      }.to change(TrainingResource, :count).by(-1)
+    end
+
+    it "redirects to the training_resources list" do
+      training_resource = TrainingResource.create! valid_attributes
+      delete training_resource_url(training_resource)
+      expect(response).to redirect_to(training_resources_url)
+    end
+  end
+end

spec/requests/training_resources/edit_spec.rb

@@ -0,0 +1,17 @@
+require "rails_helper"
+
+RSpec.describe "Training Resources", type: :request do
+  describe "GET /training_resources/:id" do
+    let(:user) { create(:user) }
+
+    before { sign_in(user) }
+
+    it "renders a successful response" do
+      training_resource = create(:training_resource)
+
+      get edit_training_resource_url(training_resource)
+
+      expect(response).to be_successful
+    end
+  end
+end

spec/requests/training_resources/index_spec.rb

@@ -0,0 +1,18 @@
+require "rails_helper"
+
+RSpec.describe "Training Resources", type: :request do
+  describe "GET /training_resources" do
+    let(:user) { create(:user) }
+
+    before { sign_in(user) }
+
+    it "renders a successful response" do
+      create(:training_resource)
+
+      get training_resources_url
+
+      expect(response).to be_successful
+      expect(assigns(:training_resources)).to eq(TrainingResource.all)
+    end
+  end
+end

spec/requests/training_resources/new_spec.rb

@@ -0,0 +1,15 @@
+require "rails_helper"
+
+RSpec.describe "Training Resources", type: :request do
+  describe "GET /training_resources/new" do
+    let(:user) { create(:user) }
+
+    before { sign_in(user) }
+
+    it "renders a successful response" do
+      get new_training_resource_url
+
+      expect(response).to be_successful
+    end
+  end
+end

spec/requests/training_resources/show_spec.rb

@@ -0,0 +1,17 @@
+require "rails_helper"
+
+RSpec.describe "Training Resources", type: :request do
+  describe "GET /training_resources/:id" do
+    let(:user) { create(:user) }
+
+    before { sign_in(user) }
+
+    it "renders a successful response" do
+      training_resource = create(:training_resource)
+
+      get training_resource_url(training_resource)
+
+      expect(response).to be_successful
+    end
+  end
+end

spec/requests/training_resources/update_spec.rb

@@ -0,0 +1,40 @@
+require "rails_helper"
+
+RSpec.describe "Training Resources", type: :request do
+  describe "PATCH /training_resources" do
+    let(:user) { create(:user) }
+    let(:topic) { create(:topic) }
+    let(:valid_attributes) { attributes_for(:training_resource, topic_id: topic.id) }
+    let(:invalid_attributes) { { document: "", file_name_override: "", state: "", topic_id: "" } }
+
+    before { sign_in(user) }
+
+    context "with valid parameters" do
+      let(:new_attributes) {
+        { state: 1 }
+      }
+
+      it "updates the requested training_resource" do
+        training_resource = TrainingResource.create! valid_attributes
+        patch training_resource_url(training_resource), params: { training_resource: new_attributes }
+        training_resource.reload
+        expect(response).to redirect_to(training_resource_url(training_resource))
+      end
+
+      it "redirects to the training_resource" do
+        training_resource = TrainingResource.create! valid_attributes
+        patch training_resource_url(training_resource), params: { training_resource: new_attributes }
+        training_resource.reload
+        expect(response).to redirect_to(training_resource_url(training_resource))
+      end
+    end
+
+    context "with invalid parameters" do
+      it "renders a response with 422 status (i.e. to display the 'edit' template)" do
+        training_resource = TrainingResource.create! valid_attributes
+        patch training_resource_url(training_resource), params: { training_resource: invalid_attributes }
+        expect(response).to have_http_status(:unprocessable_entity)
+      end
+    end
+  end
+end