Skip to content

Commit d2f1709

Browse files
committed
Apparently provider ui is only for admins, so no need to hide contributors.
1 parent 47ff00c commit d2f1709

File tree

4 files changed

+8
-36
lines changed

4 files changed

+8
-36
lines changed

app/views/providers/_form.html.erb

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,12 @@
3232
</div>
3333
</div>
3434

35-
<% if Current.user.is_admin %>
36-
<div class="col-md-4">
37-
<div class="form-group">
38-
<%= form.label :contributors, style: "display: block" %>
39-
<%= form.collection_select :user_ids, User.order(:email), :id, :email, { include_hidden: false }, class: "form-select", multiple: true %>
40-
</div>
35+
<div class="col-md-4">
36+
<div class="form-group">
37+
<%= form.label :contributors, style: "display: block" %>
38+
<%= form.collection_select :user_ids, User.order(:email), :id, :email, { include_hidden: false }, class: "form-select", multiple: true %>
4139
</div>
42-
<% end %>
40+
</div>
4341

4442
<div class="mt-4">
4543
<div class="col-12 d-flex justify-content-end">

db/schema.rb

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/factories/users.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,4 @@
88
is_admin { true }
99
end
1010
end
11-
12-
factory :admin do
13-
email { "[email protected]" }
14-
password { "password" }
15-
is_admin { true }
16-
end
1711
end

spec/views/providers/edit.html.erb_spec.rb

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,6 @@
22

33
RSpec.describe "providers/edit", type: :view do
44
let(:provider) { create(:provider) }
5-
let(:admin) { create(:admin) }
6-
let(:user) { create(:user) }
7-
8-
before do
9-
allow(Current).to receive(:user).and_return(user)
10-
end
115

126
before(:each) do
137
assign(:provider, provider)
@@ -22,25 +16,11 @@
2216
end
2317
end
2418

25-
it "does not render the contributor form group for common user" do
19+
it "renders the contributor form group" do
2620
render
2721

2822
assert_select "form[action=?][method=?]", provider_path(provider), "post" do
29-
assert_select "select[id=?]", "provider_user_ids", false
30-
end
31-
end
32-
33-
describe "for admin" do
34-
before do
35-
allow(Current).to receive(:user).and_return(admin)
36-
end
37-
38-
it "renders the contributor form group" do
39-
render
40-
41-
assert_select "form[action=?][method=?]", provider_path(provider), "post" do
42-
assert_select "select[id=?]", "provider_user_ids"
43-
end
23+
assert_select "select[id=?]", "provider_user_ids"
4424
end
4525
end
4626
end

0 commit comments

Comments
 (0)