Skip to content

Conversation

@Oli0li
Copy link
Collaborator

@Oli0li Oli0li commented Feb 5, 2025

What Issue Does This PR Cover, If Any?

This just fixes a few bugs/removes unused files.

What Changed? And Why Did It Change?

This fixes:

  • the redirect after signing in
  • the "Regions" icon
  • the "Add New User" button (layout + url)

And it also removes the RegistrationsControllers since users won't be able to freely sign up (instead, an Admin will create a User).

How Has This Been Tested?

I have written tests and tested by hand.

Please Provide Screenshots

Before
Capture d'écran 2025-02-05 090556

After
Capture d'écran 2025-02-05 090232

@Oli0li Oli0li requested a review from seanmarcia February 5, 2025 09:06
This fixes the url and applies the same styling as on other similar pages.
I erroneously changed it to the same as for Providers when resolving
a conflict.
For now I'm making it redirect to the first tab on the Admin dashboard
but we may want to change that later.
This is not needed since Admins will be the ones creating Users.
People won't be able to freely sign up.
@Oli0li Oli0li force-pushed the various-bug-fixes branch from 1ccfef5 to bee8c84 Compare February 5, 2025 09:45
@Oli0li Oli0li merged commit 24b68d8 into main Feb 5, 2025
4 checks passed
@hernanvicente hernanvicente deleted the various-bug-fixes branch February 5, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants