Merge pull request #972 from rubyforgood/issue-937-938_admin-school-years-stocks

Issue 937 938 admin school years stocks

Author: americac

app/controllers/admin_v2/school_years_controller.rb

@@ -0,0 +1,93 @@
+# frozen_string_literal: true
+
+module AdminV2
+  class SchoolYearsController < BaseController
+    before_action :set_school_year, only: %i[show edit update destroy]
+
+    def index
+      @school_years = apply_sorting(SchoolYear.includes(:school, :year), default: "id")
+
+      @breadcrumbs = [
+        { label: "School Years" }
+      ]
+    end
+
+    def show
+      @breadcrumbs = [
+        { label: "School Years", path: admin_v2_school_years_path },
+        { label: @school_year.to_s }
+      ]
+    end
+
+    def new
+      @school_year = SchoolYear.new
+
+      @breadcrumbs = [
+        { label: "School Years", path: admin_v2_school_years_path },
+        { label: "New School Year" }
+      ]
+    end
+
+    def edit
+      @breadcrumbs = [
+        { label: "School Years", path: admin_v2_school_years_path },
+        { label: @school_year.to_s, path: admin_v2_school_year_path(@school_year) },
+        { label: "Edit" }
+      ]
+    end
+
+    def create
+      school = School.find(school_year_params[:school_id])
+      year = Year.find(school_year_params[:year_id])
+
+      @school_year = SchoolYearCreationService.new(school: school, year: year).call
+
+      if @school_year.persisted?
+        redirect_to admin_v2_school_year_path(@school_year), notice: t(".notice")
+      else
+        @breadcrumbs = [
+          { label: "School Years", path: admin_v2_school_years_path },
+          { label: "New School Year" }
+        ]
+        render :new, status: :unprocessable_content
+      end
+    rescue ActiveRecord::RecordInvalid => e
+      @school_year = e.record
+      @breadcrumbs = [
+        { label: "School Years", path: admin_v2_school_years_path },
+        { label: "New School Year" }
+      ]
+      render :new, status: :unprocessable_content
+    end
+
+    def update
+      if @school_year.update(school_year_params)
+        redirect_to admin_v2_school_year_path(@school_year), notice: t(".notice")
+      else
+        @breadcrumbs = [
+          { label: "School Years", path: admin_v2_school_years_path },
+          { label: @school_year.to_s, path: admin_v2_school_year_path(@school_year) },
+          { label: "Edit" }
+        ]
+        render :edit, status: :unprocessable_content
+      end
+    end
+
+    def destroy
+      @school_year.destroy
+      redirect_to admin_v2_school_years_path, notice: t(".notice")
+    rescue ActiveRecord::DeleteRestrictionError
+      redirect_to admin_v2_school_year_path(@school_year), alert: t(".delete_restricted")
+    end
+
+    private
+
+    def set_school_year
+      @school_year = SchoolYear.find(params.expect(:id))
+    end
+
+    def school_year_params
+      params.expect(school_year: %i[school_id year_id])
+    end
+  end
+end

app/controllers/admin_v2/stocks_controller.rb

@@ -0,0 +1,106 @@
+# frozen_string_literal: true
+
+module AdminV2
+  class StocksController < BaseController
+    before_action :set_stock, only: %i[show edit update destroy]
+
+    def index
+      @stocks = apply_sorting(Stock.all, default: "ticker")
+
+      @breadcrumbs = [
+        { label: "Stocks" }
+      ]
+    end
+
+    def show
+      @breadcrumbs = [
+        { label: "Stocks", path: admin_v2_stocks_path },
+        { label: @stock.ticker }
+      ]
+    end
+
+    def new
+      @stock = Stock.new
+
+      @breadcrumbs = [
+        { label: "Stocks", path: admin_v2_stocks_path },
+        { label: "New Stock" }
+      ]
+    end
+
+    def edit
+      @breadcrumbs = [
+        { label: "Stocks", path: admin_v2_stocks_path },
+        { label: @stock.ticker, path: admin_v2_stock_path(@stock) },
+        { label: "Edit" }
+      ]
+    end
+
+    def create
+      @stock = Stock.new(stock_params)
+
+      if @stock.save
+        redirect_to admin_v2_stock_path(@stock), notice: t(".notice")
+      else
+        @breadcrumbs = [
+          { label: "Stocks", path: admin_v2_stocks_path },
+          { label: "New Stock" }
+        ]
+        render :new, status: :unprocessable_content
+      end
+    end
+
+    def update
+      if @stock.update(stock_params)
+        redirect_to admin_v2_stock_path(@stock), notice: t(".notice")
+      else
+        @breadcrumbs = [
+          { label: "Stocks", path: admin_v2_stocks_path },
+          { label: @stock.ticker, path: admin_v2_stock_path(@stock) },
+          { label: "Edit" }
+        ]
+        render :edit, status: :unprocessable_content
+      end
+    end
+
+    def destroy
+      @stock.destroy
+      redirect_to admin_v2_stocks_path, notice: t(".notice")
+    rescue ActiveRecord::DeleteRestrictionError => e
+      redirect_to admin_v2_stocks_path, alert: "Cannot delete stock: #{e.message}"
+    end
+
+    private
+
+    def set_stock
+      @stock = Stock.find(params.expect(:id))
+    end
+
+    # rubocop:disable Metrics/MethodLength
+    def stock_params
+      params.expect(stock: %i[
+                      ticker
+                      company_name
+                      company_website
+                      stock_exchange
+                      description
+                      price_cents
+                      yesterday_price_cents
+                      employees
+                      industry
+                      cash_flow
+                      debt
+                      debt_to_equity
+                      profit_margin
+                      sales_growth
+                      industry_avg_debt_to_equity
+                      industry_avg_profit_margin
+                      industry_avg_sales_growth
+                      management
+                      competitor_names
+                      archived
+                    ])
+    end
+    # rubocop:enable Metrics/MethodLength
+  end
+end

app/form_builders/admin_v2/form_builder.rb

@@ -47,7 +47,7 @@ def number_field(attribute, options = {})
       end
     end
 
-    # Currency field with $ prefix and proper formatting
+    # Currency field with proper formatting
     # Usage: f.currency_field :price_cents, multiplier: 0.01, decimals: 2
     def currency_field(attribute, options = {})
       multiplier = options.delete(:multiplier) || 0.01
@@ -57,18 +57,13 @@ def currency_field(attribute, options = {})
         value = object.public_send(attribute)
         display_value = value ? (value * multiplier).round(decimals) : nil
 
-        @template.content_tag(:div, class: "relative rounded-md shadow-sm") do
-          @template.content_tag(:div, class: "pointer-events-none absolute inset-y-0 left-0 flex items-center pl-5") do
-            @template.content_tag(:span, "$", class: "text-gray-500 sm:text-sm")
-          end +
-            number_field(attribute,
-                         options.merge(
-                           value: display_value,
-                           step: (1.0 / (10**decimals)),
-                           class: "#{input_class(attribute)} pl-12",
-                           data: { currency_multiplier: (1.0 / multiplier).to_i }
-                         ))
-        end
+        number_field(attribute,
+                     options.merge(
+                       value: display_value,
+                       step: (1.0 / (10**decimals)),
+                       class: input_class(attribute),
+                       data: { currency_multiplier: (1.0 / multiplier).to_i }
+                     ))
       end
     end
 

app/models/classroom.rb

@@ -9,6 +9,9 @@ class Classroom < ApplicationRecord
   has_one :school, through: :school_year
   has_one :year, through: :school_year
 
+  delegate :name, to: :school, prefix: :school
+  delegate :name, to: :year, prefix: :year
+
   has_many :users, dependent: :nullify
   has_many :teacher_classrooms, dependent: :destroy
   has_many :teachers, through: :teacher_classrooms
@@ -44,15 +47,9 @@ def continuous?(values)
     values.each_cons(2).all? { |a, b| b == a + 1 }
   end
 
-  def to_s
-    if grades_display.present?
-      "#{name} (#{grades_display})"
-    else
-      name
-    end
-  end
-end
+  private
 
-def grade_level
-  errors.add(:grades, "must have at least one grade") if grades.empty?
+  def grade_level
+    errors.add(:grades, "must have at least one grade") if grades.empty?
+  end
 end

app/models/grade_entry.rb

@@ -4,6 +4,8 @@ class GradeEntry < ApplicationRecord
   belongs_to :grade_book
   belongs_to :user
 
+  delegate :username, to: :user
+
   EARNINGS_PER_DAY_ATTENDANCE = 20
   EARNINGS_FOR_A_GRADE = 3_00
   EARNINGS_FOR_B_GRADE = 2_00

app/models/portfolio.rb

@@ -6,6 +6,8 @@ class Portfolio < ApplicationRecord
   belongs_to :user
   validate :user_must_be_student
 
+  delegate :username, :student?, :school_name, :trading_enabled?, to: :user
+
   has_many :portfolio_transactions, dependent: :destroy
   has_many :portfolio_stocks, dependent: :destroy
   has_many :stocks, through: :portfolio_stocks

app/models/school_year.rb

@@ -6,7 +6,6 @@ class SchoolYear < ApplicationRecord
   has_many :classrooms, dependent: :restrict_with_error
   has_many :quarters, dependent: :restrict_with_error
 
-  def to_s
-    "#{school.name} (#{year.name})"
-  end
+  delegate :name, to: :school, prefix: :school
+  delegate :name, to: :year, prefix: :year
 end

app/models/user.rb

@@ -22,6 +22,8 @@ def really_destroy!
   # Allow calling `user.school` (used in portfolio view) via the classroom's associated school.
   # This prevents undefined method errors for Student records without directly adding a belongs_to.
   delegate :school, to: :classroom, allow_nil: true
+  delegate :name, to: :school, prefix: :school, allow_nil: true
+  delegate :trading_enabled?, to: :classroom, allow_nil: true
 
   has_one :portfolio, dependent: :destroy
   accepts_nested_attributes_for :portfolio

app/models/year.rb

@@ -7,6 +7,8 @@ class Year < ApplicationRecord
 
   validates :name, presence: true, uniqueness: true
 
+  scope :ordered_by_start_year, -> { order(Arel.sql("CAST(SUBSTRING(name FROM 1 FOR 4) AS INTEGER) DESC")) }
+
   def previous_year
     @previous_year || Year.find_by(name: "#{start_year_value - 1} - #{start_year_value}")
   end

app/presenters/base_presenter.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+class BasePresenter
+  attr_reader :object
+
+  def initialize(object)
+    @object = object
+  end
+
+  def method_missing(method_name, *, &)
+    if object.respond_to?(method_name)
+      object.public_send(method_name, *, &)
+    else
+      super
+    end
+  end
+
+  def respond_to_missing?(method_name, include_private = false)
+    object.respond_to?(method_name) || super
+  end
+end