Merge pull request #85 from rubygems/segiddins/allow-pushing-gems-with-attestations

Allow pushing gems with attestations

Author: hsbt

lib/gems/abstract_client.rb

@@ -10,9 +10,10 @@ def new(options = {})
       end
 
       # Delegate to Gems::Client
-      def method_missing(method, *args, &block)
+      def method_missing(method, ...)
         return super unless new.respond_to?(method)
-        new.send(method, *args, &block)
+
+        new.send(method, ...)
       end
 
       def respond_to?(method_name, include_private = false)

lib/gems/request.rb

@@ -37,6 +37,8 @@ def request(method, path, data, content_type, request_host = host) # rubocop:dis
       case content_type
       when 'application/x-www-form-urlencoded'
         request.form_data = data if %i[post put].include? method
+      when 'multipart/form-data'
+        request.set_form data, content_type if %i[post put].include? method
       when 'application/octet-stream'
         request.body = data
         request.content_length = data.size

lib/gems/v1/client.rb

@@ -61,11 +61,19 @@ def gems(user_handle = nil)
       # @authenticated true
       # @param gem [File] A built gem.
       # @param host [String] A RubyGems compatible host to use.
+      # @param attestations [Array] An array of attestations to push, or `nil`.
       # @return [String]
       # @example
       #   Gems.push File.new 'pkg/gemcutter-0.2.1.gem'
-      def push(gem, host = Configuration::DEFAULT_HOST)
-        post('/api/v1/gems', gem.read, 'application/octet-stream', host)
+      def push(gem, host = Configuration::DEFAULT_HOST, attestations: nil)
+        if attestations
+          post('/api/v1/gems',
+               [['gem', gem.read, {:filename => gem.path, :content_type => 'application/octet-stream'}],
+                ['attestations', "[#{attestations.map(&:read).join(',')}]", {:content_type => 'application/json'}]],
+               'multipart/form-data', host)
+        else
+          post('/api/v1/gems', gem.read, 'application/octet-stream', host)
+        end
       end
 
       # Remove a gem from RubyGems.org's index

spec/gems/client_v1_spec.rb

@@ -110,6 +110,18 @@
         expect(push).to eq 'Successfully registered gem: gems (0.0.8)'
       end
     end
+
+    context 'with the attestations parameter' do
+      before do
+        stub_post('/api/v1/gems').
+          to_return(:body => fixture('push'))
+      end
+      it 'submits a gem to RubyGems.org with attestations' do
+        push = Gems.push(File.new(File.expand_path('../../fixtures/gems-0.0.8.gem', __FILE__), 'rb'), :attestations => [File.new(File.expand_path('../../fixtures/gems-0.0.8.gem', __FILE__), 'rb')])
+        expect(a_post('/api/v1/gems')).to have_been_made
+        expect(push).to eq 'Successfully registered gem: gems (0.0.8)'
+      end
+    end
   end
 
   describe '#yank' do