Return immediately if a setting get is undefined. Resolves #431

wingrunr21 · wingrunr21 · commit e24532a88f69 · 2019-02-21T06:56:54.000-07:00
diff --git a/server/src/SettingsCache.ts b/server/src/SettingsCache.ts
@@ -70,6 +70,7 @@ class SettingsCache<P extends WorkspaceFolder | TextDocument, T> {
 	}
 
 	public async get(target: P | string): Promise<T | undefined> {
+		if (!target) return undefined;
 		const key = typeof target === 'string' ? target : target.uri;
 		let settings: T = this.cache.get(key);
 		if (!settings) {

Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,7 @@ class SettingsCache<P extends WorkspaceFolder \| TextDocument, T> {`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`public async get(target: P \| string): Promise<T \| undefined> {`
	`73`	`+ if (!target) return undefined;`
`73`	`74`	`const key = typeof target === 'string' ? target : target.uri;`
`74`	`75`	`let settings: T = this.cache.get(key);`
`75`	`76`	`if (!settings) {`