refactor(polymarket): rename #get to #list in TradeHistory and Candlesticks

Renames the #get method to #list in both TradeHistory and Candlesticks classes
to align with the project's naming conventions for non-HTTP-GET methods.
Updates corresponding tests and documentation.

Author: bougyman

lib/domeapi/polymarket/candlesticks.rb

@@ -4,17 +4,8 @@ module Rubyists
   module Domeapi
     module Polymarket
       # Candlesticks API endpoints
-      class Candlesticks
-        attr_reader :client
-
-        # @param client [Rubyists::Domeapi::Polymarket::Client]
-        #
-        # @return [void]
-        def initialize(client = Rubyists::Domeapi::Polymarket::Client.new)
-          @client = client
-        end
-
-        # Filter for candlestick data,
+      class Candlesticks < Endpoint
+        # Filter for listing candlesticks,
         # from https://docs.domeapi.io/api-reference/endpoint/get-candlesticks
         class Filter < Contract
           Properties = Struct.new(
@@ -41,7 +32,7 @@ class Filter < Contract
         #
         # @param filter [Filter] Filter options
         #
-        # @return [Hash] candlestick data
+        # @return [Candlestick] The candlestick data
         def list(filter = Filter.new(Filter::Properties.new))
           raise ArgumentError, filter.errors.full_messages.join(', ') unless filter.valid?
 

lib/domeapi/polymarket/endpoint.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module Rubyists
+  module Domeapi
+    module Polymarket
+      # Base class for Polymarket API endpoints
+      class Endpoint
+        attr_reader :client
+
+        # Initialize the Endpoint
+        #
+        # @param client [Client] The Domeapi client
+        #
+        # @return [void]
+        def initialize(client = nil)
+          @client = client || ::Rubyists::Domeapi::Client.new
+        end
+      end
+    end
+  end
+end

lib/domeapi/polymarket/markets.rb

@@ -11,7 +11,6 @@ class Markets
         # from https://docs.domeapi.io/api-reference/endpoint/get-markets
         class Filter < Contract
           Properties = Struct.new(
-            *custom_definitions,
             :market_slug,
             :event_slug,
             :condition_id,
@@ -26,7 +25,7 @@ class Filter < Contract
           )
 
           # Define properties with custom populator to skip optional params with nil values
-          (Properties.members - custom_definitions).each do |member|
+          Properties.members.each do |member|
             property member, populator: ->(value:, **) { value || skip! }
           end