Merge branch 'master' into coach_improvements

Author: juopmu

.rubocop.yml

@@ -19,3 +19,12 @@ Naming/PredicateName:
 
 Style/MutableConstant:
   Enabled: false
+
+Style/HashEachMethods:
+  Enabled: false
+
+Style/HashTransformKeys:
+  Enabled: false
+
+Style/HashTransformValues:
+  Enabled: false

.rubocop_todo.yml

@@ -11,15 +11,15 @@
 # Include: **/*.gemfile, **/Gemfile, **/gems.rb
 Bundler/DuplicatedGem:
   Exclude:
-    - 'Gemfile'
+    - "Gemfile"
 
 # Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: TreatCommentsAsGroupSeparators, Include.
 # Include: **/*.gemfile, **/Gemfile, **/gems.rb
 Bundler/OrderedGems:
   Exclude:
-    - 'Gemfile'
+    - "Gemfile"
 
 # Offense count: 4
 # Cop supports --auto-correct.
@@ -46,7 +46,7 @@ Layout/BlockAlignment:
 # Cop supports --auto-correct.
 Layout/CommentIndentation:
   Exclude:
-    - 'app/helpers/admin/templates_helper.rb'
+    - "app/helpers/admin/templates_helper.rb"
 
 # Offense count: 2
 # Cop supports --auto-correct.
@@ -66,7 +66,7 @@ Layout/DotPosition:
 # Cop supports --auto-correct.
 Layout/EmptyLineAfterGuardClause:
   Exclude:
-    - 'app/models/application.rb'
+    - "app/models/application.rb"
 
 # Offense count: 2
 # Cop supports --auto-correct.
@@ -84,7 +84,7 @@ Layout/EmptyLinesAroundBlockBody:
 # Cop supports --auto-correct.
 Layout/EmptyLinesAroundMethodBody:
   Exclude:
-    - 'app/controllers/admin/templates_controller.rb'
+    - "app/controllers/admin/templates_controller.rb"
 
 # Offense count: 6
 # Cop supports --auto-correct.
@@ -118,13 +118,13 @@ Layout/LeadingCommentSpace:
 # SupportedStyles: aligned, indented, indented_relative_to_receiver
 Layout/MultilineMethodCallIndentation:
   Exclude:
-    - 'app/controllers/admin/coach_applications_controller.rb'
+    - "app/controllers/admin/coach_applications_controller.rb"
 
 # Offense count: 1
 # Cop supports --auto-correct.
 Layout/RescueEnsureAlignment:
   Exclude:
-    - 'app/helpers/admin/templates_helper.rb'
+    - "app/helpers/admin/templates_helper.rb"
 
 # Offense count: 2
 # Cop supports --auto-correct.
@@ -135,7 +135,7 @@ Layout/SpaceAfterComma:
 # Cop supports --auto-correct.
 Layout/SpaceBeforeComma:
   Exclude:
-    - 'db/migrate/20180122202409_add_event_time.rb'
+    - "db/migrate/20180122202409_add_event_time.rb"
 
 # Offense count: 2
 # Cop supports --auto-correct.
@@ -144,7 +144,7 @@ Layout/SpaceBeforeComma:
 # SupportedStylesForEmptyBrackets: space, no_space
 Layout/SpaceInsideArrayLiteralBrackets:
   Exclude:
-    - 'config/environments/production.rb'
+    - "config/environments/production.rb"
 
 # Offense count: 6
 # Cop supports --auto-correct.
@@ -153,7 +153,7 @@ Layout/SpaceInsideArrayLiteralBrackets:
 # SupportedStylesForEmptyBraces: space, no_space
 Layout/SpaceInsideHashLiteralBraces:
   Exclude:
-    - 'test/controllers/applications_controller_test.rb'
+    - "test/controllers/applications_controller_test.rb"
 
 # Offense count: 11
 # Cop supports --auto-correct.
@@ -174,7 +174,7 @@ Layout/Tab:
 # SupportedStyles: final_newline, final_blank_line
 Layout/TrailingEmptyLines:
   Exclude:
-    - 'app/controllers/sessions_controller.rb'
+    - "app/controllers/sessions_controller.rb"
 
 # Offense count: 15
 # Cop supports --auto-correct.
@@ -185,7 +185,7 @@ Layout/TrailingWhitespace:
 # Offense count: 1
 Lint/UselessAssignment:
   Exclude:
-    - 'app/controllers/admin/applications_controller.rb'
+    - "app/controllers/admin/applications_controller.rb"
 
 # Offense count: 10
 Metrics/AbcSize:
@@ -202,14 +202,6 @@ Metrics/BlockLength:
 Metrics/MethodLength:
   Max: 34
 
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: braces, no_braces, context_dependent
-Style/BracesAroundHashParameters:
-  Exclude:
-    - 'test/system/edit_event_test.rb'
-
 # Offense count: 18
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
@@ -223,7 +215,7 @@ Style/ClassAndModuleChildren:
 # Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
 Style/CommentAnnotation:
   Exclude:
-    - 'app/helpers/admin/templates_helper.rb'
+    - "app/helpers/admin/templates_helper.rb"
 
 # Offense count: 64
 Style/Documentation:
@@ -264,7 +256,7 @@ Style/HashSyntax:
 # Configuration parameters: AllowIfModifier.
 Style/IfInsideElse:
   Exclude:
-    - 'app/controllers/applications_controller.rb'
+    - "app/controllers/applications_controller.rb"
 
 # Offense count: 4
 # Cop supports --auto-correct.
@@ -280,14 +272,14 @@ Style/MixinUsage:
 # Configuration parameters: MinDigits, Strict.
 Style/NumericLiterals:
   Exclude:
-    - 'db/schema.rb'
+    - "db/schema.rb"
 
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
   Exclude:
-    - 'config/spring.rb'
+    - "config/spring.rb"
 
 # Offense count: 2
 # Cop supports --auto-correct.
@@ -300,7 +292,7 @@ Style/RedundantBegin:
 # SupportedStyles: implicit, explicit
 Style/RescueStandardError:
   Exclude:
-    - 'app/helpers/admin/templates_helper.rb'
+    - "app/helpers/admin/templates_helper.rb"
 
 # Offense count: 2
 # Cop supports --auto-correct.
@@ -313,7 +305,7 @@ Style/SafeNavigation:
 # Cop supports --auto-correct.
 Style/StderrPuts:
   Exclude:
-    - 'bin/yarn'
+    - "bin/yarn"
 
 # Offense count: 567
 # Cop supports --auto-correct.
@@ -342,7 +334,7 @@ Style/SymbolArray:
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
 Style/TrailingCommaInHashLiteral:
   Exclude:
-    - 'app/helpers/admin/templates_helper.rb'
+    - "app/helpers/admin/templates_helper.rb"
 
 # Offense count: 122
 # Cop supports --auto-correct.

Gemfile.lock

@@ -121,7 +121,7 @@ GEM
     nokogiri (1.10.8)
       mini_portile2 (~> 2.4.0)
     parallel (1.19.1)
-    parser (2.7.0.1)
+    parser (2.7.0.2)
       ast (~> 2.4.0)
     pg (0.21.0)
     pry (0.12.2)
@@ -163,11 +163,13 @@ GEM
       ffi (~> 1.0)
     rb-readline (0.5.5)
     regexp_parser (1.6.0)
-    rubocop (0.79.0)
+    rexml (3.2.4)
+    rubocop (0.80.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
       parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
+      rexml
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 1.7)
     ruby-progressbar (1.10.1)
@@ -206,7 +208,7 @@ GEM
       thread_safe (~> 0.1)
     uglifier (4.2.0)
       execjs (>= 0.3.0, < 3)
-    unicode-display_width (1.6.0)
+    unicode-display_width (1.6.1)
     web-console (3.7.0)
       actionview (>= 5.0)
       activemodel (>= 5.0)

test/controllers/applications_controller_test.rb

@@ -11,14 +11,14 @@ class ApplicationsControllerTest < ActionDispatch::IntegrationTest
     event = create(:event, name: "Test Me", place: "Testing", installation_get_together_date: 13.days.from_now, scheduled_at: 2.weeks.from_now, application_start: Date.yesterday, application_end: Date.today, confirmation_date: 12.days.from_now)
     get "/events/#{event.id}/applications/new"
     assert_response 200
-    assert_select "h1", "Test Me #{i10n.l 13.days.from_now, format: :short} & #{i18n.l 2.weeks.from_now}"
+    assert_select "h1", "Test Me #{I18n.l 13.days.from_now.to_date, format: :short} & #{I18n.l 2.weeks.from_now.to_date}"
   end
 
   test "Get an event on the day the application period starts" do
     event = create(:event, name: "Test Me", place: "Testing", installation_get_together_date: 13.days.from_now, scheduled_at: 2.weeks.from_now, application_start: Date.today, application_end: Date.tomorrow, confirmation_date: 12.days.from_now)
     get "/events/#{event.id}/applications/new"
     assert_response 200
-    assert_select "h1", "Test Me #{i10n.l 13.days.from_now, format: :short} & #{i18n.l 2.weeks.from_now}"
+    assert_select "h1", "Test Me #{I18n.l 13.days.from_now.to_date, format: :short} & #{I18n.l 2.weeks.from_now.to_date}"
   end
 
   test "Get an event before application starts" do