Skip to content

Commit a79063f

Browse files
committed
chore: fix non-ambiguous typos with codespell
Fixed typos across the codebase (34 files): - shoud -> should (README.md) - primarly -> primarily (skyagent/README.md) - assitant -> assistant (skyagent/agents/base.py) - requirments -> requirements (skyagent/tasks/general_react/utils.py) - Hightlight -> Highlight (skyagent/tasks/swebench/utils.py) - tiemout -> timeout (skyagent/tasks/verifiers/naive_dapo.py) - feilds -> fields (skyagent/tools/prompt.py) - occured -> occurred (skyrl-gym/envs/lcb/livecodebench.py) - accesible -> accessible (skyrl-gym/envs/lcb/livecodebench.py) - comparision -> comparison (skyrl-gym/envs/lcb/livecodebench.py) - unkown -> unknown (skyrl-train/import_utils.py) - explictly -> explicitly (skyrl-train/pyproject.toml, workers/worker.py) - overriden -> overridden (skyrl-train/docs/configuration/config.rst) - Continous -> Continuous (skyrl-train/docs/configuration/config.rst) - atleast -> at least (skyrl-train/docs, entrypoints, inference_engines) - ore -> or (skyrl-train/docs/tutorials/tools_guide.rst) - envrionment -> environment (skyrl-train/docs/tutorials/tools_guide.rst) - intialize -> initialize (skyrl-train/skyrl_train/models.py) - advatanges -> advantages (skyrl-train/dataset/replay_buffer.py) - sychronizing -> synchronizing (skyrl-train/distributed/deepspeed_strategy.py) - vise -> vice (skyrl-train/distributed/ulysses/monkey_patch.py) - initalized -> initialized (skyrl-train/utils/ppo_utils.py) - efficent -> efficient (skyrl-train/utils/torch_utils.py) - divisble -> divisible (skyrl-train/utils/utils.py) - Gneration -> Generation (skyrl-train/utils/utils.py) - initalizing -> initializing (skyrl-train/tests/gpu/test_policy_local_engines_e2e.py) - onl -> only (ms-swift/docs/source/Instruction/常见问题整理.md) - initilize -> initialize (ms-swift/docs, examples, swift/plugin) - dimmension -> dimension (ms-swift/examples, swift/plugin) - everytime -> every time (ms-swift/examples/train/rft/rft.py) - bewteen -> between (ms-swift/swift/llm/infer/rollout.py) - loosing -> losing (ms-swift/swift/llm/train/tuner.py) - Reseach -> Research (example/analysis_on_student_loan/README.md) - reseach -> research (scripts/multi_rl.sh) URLs and variable names (eles) were preserved as configured
1 parent be507a8 commit a79063f

34 files changed

Lines changed: 50 additions & 50 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ For training, please refer to [`./deepanalyze/ms-swift/requirements.txt`](./deep
260260
answer = deepanalyze.generate(prompt, workspace=workspace)
261261
print(answer["reasoning"])
262262
```
263-
You shoud get a deep research report, which can be rendered as a PDF.:
263+
You should get a deep research report, which can be rendered as a PDF.:
264264
```text
265265
# Comprehensive Analysis of Student Enrollment Patterns and Institutional Transfers
266266

deepanalyze/SkyRL/skyagent/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
SkyAgent is a generic agent layer for training and evaluating agents.
44

5-
SkyAgent is designed primarly for researchers to have a unified interface around implementing agentic tasks. A modular design allows researchers to
5+
SkyAgent is designed primarily for researchers to have a unified interface around implementing agentic tasks. A modular design allows researchers to
66
1. bring in their own tasks
77
2. use any training backend or simply run evaluation
88
3. modify runtime implementation for a given task

deepanalyze/SkyRL/skyagent/skyagent/agents/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ def _post_process_results(
339339
has_finish_action_list.append(result.get("finish", False))
340340
finish_reason_list.append(result.get("finish_reason", None))
341341

342-
# Encode messages, get assitant mask and position ids
342+
# Encode messages, get assistant mask and position ids
343343
prompt_encodings = self.tokenizer.apply_chat_template(
344344
all_prompts,
345345
# return_tensors="pt",

deepanalyze/SkyRL/skyagent/skyagent/tasks/general_react/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def get_instruction(cls, instance: Dict[str, Any]) -> str:
2626
system_prompt = {
2727
"role": "system",
2828
"content": "Please solve the problem with the following tools and return the final answer inside the finish tool. \
29-
If there are additional requirments such as the answer should be included inside \\boxed{}, please return the answer in the format of \
29+
If there are additional requirements such as the answer should be included inside \\boxed{}, please return the answer in the format of \
3030
<function=finish> \
3131
<parameter=answer>\\boxed{'The final answer goes here.'}</parameter> \
3232
</function>"

deepanalyze/SkyRL/skyagent/skyagent/tasks/swebench/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,10 @@ def _get_swebench_workspace_dir_name(instance: pd.Series, dataset: str) -> str:
8585

8686
# Phase 1. READING: read the problem and reword it in clearer terms
8787
# 1.1 If there are code or config snippets. Express in words any best practices or conventions in them.
88-
# 1.2 Hightlight message errors, method names, variables, file names, stack traces, and technical details.
88+
# 1.2 Highlight message errors, method names, variables, file names, stack traces, and technical details.
8989
# 1.3 Explain the problem in clear terms.
9090
# 1.4 Enumerate the steps to reproduce the problem.
91-
# 1.5 Hightlight any best practices to take into account when testing and fixing the issue
91+
# 1.5 Highlight any best practices to take into account when testing and fixing the issue
9292

9393
# Phase 2. RUNNING: install and run the tests on the repository
9494
# 2.1 Follow the readme

deepanalyze/SkyRL/skyagent/skyagent/tasks/verifiers/naive_dapo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,7 @@ def compute_score(solution_str: str,
506506
if "\\pi" in extracted_model_output or "\\pi" in ground_truth:
507507
equivs = []
508508
for pi in [math.pi, 3.14]:
509-
equivs.append(math_equal(extracted_model_output, ground_truth, tiemout=True, pi=pi))
509+
equivs.append(math_equal(extracted_model_output, ground_truth, timeout=True, pi=pi))
510510
correct = any(equivs)
511511
else:
512512
correct = math_equal(extracted_model_output, ground_truth, timeout=True)

deepanalyze/SkyRL/skyagent/skyagent/tools/prompt.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@
1111
2. **Key Extraction for Evidence**: Identify and extract the **most relevant information** from the content, you never miss any important information, output the **full original context** of the content as far as possible, it can be more than three paragraphs.
1212
3. **Summary Output for Summary**: Organize into a concise paragraph with logical flow, prioritizing clarity and judge the contribution of the information to the goal.
1313
14-
**Final Output Format using JSON format has "rational", "evidence", "summary" feilds**
14+
**Final Output Format using JSON format has "rational", "evidence", "summary" fields**
1515
"""

deepanalyze/SkyRL/skyrl-gym/skyrl_gym/envs/lcb/livecodebench.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class TimeoutException(Exception):
8383

8484

8585
def timeout_handler(signum, frame):
86-
print("timeout occured: alarm went off")
86+
print("timeout occurred: alarm went off")
8787
raise TimeoutException
8888

8989

@@ -195,7 +195,7 @@ def compile_code(code: str, timeout: int):
195195
# else condition allows future extensibility to other platforms
196196
compiled_sol = tmp_sol.Solution()
197197
else:
198-
# do nothing in the other case since function is accesible
198+
# do nothing in the other case since function is accessible
199199
compiled_sol = tmp_sol
200200

201201
assert compiled_sol is not None
@@ -389,9 +389,9 @@ def grade_stdio(
389389
if stripped_prediction_line == stripped_gt_out_line:
390390
continue
391391

392-
## CASE 2: element-wise comparision
392+
## CASE 2: element-wise comparison
393393
## if there are floating elements
394-
## use `decimal` library for good floating point comparision
394+
## use `decimal` library for good floating point comparison
395395
## otherwise gotcha: np.isclose(50000000000000000, 50000000000000001) = True
396396
## note that we should always be able to convert to decimals
397397

deepanalyze/SkyRL/skyrl-train/docs/configuration/config.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,7 @@ Weight Transfer Configuration
468468
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
469469

470470
- ``generator.weight_sync_backend``: Backend to use for weight synchronization. Currently, we support ``nccl`` and ``gloo``.
471-
- ``generator.override_existing_update_group``: Whether to override the existing update group for the inference engine. This is applicable only for remote inference engines. During training, `skyrl-train` forms a custom process group ("update group") with the rank 0 training worker and all the inference engine ranks. If ``override_existing_update_group=enable``, then during initialization, a previous weight update group will be overriden in the inference engine. For example, if you have a remote server setup and you run training for the same model multiple times, it is helpful to override the previous update group. We recommend leaving this to ``auto`` - since it will automatically determine if the previous update group should be overridden based on ``run_engines_locally``.
471+
- ``generator.override_existing_update_group``: Whether to override the existing update group for the inference engine. This is applicable only for remote inference engines. During training, `skyrl-train` forms a custom process group ("update group") with the rank 0 training worker and all the inference engine ranks. If ``override_existing_update_group=enable``, then during initialization, a previous weight update group will be overridden in the inference engine. For example, if you have a remote server setup and you run training for the same model multiple times, it is helpful to override the previous update group. We recommend leaving this to ``auto`` - since it will automatically determine if the previous update group should be overridden based on ``run_engines_locally``.
472472

473473
Inference Engine Configuration
474474
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -481,8 +481,8 @@ Inference Engine Configuration
481481
- ``generator.vllm_v1_disable_multiproc``: If ``true``, this will set ``VLLM_ENABLE_V1_MULTIPROCESSING=0`` in the environment, which makes the scheduling deterministic. This is useful for reproducibility.
482482
- ``generator.enable_prefix_caching``: Whether to enable prefix caching for the inference engine. Applicable only when ``backend="vllm"``. This can be left to the default ``true`` in most cases. Note that in the case of remote inference engines, you would need to match the setting used when you initialized the remote servers.
483483
- ``generator.enable_chunked_prefill``: Whether to enable chunked prefill for the inference engine. Applicable only when ``backend="vllm"``. With vLLM, this can be left to the default ``true`` in most cases.
484-
- ``generator.max_num_seqs``: Continous batching parameter for vLLM. Maximum number of sequences to pack into a batch.
485-
- ``generator.max_num_batched_tokens``: Continous batching parameter for vLLM. Maximum number of tokens to pack into a batch.
484+
- ``generator.max_num_seqs``: Continuous batching parameter for vLLM. Maximum number of sequences to pack into a batch.
485+
- ``generator.max_num_batched_tokens``: Continuous batching parameter for vLLM. Maximum number of tokens to pack into a batch.
486486

487487

488488
Generation Parameters

deepanalyze/SkyRL/skyrl-train/docs/getting-started/development.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ CPU tests
4545
GPU tests
4646
~~~~~~~~~
4747

48-
The GPU tests require a node with atleast 8 GPUs. They have been tested on a 8xH100 node, but should work even on 8xA100 nodes. We are actively working on making these more accessible.
48+
The GPU tests require a node with at least 8 GPUs. They have been tested on a 8xH100 node, but should work even on 8xA100 nodes. We are actively working on making these more accessible.
4949

5050
.. code-block:: bash
5151

0 commit comments

Comments
 (0)