Feature to make max message and batch bytes configurable (#7)

* max message size option added in config, max size limit changed from 32kb to 1mb

* max message size option added in config, max size limit changed from 32kb to 1mb

* Added support for MaxMessageBytes and MaxBatchBytes configuration options

* Typo fixed

* Unwanted print statement removed

* Type and undefined reference issues fixed

* updated MaxMessageBytes logic

* Clean up and typo corrected

Co-authored-by: Moumita Mandal <moumita@rudderstack.com>
Co-authored-by: saikumarrs <saibattinoju@rudderstack.com>

Author: 3 people

analytics.go

@@ -537,7 +537,7 @@ func (c *client) push(q *messageQueue, m Message, wg *sync.WaitGroup, ex *execut
 	var msg message
 	var err error
 
-	if msg, err = makeMessage(m, maxMessageBytes); err != nil {
+	if msg, err = makeMessage(m, c.MaxMessageBytes); err != nil {
 		c.errorf("%s - %v", err, m)
 		c.notifyFailure([]message{{m, nil}}, err)
 		return
@@ -578,7 +578,7 @@ func (c *client) maxBatchBytes() int {
 		SentAt:    c.now(),
 		Context:   c.DefaultContext,
 	})
-	return maxBatchBytes - len(b)
+	return c.MaxBatchBytes - len(b)
 }
 
 func (c *client) notifySuccess(msgs []message) {

config.go

@@ -82,6 +82,12 @@ type Config struct {
 	//This variable will disable checking for the cluster-info end point and
 	//split the payload at node level for multi node setup
 	NoProxySupport bool
+
+	// Maximum bytes in a message
+	MaxMessageBytes int
+
+	// Maximum bytes in a batch
+	MaxBatchBytes int
 }
 
 // This constant sets the default endpoint to which client instances send
@@ -116,6 +122,22 @@ func (c *Config) validate() error {
 		}
 	}
 
+	if c.MaxMessageBytes < 0 {
+		return ConfigError{
+			Reason: "negetive value is not supported for MaxMessageBytes",
+			Field:  "MaxMessageBytes",
+			Value:  c.MaxMessageBytes,
+		}
+	}
+
+	if c.MaxBatchBytes < 0 {
+		return ConfigError{
+			Reason: "negetive value is not supported for MaxBatchBytes",
+			Field:  "MaxBatchBytes",
+			Value:  c.MaxBatchBytes,
+		}
+	}
+
 	return nil
 }
 
@@ -162,6 +184,14 @@ func makeConfig(c Config) Config {
 		c.maxConcurrentRequests = 1000
 	}
 
+	if c.MaxMessageBytes == 0 {
+		c.MaxMessageBytes = defMaxMessageBytes
+	}
+
+	if c.MaxBatchBytes == 0 {
+		c.MaxBatchBytes = defMaxBatchBytes
+	}
+
 	// We always overwrite the 'library' field of the default context set on the
 	// client because we want this information to be accurate.
 	c.DefaultContext.Library = LibraryInfo{

example/example-1.go

@@ -7,14 +7,19 @@ import (
 func main() {
 	// Instantiates a client to use send messages to the Rudder API.
 	// User your WRITE KEY in below placeholder "RUDDER WRITE KEY"
-	client := analytics.New("1aUR9IELHp6jqOW8HWkrYvMYHWy", "https://218da72a.ngrok.io")
+	client := analytics.New("1weqc5iqxRkpaUXHgDgYo3g34mg", "https://hosted.rudderlabs.com")
 
-	// Enqueues a track event that will be sent asynchronously.
-	client.Enqueue(analytics.Track{
-		UserId: "test-user",
-		Event:  "test-snippet",
-	})
+	if client!= nil{
+		// Enqueues a track event that will be sent asynchronously.
+		client.Enqueue(analytics.Track{
+			UserId: "test-user",
+			Event:  "test-snippet",
+			Properties: analytics.NewProperties().
+				Set("text", "Lorem Ipsum is simply dummy text of the printing and typesetting industry."),			
+		})
 
-	// Flushes any queued messages and closes the client.
-	client.Close()
+		// Flushes any queued messages and closes the client.
+		client.Close()
+	}
+	
 }

example/example-3.go

@@ -0,0 +1,28 @@
+package main
+
+import (
+	"github.com/rudderlabs/analytics-go"
+)
+
+func main() {
+	// Instantiates a client to use send messages to the Rudder API.
+	// User your WRITE KEY in below placeholder "RUDDER WRITE KEY"
+	client, _ := analytics.NewWithConfig("WRITE-KEY", "DATA-PLANE-URL",
+		analytics.Config{
+			MaxMessageBytes: 35000, //new field to control the max message size
+	})
+
+	if client!= nil{
+		// Enqueues a track event that will be sent asynchronously.
+		client.Enqueue(analytics.Track{
+			UserId: "test-user",
+			Event:  "test-snippet",
+			Properties: analytics.NewProperties().
+				Set("text", "Lorem Ipsum is simply dummy text of the printing and typesetting industry.  specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with cently ng and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s"),			
+		})
+
+		// Flushes any queued messages and closes the client.
+		client.Close()
+	}
+	
+}