Some places coming out as being located on null island

[MoralCode]

context: null island is a location in the ocean off the african coast where the lat/long is 0,0.

i just exported my saved places and about 4/6 of them are being set to null island.

I checked the source data and it seems like the place in the geojson where the coordinates are stored is indeed providing coordinates of 0,0, however, theres a google maps URL field that contains more plausible coordinates.

from the geoJSON:

 {
      "geometry": {
        "coordinates": [
          0,
          0
        ],
        "type": "Point"
      },
      "properties": {
        "date": "2024-05-28T18:42:08Z",
        "google_maps_url": "http://maps.google.com/?q=42.30039043516156,-71.12115081399679",
        "Comment": "No location information is available for this saved place"
      },
      "type": "Feature"
    },

Would it be helpful to include detection for these null coordinates and replacing them with the coordinates from the url?

[rudokemper]

I noticed that in my own GeoJSON too; seems like an artifact from Google's export code. And yes, that's a great suggestion to detect null coords and retrieve it from the URL instead! (If someone actually bookmarked null island, the coords from the URL would be the same anyway.)

Do you want to contribute that? Or I can handle it later, not at my computer this weekend.

[MoralCode]

im a good way there already :P apparrently the URLs can contain addresses (typically happens when the address isnt a business, otherwise google would have grabbed the coordinates already).

So yeah ill probably use https://nominatim.openstreetmap.org to look up coords for the addresses I find too

[sjbach]

Hi, this tool worked very well for me, except for Takeout's null island issue described here, affecting a fair number of my saved places. I see the linked pull request with a workaround isn't yet mergeable, and maybe stalled, but is it in a usable state? Is it worthwhile for me to try running locally?

Thanks for the tool & the patch.

[MoralCode]

It should be in a usable state, although you may need to manually add some delays to avoid hitting rate limiting if your places file is huge.

Not sure if/when I can revisit but things are pretty thoroughly documented in the linked PR