Skip to content

Commit 300a9dc

Browse files
danielhjacobstorokati44
authored andcommitted
extension: Don't build vanilla WASM module for web extensions
1 parent 67f0460 commit 300a9dc

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

.github/workflows/release_nightly.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ jobs:
312312
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
313313

314314
build-web:
315-
name: Build web${{ matrix.demo && ' demo' || '' }}
315+
name: Build web${{ matrix.demo && ' demo and selfhosted' || ' extensions' }}
316316
needs: create-nightly-release
317317
if: needs.create-nightly-release.outputs.is_active == 'true'
318318
runs-on: ubuntu-24.04
@@ -381,9 +381,10 @@ jobs:
381381
CARGO_FEATURES: jpegxr${{ matrix.demo && ',webgpu' || '' }}
382382
FIREFOX_EXTENSION_ID: ${{ secrets.FIREFOX_EXTENSION_ID }} # Needed to inject into manifest.json
383383
WASM_SOURCE: cargo_and_store
384+
BUILD_COMMAND: ${{ matrix.demo && 'npm run build:dual-wasm-repro' || 'npm run build:repro' }}
384385
working-directory: web
385386
shell: bash -l {0}
386-
run: npm run build:repro
387+
run: $BUILD_COMMAND
387388

388389
- name: Produce reproducible source archive
389390
if: ${{ !matrix.demo }}
@@ -407,7 +408,7 @@ jobs:
407408
run: npm run docs
408409

409410
- name: Publish npm package
410-
if: ${{ !matrix.demo }}
411+
if: matrix.demo
411412
# npm scoped packages are private by default, explicitly make public
412413
run: npm publish --access public --provenance
413414
continue-on-error: true
@@ -416,12 +417,12 @@ jobs:
416417
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
417418

418419
- name: Package selfhosted
419-
if: ${{ !matrix.demo }}
420+
if: matrix.demo
420421
run: zip -r "${{ needs.create-nightly-release.outputs.package_prefix }}-web-selfhosted.zip" .
421422
working-directory: web/packages/selfhosted/dist
422423

423424
- name: Upload selfhosted
424-
if: ${{ !matrix.demo }}
425+
if: matrix.demo
425426
run: |
426427
tag_name="${{ needs.create-nightly-release.outputs.tag_name }}"
427428
package_file="${{ needs.create-nightly-release.outputs.package_prefix }}-web-selfhosted.zip"

web/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@
4545
"build": "npm run build --workspace=ruffle-core && npm run build --workspace=ruffle-demo --workspace=ruffle-extension --workspace=ruffle-selfhosted",
4646
"build:debug": "cross-env NODE_ENV=development CARGO_FEATURES=avm_debug npm run build",
4747
"build:dual-wasm": "cross-env BUILD_WASM_MVP=true npm run build",
48-
"build:repro": "cross-env BUILD_WASM_MVP=true ENABLE_VERSION_SEAL=true npm run build",
48+
"build:repro": "cross-env ENABLE_VERSION_SEAL=true npm run build",
49+
"build:dual-wasm-repro": "cross-env BUILD_WASM_MVP=true ENABLE_VERSION_SEAL=true npm run build",
4950
"demo": "npm run preview --workspace ruffle-demo",
5051
"test": "npm test --workspaces --if-present",
5152
"wdio": "npm run wdio --workspaces --if-present --",

0 commit comments

Comments
 (0)