avm2: Remove uses of more static strings

1. We no longer create a static AvmString to compare broadcast event types to to ensure they're a whitelisted event.
2. We now allocate an AvmString for looking up builtin classes before storing them on SystemClasses/SystemClassDefs.

Author: Lord-McSweeney

core/src/avm2.rs

@@ -97,7 +97,8 @@ use self::api_version::ApiVersion;
 use self::object::WeakObject;
 use self::scope::Scope;
 
-const BROADCAST_WHITELIST: [&str; 4] = ["enterFrame", "exitFrame", "frameConstructed", "render"];
+const BROADCAST_WHITELIST: [&[u8]; 4] =
+    [b"enterFrame", b"exitFrame", b"frameConstructed", b"render"];
 
 const PREALLOCATED_STACK_SIZE: usize = 120000;
 
@@ -483,10 +484,7 @@ impl<'gc> Avm2<'gc> {
         object: Object<'gc>,
         event_name: AvmString<'gc>,
     ) {
-        if !BROADCAST_WHITELIST
-            .iter()
-            .any(|x| AvmString::from(*x) == event_name)
-        {
+        if !BROADCAST_WHITELIST.iter().any(|x| *x == &event_name) {
             return;
         }
 
@@ -521,10 +519,7 @@ impl<'gc> Avm2<'gc> {
     ) {
         let event_name = event.event().event_type();
 
-        if !BROADCAST_WHITELIST
-            .iter()
-            .any(|x| AvmString::from(*x) == event_name)
-        {
+        if !BROADCAST_WHITELIST.iter().any(|x| *x == &event_name) {
             return;
         }
 

core/src/avm2/globals.rs

@@ -9,6 +9,7 @@ use crate::avm2::traits::Trait;
 use crate::avm2::value::Value;
 use crate::avm2::vtable::VTable;
 use crate::avm2::{Avm2, Error, Multiname, Namespace, QName};
+use crate::string::WStr;
 use crate::tag_utils::{self, ControlFlow, SwfMovie, SwfSlice, SwfStream};
 use gc_arena::Collect;
 use std::sync::Arc;
@@ -812,9 +813,16 @@ macro_rules! avm2_system_classes_playerglobal {
     ($activation:expr, [$(($package:expr, $class_name:expr, $field:ident)),* $(,)?]) => {
         let activation = $activation;
         $(
+            // Package and class names are ASCII
+            let package = WStr::from_units($package.as_bytes());
+            let class_name = WStr::from_units($class_name.as_bytes());
+
+            let package = activation.strings().intern_static(package);
+            let class_name = activation.strings().intern_static(class_name);
+
             // Lookup with the highest version, so we we see all defined classes here
-            let ns = Namespace::package($package, ApiVersion::VM_INTERNAL, activation.strings());
-            let name = QName::new(ns, $class_name);
+            let ns = Namespace::package(package, ApiVersion::VM_INTERNAL, activation.strings());
+            let name = QName::new(ns, class_name);
             let class_object = activation.domain().get_defined_value(activation, name).unwrap_or_else(|e| panic!("Failed to lookup {name:?}: {e:?}"));
             let class_object = class_object.as_object().unwrap().as_class_object().unwrap();
             let sc = activation.avm2().system_classes.as_mut().unwrap();
@@ -827,11 +835,18 @@ macro_rules! avm2_system_class_defs_playerglobal {
     ($activation:expr, [$(($package:expr, $class_name:expr, $field:ident)),* $(,)?]) => {
         let activation = $activation;
         $(
+            // Package and class names are ASCII
+            let package = WStr::from_units($package.as_bytes());
+            let class_name = WStr::from_units($class_name.as_bytes());
+
+            let package = activation.strings().intern_static(package);
+            let class_name = activation.strings().intern_static(class_name);
+
             let domain = activation.domain();
 
             // Lookup with the highest version, so we we see all defined classes here
-            let ns = Namespace::package($package, ApiVersion::VM_INTERNAL, activation.strings());
-            let name = Multiname::new(ns, $class_name);
+            let ns = Namespace::package(package, ApiVersion::VM_INTERNAL, activation.strings());
+            let name = Multiname::new(ns, class_name);
             let class_def = domain.get_class(activation.context, &name).unwrap_or_else(|| panic!("Failed to lookup {name:?}"));
             let sc = activation.avm2().system_class_defs.as_mut().unwrap();
             sc.$field = class_def;